Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1607467

Re: [PATCH] ARM: gemini: don't select SERIAL_OF_PLATFORM

From Linus Walleij <linus.walleij@linaro.org>
Newsgroups linux.kernel
Subject Re: [PATCH] ARM: gemini: don't select SERIAL_OF_PLATFORM
Date 2017-03-23 14:10 +0100
Message-ID <toaF4-2Eh-31@gated-at.bofh.it> (permalink)
References <tnz2O-8X-13@gated-at.bofh.it> <to8ae-TC-33@gated-at.bofh.it> <to9SF-25x-13@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu, Mar 23, 2017 at 1:13 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Thu, Mar 23, 2017 at 11:22 AM, Linus Walleij
> <linus.walleij@linaro.org> wrote:
>> On Tue, Mar 21, 2017 at 9:52 PM, Arnd Bergmann <arnd@arndb.de> wrote:
>>
>>> We cannot select the option when SERIAL_8250 is not also set:
>>>
>>> warning: (ARCH_GEMINI) selects SERIAL_OF_PLATFORM which has unmet direct dependencies (TTY && HAS_IOMEM && SERIAL_8250 && OF)
>>>
>>> This removes the 'select' statement, requiring that users enable the
>>> option manually. Alternatively, we could make it a conditional
>>> 'select SERIAL_OF_PLATFORM if SERIAL_8250' or also select a handful
>>> of other symbols that it depends on.
>>>
>>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>>
>> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>>
>> Will you apply this directly to the interestingly misspelled
>> "gemeni/multiplatform" branch in the ARM SoC tree
>> directly?
>>
>> I will send pull requests on top of that branch later
>> for more features.
>
> If you are going to send more pull requests, just add the fixup there,
> it's not urgent.

OK thanks, I'll queue it.

Yours,
Linus Walleij

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH] ARM: gemini: don't select SERIAL_OF_PLATFORM Arnd Bergmann <arnd@arndb.de> - 2017-03-21 22:00 +0100
  Re: [PATCH] ARM: gemini: don't select SERIAL_OF_PLATFORM Linus Walleij <linus.walleij@linaro.org> - 2017-03-23 11:30 +0100
    Re: [PATCH] ARM: gemini: don't select SERIAL_OF_PLATFORM Arnd Bergmann <arnd@arndb.de> - 2017-03-23 13:20 +0100
      Re: [PATCH] ARM: gemini: don't select SERIAL_OF_PLATFORM Linus Walleij <linus.walleij@linaro.org> - 2017-03-23 14:10 +0100

csiph-web