Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1607200 > unrolled thread

[PATCH] staging:fbtft/fbtft-io: Fix incorrect type in assignment

Started byZhengyi Shen <shenzhengyi@gmail.com>
First post2017-03-23 08:40 +0100
Last post2017-03-23 14:40 +0100
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] staging:fbtft/fbtft-io: Fix incorrect type in assignment Zhengyi Shen <shenzhengyi@gmail.com> - 2017-03-23 08:40 +0100
    Re: [PATCH] staging:fbtft/fbtft-io: Fix incorrect type in assignment Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-03-23 14:40 +0100

#1607200 — [PATCH] staging:fbtft/fbtft-io: Fix incorrect type in assignment

FromZhengyi Shen <shenzhengyi@gmail.com>
Date2017-03-23 08:40 +0100
Subject[PATCH] staging:fbtft/fbtft-io: Fix incorrect type in assignment
Message-ID<to5vK-7s8-55@gated-at.bofh.it>
Fix endian sparse warnings of incorrect type in assignment.
This patch changes type to the appropriate endian specific versions.


Signed-off-by: Zhengyi Shen <shenzhengyi@gmail.com>
---
 drivers/staging/fbtft/fbtft-io.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/fbtft/fbtft-io.c b/drivers/staging/fbtft/fbtft-io.c
index d868405..ffb9a3b 100644
--- a/drivers/staging/fbtft/fbtft-io.c
+++ b/drivers/staging/fbtft/fbtft-io.c
@@ -71,7 +71,7 @@ int fbtft_write_spi_emulate_9(struct fbtft_par *par, void *buf, size_t len)
 			src++;
 		}
 		tmp |= ((*src & 0x0100) ? 1 : 0);
-		*(u64 *)dst = cpu_to_be64(tmp);
+		*(__be64 *)dst = cpu_to_be64(tmp);
 		dst += 8;
 		*dst++ = (u8)(*src++ & 0x00FF);
 		added++;
-- 
2.7.4

[toc] | [next] | [standalone]


#1607500

FromGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Date2017-03-23 14:40 +0100
Message-ID<tob86-2Oe-17@gated-at.bofh.it>
In reply to#1607200
On Thu, Mar 23, 2017 at 03:08:38PM +0800, Zhengyi Shen wrote:
> Fix endian sparse warnings of incorrect type in assignment.
> This patch changes type to the appropriate endian specific versions.
> 
> 
> Signed-off-by: Zhengyi Shen <shenzhengyi@gmail.com>
> ---
>  drivers/staging/fbtft/fbtft-io.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/fbtft/fbtft-io.c b/drivers/staging/fbtft/fbtft-io.c
> index d868405..ffb9a3b 100644
> --- a/drivers/staging/fbtft/fbtft-io.c
> +++ b/drivers/staging/fbtft/fbtft-io.c
> @@ -71,7 +71,7 @@ int fbtft_write_spi_emulate_9(struct fbtft_par *par, void *buf, size_t len)
>  			src++;
>  		}
>  		tmp |= ((*src & 0x0100) ? 1 : 0);
> -		*(u64 *)dst = cpu_to_be64(tmp);
> +		*(__be64 *)dst = cpu_to_be64(tmp);

Really?  I need an ack from a maintainer of this code before I'll take
this mess...

thanks,

greg k-h

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web