Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1607500

Re: [PATCH] staging:fbtft/fbtft-io: Fix incorrect type in assignment

Show all headers | View raw

On Thu, Mar 23, 2017 at 03:08:38PM +0800, Zhengyi Shen wrote:
> Fix endian sparse warnings of incorrect type in assignment.
> This patch changes type to the appropriate endian specific versions.
> 
> 
> Signed-off-by: Zhengyi Shen <shenzhengyi@gmail.com>
> ---
>  drivers/staging/fbtft/fbtft-io.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/fbtft/fbtft-io.c b/drivers/staging/fbtft/fbtft-io.c
> index d868405..ffb9a3b 100644
> --- a/drivers/staging/fbtft/fbtft-io.c
> +++ b/drivers/staging/fbtft/fbtft-io.c
> @@ -71,7 +71,7 @@ int fbtft_write_spi_emulate_9(struct fbtft_par *par, void *buf, size_t len)
>  			src++;
>  		}
>  		tmp |= ((*src & 0x0100) ? 1 : 0);
> -		*(u64 *)dst = cpu_to_be64(tmp);
> +		*(__be64 *)dst = cpu_to_be64(tmp);

Really?  I need an ack from a maintainer of this code before I'll take
this mess...

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] staging:fbtft/fbtft-io: Fix incorrect type in assignment Zhengyi Shen <shenzhengyi@gmail.com> - 2017-03-23 08:40 +0100
  Re: [PATCH] staging:fbtft/fbtft-io: Fix incorrect type in assignment Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-03-23 14:40 +0100

csiph-web