Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1605279 > unrolled thread
| Started by | Matthew Giassa <matthew@giassa.net> |
|---|---|
| First post | 2017-03-21 05:00 +0100 |
| Last post | 2017-03-21 15:20 +0100 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 2/2] staging: vt6656: rf.c: spaces preferred around that '-' Matthew Giassa <matthew@giassa.net> - 2017-03-21 05:00 +0100
Re: [PATCH 2/2] staging: vt6656: rf.c: spaces preferred around that '-' Dan Carpenter <dan.carpenter@oracle.com> - 2017-03-21 14:00 +0100
Re: [PATCH 2/2] staging: vt6656: rf.c: spaces preferred around that '-' Matthew Giassa <matthew@giassa.net> - 2017-03-21 15:20 +0100
| From | Matthew Giassa <matthew@giassa.net> |
|---|---|
| Date | 2017-03-21 05:00 +0100 |
| Subject | [PATCH 2/2] staging: vt6656: rf.c: spaces preferred around that '-' |
| Message-ID | <tnj7I-68t-21@gated-at.bofh.it> |
Resolving 2 checkpatch warnings generated due to: CHECK: spaces preferred around that '-' Signed-off-by: Matthew Giassa <matthew@giassa.net> --- drivers/staging/vt6656/rf.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/vt6656/rf.c b/drivers/staging/vt6656/rf.c index 0e3a62a..fe09627 100644 --- a/drivers/staging/vt6656/rf.c +++ b/drivers/staging/vt6656/rf.c @@ -611,7 +611,7 @@ int vnt_rf_write_embedded(struct vnt_private *priv, u32 data) reg_data[3] = (u8)(data >> 24); vnt_control_out(priv, MESSAGE_TYPE_WRITE_IFRF, - 0, 0, ARRAY_SIZE(reg_data), reg_data); + 0, 0, ARRAY_SIZE(reg_data), reg_data); return true; } @@ -643,9 +643,9 @@ int vnt_rf_setpower(struct vnt_private *priv, u32 rate, u32 channel) case RATE_48M: case RATE_54M: if (channel > CB_MAX_CHANNEL_24G) - power = priv->ofdm_a_pwr_tbl[channel-15]; + power = priv->ofdm_a_pwr_tbl[channel - 15]; else - power = priv->ofdm_pwr_tbl[channel-1]; + power = priv->ofdm_pwr_tbl[channel - 1]; break; } -- 2.7.4
[toc] | [next] | [standalone]
| From | Dan Carpenter <dan.carpenter@oracle.com> |
|---|---|
| Date | 2017-03-21 14:00 +0100 |
| Subject | Re: [PATCH 2/2] staging: vt6656: rf.c: spaces preferred around that '-' |
| Message-ID | <tnryi-3s7-21@gated-at.bofh.it> |
| In reply to | #1605279 |
On Mon, Mar 20, 2017 at 08:46:01PM -0700, Matthew Giassa wrote: > Resolving 2 checkpatch warnings generated due to: > CHECK: spaces preferred around that '-' > > Signed-off-by: Matthew Giassa <matthew@giassa.net> > --- > drivers/staging/vt6656/rf.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/vt6656/rf.c b/drivers/staging/vt6656/rf.c > index 0e3a62a..fe09627 100644 > --- a/drivers/staging/vt6656/rf.c > +++ b/drivers/staging/vt6656/rf.c > @@ -611,7 +611,7 @@ int vnt_rf_write_embedded(struct vnt_private *priv, u32 data) > reg_data[3] = (u8)(data >> 24); > > vnt_control_out(priv, MESSAGE_TYPE_WRITE_IFRF, > - 0, 0, ARRAY_SIZE(reg_data), reg_data); > + 0, 0, ARRAY_SIZE(reg_data), reg_data); This isn't described in the changelog. regards, dan carpenter
[toc] | [prev] | [next] | [standalone]
| From | Matthew Giassa <matthew@giassa.net> |
|---|---|
| Date | 2017-03-21 15:20 +0100 |
| Subject | Re: [PATCH 2/2] staging: vt6656: rf.c: spaces preferred around that '-' |
| Message-ID | <tnsNI-4r2-15@gated-at.bofh.it> |
| In reply to | #1605578 |
* Dan Carpenter <dan.carpenter@oracle.com> [2017-03-21 15:55:52 +0300]: >On Mon, Mar 20, 2017 at 08:46:01PM -0700, Matthew Giassa wrote: >> Resolving 2 checkpatch warnings generated due to: >> CHECK: spaces preferred around that '-' >> >> Signed-off-by: Matthew Giassa <matthew@giassa.net> >> --- >> drivers/staging/vt6656/rf.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/staging/vt6656/rf.c b/drivers/staging/vt6656/rf.c >> index 0e3a62a..fe09627 100644 >> --- a/drivers/staging/vt6656/rf.c >> +++ b/drivers/staging/vt6656/rf.c >> @@ -611,7 +611,7 @@ int vnt_rf_write_embedded(struct vnt_private *priv, u32 data) >> reg_data[3] = (u8)(data >> 24); >> >> vnt_control_out(priv, MESSAGE_TYPE_WRITE_IFRF, >> - 0, 0, ARRAY_SIZE(reg_data), reg_data); >> + 0, 0, ARRAY_SIZE(reg_data), reg_data); > >This isn't described in the changelog. > >regards, >dan carpenter > Would it be preferable if the changelog was more verbose? The literal text from the checkpatch.pl warning itself is indeed in the changelog: >On Mon, Mar 20, 2017 at 08:46:01PM -0700, Matthew Giassa wrote: >> Resolving 2 checkpatch warnings generated due to: >> CHECK: spaces preferred around that '-' Cheers.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web