Re: [PATCH 2/2] staging: vt6656: rf.c: spaces preferred around that '-'

From	Matthew Giassa <matthew@giassa.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] staging: vt6656: rf.c: spaces preferred around that '-'
Date	2017-03-21 15:20 +0100
Message-ID	<tnsNI-4r2-15@gated-at.bofh.it> (permalink)
References	<tnj7H-68t-3@gated-at.bofh.it> <tnj7I-68t-21@gated-at.bofh.it> <tnryi-3s7-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

* Dan Carpenter <dan.carpenter@oracle.com> [2017-03-21 15:55:52 +0300]:

>On Mon, Mar 20, 2017 at 08:46:01PM -0700, Matthew Giassa wrote:
>> Resolving 2 checkpatch warnings generated due to:
>> CHECK: spaces preferred around that '-'
>>
>> Signed-off-by: Matthew Giassa <matthew@giassa.net>
>> ---
>>  drivers/staging/vt6656/rf.c | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/staging/vt6656/rf.c b/drivers/staging/vt6656/rf.c
>> index 0e3a62a..fe09627 100644
>> --- a/drivers/staging/vt6656/rf.c
>> +++ b/drivers/staging/vt6656/rf.c
>> @@ -611,7 +611,7 @@ int vnt_rf_write_embedded(struct vnt_private *priv, u32 data)
>>  	reg_data[3] = (u8)(data >> 24);
>>
>>  	vnt_control_out(priv, MESSAGE_TYPE_WRITE_IFRF,
>> -				0, 0, ARRAY_SIZE(reg_data), reg_data);
>> +			0, 0, ARRAY_SIZE(reg_data), reg_data);
>
>This isn't described in the changelog.
>
>regards,
>dan carpenter
>

Would it be preferable if the changelog was more verbose? The
literal text from the checkpatch.pl warning itself is indeed in the
changelog:

>On Mon, Mar 20, 2017 at 08:46:01PM -0700, Matthew Giassa wrote:
>> Resolving 2 checkpatch warnings generated due to:
>> CHECK: spaces preferred around that '-'

Cheers.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] staging: vt6656: rf.c: spaces preferred around that '-' Matthew Giassa <matthew@giassa.net> - 2017-03-21 05:00 +0100
  Re: [PATCH 2/2] staging: vt6656: rf.c: spaces preferred around that  '-' Dan Carpenter <dan.carpenter@oracle.com> - 2017-03-21 14:00 +0100
    Re: [PATCH 2/2] staging: vt6656: rf.c: spaces preferred around that  '-' Matthew Giassa <matthew@giassa.net> - 2017-03-21 15:20 +0100

csiph-web