Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1604249 > unrolled thread

[PATCH 1/2] [net-next] net: dwc-xlgmac: include dcbnl.h

Started byArnd Bergmann <arnd@arndb.de>
First post2017-03-20 10:00 +0100
Last post2017-03-22 19:00 +0100
Articles 6 — 3 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH 1/2] [net-next] net: dwc-xlgmac: include dcbnl.h Arnd Bergmann <arnd@arndb.de> - 2017-03-20 10:00 +0100
    [PATCH 2/2] [net-next] net: dwc-xlgmac: add module license Arnd Bergmann <arnd@arndb.de> - 2017-03-20 10:00 +0100
      Re: [PATCH 2/2] [net-next] net: dwc-xlgmac: add module license Jie Deng <Jie.Deng1@synopsys.com> - 2017-03-21 03:40 +0100
      Re: [PATCH 2/2] [net-next] net: dwc-xlgmac: add module license David Miller <davem@davemloft.net> - 2017-03-22 19:00 +0100
    Re: [PATCH 1/2] [net-next] net: dwc-xlgmac: include dcbnl.h Jie Deng <Jie.Deng1@synopsys.com> - 2017-03-21 03:40 +0100
    Re: [PATCH 1/2] [net-next] net: dwc-xlgmac: include dcbnl.h David Miller <davem@davemloft.net> - 2017-03-22 19:00 +0100

#1604249 — [PATCH 1/2] [net-next] net: dwc-xlgmac: include dcbnl.h

FromArnd Bergmann <arnd@arndb.de>
Date2017-03-20 10:00 +0100
Subject[PATCH 1/2] [net-next] net: dwc-xlgmac: include dcbnl.h
Message-ID<tn1kt-2eN-7@gated-at.bofh.it>
Without this header, we can run into a build error:

drivers/net/ethernet/synopsys/dwc-xlgmac-hw.c: In function 'xlgmac_config_queue_mapping':
drivers/net/ethernet/synopsys/dwc-xlgmac-hw.c:1548:36: error: 'IEEE_8021QAZ_MAX_TCS' undeclared (first use in this function)
  prio_queues = min_t(unsigned int, IEEE_8021QAZ_MAX_TCS,

Fixes: 65e0ace2c5cd ("net: dwc-xlgmac: Initial driver for DesignWare Enterprise Ethernet")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/net/ethernet/synopsys/dwc-xlgmac-hw.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/synopsys/dwc-xlgmac-hw.c b/drivers/net/ethernet/synopsys/dwc-xlgmac-hw.c
index 5cf3e90d4834..1e25a86f6a27 100644
--- a/drivers/net/ethernet/synopsys/dwc-xlgmac-hw.c
+++ b/drivers/net/ethernet/synopsys/dwc-xlgmac-hw.c
@@ -22,6 +22,7 @@
 #include <linux/clk.h>
 #include <linux/bitrev.h>
 #include <linux/crc32.h>
+#include <linux/dcbnl.h>
 
 #include "dwc-xlgmac.h"
 #include "dwc-xlgmac-reg.h"
-- 
2.9.0

[toc] | [next] | [standalone]

#1604254 — [PATCH 2/2] [net-next] net: dwc-xlgmac: add module license

FromArnd Bergmann <arnd@arndb.de>
Date2017-03-20 10:00 +0100
Subject[PATCH 2/2] [net-next] net: dwc-xlgmac: add module license
Message-ID<tn1ku-2eN-15@gated-at.bofh.it>
In reply to#1604249
When building the driver as a module, we get a warning about the
lack of a license:

WARNING: modpost: missing MODULE_LICENSE() in drivers/net/ethernet/synopsys/dwc-xlgmac.o
see include/linux/module.h for more information

Curiously the text in the .c files only mentions GPLv2+, while the license
tag in the PCI driver contains both GPL and BSD. I picked the license text
as the more definite reference here and put a GPL tag in there.

Fixes: 65e0ace2c5cd ("net: dwc-xlgmac: Initial driver for DesignWare Enterprise Ethernet")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/net/ethernet/synopsys/dwc-xlgmac-common.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/synopsys/dwc-xlgmac-common.c b/drivers/net/ethernet/synopsys/dwc-xlgmac-common.c
index 726d78ac4907..b72196ab647f 100644
--- a/drivers/net/ethernet/synopsys/dwc-xlgmac-common.c
+++ b/drivers/net/ethernet/synopsys/dwc-xlgmac-common.c
@@ -25,6 +25,7 @@
 
 static int debug = -1;
 module_param(debug, int, 0644);
+MODULE_LICENSE("GPL");
 MODULE_PARM_DESC(debug, "DWC ethernet debug level (0=none,...,16=all)");
 static const u32 default_msg_level = (NETIF_MSG_LINK | NETIF_MSG_IFDOWN |
 				      NETIF_MSG_IFUP);
-- 
2.9.0

[toc] | [prev] | [next] | [standalone]

#1605262 — Re: [PATCH 2/2] [net-next] net: dwc-xlgmac: add module license

FromJie Deng <Jie.Deng1@synopsys.com>
Date2017-03-21 03:40 +0100
SubjectRe: [PATCH 2/2] [net-next] net: dwc-xlgmac: add module license
Message-ID<tnhSh-5lt-1@gated-at.bofh.it>
In reply to#1604254
On 2017/3/20 16:51, Arnd Bergmann wrote:
> When building the driver as a module, we get a warning about the
> lack of a license:
>
> WARNING: modpost: missing MODULE_LICENSE() in drivers/net/ethernet/synopsys/dwc-xlgmac.o
> see include/linux/module.h for more information
>
> Curiously the text in the .c files only mentions GPLv2+, while the license
> tag in the PCI driver contains both GPL and BSD. I picked the license text
> as the more definite reference here and put a GPL tag in there.
>
> Fixes: 65e0ace2c5cd ("net: dwc-xlgmac: Initial driver for DesignWare Enterprise Ethernet")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/net/ethernet/synopsys/dwc-xlgmac-common.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/synopsys/dwc-xlgmac-common.c b/drivers/net/ethernet/synopsys/dwc-xlgmac-common.c
> index 726d78ac4907..b72196ab647f 100644
> --- a/drivers/net/ethernet/synopsys/dwc-xlgmac-common.c
> +++ b/drivers/net/ethernet/synopsys/dwc-xlgmac-common.c
> @@ -25,6 +25,7 @@
>  
>  static int debug = -1;
>  module_param(debug, int, 0644);
> +MODULE_LICENSE("GPL");
>  MODULE_PARM_DESC(debug, "DWC ethernet debug level (0=none,...,16=all)");
>  static const u32 default_msg_level = (NETIF_MSG_LINK | NETIF_MSG_IFDOWN |
>  				      NETIF_MSG_IFUP);
This driver uses dual license. I will update the headers to include BSD. Thanks!

[toc] | [prev] | [next] | [standalone]

#1606865 — Re: [PATCH 2/2] [net-next] net: dwc-xlgmac: add module license

FromDavid Miller <davem@davemloft.net>
Date2017-03-22 19:00 +0100
SubjectRe: [PATCH 2/2] [net-next] net: dwc-xlgmac: add module license
Message-ID<tnSIb-6gL-59@gated-at.bofh.it>
In reply to#1604254
From: Arnd Bergmann <arnd@arndb.de>
Date: Mon, 20 Mar 2017 09:51:13 +0100

> When building the driver as a module, we get a warning about the
> lack of a license:
> 
> WARNING: modpost: missing MODULE_LICENSE() in drivers/net/ethernet/synopsys/dwc-xlgmac.o
> see include/linux/module.h for more information
> 
> Curiously the text in the .c files only mentions GPLv2+, while the license
> tag in the PCI driver contains both GPL and BSD. I picked the license text
> as the more definite reference here and put a GPL tag in there.
> 
> Fixes: 65e0ace2c5cd ("net: dwc-xlgmac: Initial driver for DesignWare Enterprise Ethernet")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Applied.

[toc] | [prev] | [next] | [standalone]

#1605264

FromJie Deng <Jie.Deng1@synopsys.com>
Date2017-03-21 03:40 +0100
Message-ID<tnhSh-5lt-5@gated-at.bofh.it>
In reply to#1604249

On 2017/3/20 16:51, Arnd Bergmann wrote:
> Without this header, we can run into a build error:
>
> drivers/net/ethernet/synopsys/dwc-xlgmac-hw.c: In function 'xlgmac_config_queue_mapping':
> drivers/net/ethernet/synopsys/dwc-xlgmac-hw.c:1548:36: error: 'IEEE_8021QAZ_MAX_TCS' undeclared (first use in this function)
>   prio_queues = min_t(unsigned int, IEEE_8021QAZ_MAX_TCS,
>
> Fixes: 65e0ace2c5cd ("net: dwc-xlgmac: Initial driver for DesignWare Enterprise Ethernet")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/net/ethernet/synopsys/dwc-xlgmac-hw.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/synopsys/dwc-xlgmac-hw.c b/drivers/net/ethernet/synopsys/dwc-xlgmac-hw.c
> index 5cf3e90d4834..1e25a86f6a27 100644
> --- a/drivers/net/ethernet/synopsys/dwc-xlgmac-hw.c
> +++ b/drivers/net/ethernet/synopsys/dwc-xlgmac-hw.c
> @@ -22,6 +22,7 @@
>  #include <linux/clk.h>
>  #include <linux/bitrev.h>
>  #include <linux/crc32.h>
> +#include <linux/dcbnl.h>
>  
>  #include "dwc-xlgmac.h"
>  #include "dwc-xlgmac-reg.h"
Thanks.
Reviewed-by: Jie Deng <jiedeng@synopsys.com>

[toc] | [prev] | [next] | [standalone]

#1606850

FromDavid Miller <davem@davemloft.net>
Date2017-03-22 19:00 +0100
Message-ID<tnSIa-6gL-23@gated-at.bofh.it>
In reply to#1604249
From: Arnd Bergmann <arnd@arndb.de>
Date: Mon, 20 Mar 2017 09:51:12 +0100

> Without this header, we can run into a build error:
> 
> drivers/net/ethernet/synopsys/dwc-xlgmac-hw.c: In function 'xlgmac_config_queue_mapping':
> drivers/net/ethernet/synopsys/dwc-xlgmac-hw.c:1548:36: error: 'IEEE_8021QAZ_MAX_TCS' undeclared (first use in this function)
>   prio_queues = min_t(unsigned int, IEEE_8021QAZ_MAX_TCS,
> 
> Fixes: 65e0ace2c5cd ("net: dwc-xlgmac: Initial driver for DesignWare Enterprise Ethernet")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Applied.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web