Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1605262
| From | Jie Deng <Jie.Deng1@synopsys.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/2] [net-next] net: dwc-xlgmac: add module license |
| Date | 2017-03-21 03:40 +0100 |
| Message-ID | <tnhSh-5lt-1@gated-at.bofh.it> (permalink) |
| References | <tn1kt-2eN-7@gated-at.bofh.it> <tn1ku-2eN-15@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 2017/3/20 16:51, Arnd Bergmann wrote:
> When building the driver as a module, we get a warning about the
> lack of a license:
>
> WARNING: modpost: missing MODULE_LICENSE() in drivers/net/ethernet/synopsys/dwc-xlgmac.o
> see include/linux/module.h for more information
>
> Curiously the text in the .c files only mentions GPLv2+, while the license
> tag in the PCI driver contains both GPL and BSD. I picked the license text
> as the more definite reference here and put a GPL tag in there.
>
> Fixes: 65e0ace2c5cd ("net: dwc-xlgmac: Initial driver for DesignWare Enterprise Ethernet")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/net/ethernet/synopsys/dwc-xlgmac-common.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/synopsys/dwc-xlgmac-common.c b/drivers/net/ethernet/synopsys/dwc-xlgmac-common.c
> index 726d78ac4907..b72196ab647f 100644
> --- a/drivers/net/ethernet/synopsys/dwc-xlgmac-common.c
> +++ b/drivers/net/ethernet/synopsys/dwc-xlgmac-common.c
> @@ -25,6 +25,7 @@
>
> static int debug = -1;
> module_param(debug, int, 0644);
> +MODULE_LICENSE("GPL");
> MODULE_PARM_DESC(debug, "DWC ethernet debug level (0=none,...,16=all)");
> static const u32 default_msg_level = (NETIF_MSG_LINK | NETIF_MSG_IFDOWN |
> NETIF_MSG_IFUP);
This driver uses dual license. I will update the headers to include BSD. Thanks!
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 1/2] [net-next] net: dwc-xlgmac: include dcbnl.h Arnd Bergmann <arnd@arndb.de> - 2017-03-20 10:00 +0100
[PATCH 2/2] [net-next] net: dwc-xlgmac: add module license Arnd Bergmann <arnd@arndb.de> - 2017-03-20 10:00 +0100
Re: [PATCH 2/2] [net-next] net: dwc-xlgmac: add module license Jie Deng <Jie.Deng1@synopsys.com> - 2017-03-21 03:40 +0100
Re: [PATCH 2/2] [net-next] net: dwc-xlgmac: add module license David Miller <davem@davemloft.net> - 2017-03-22 19:00 +0100
Re: [PATCH 1/2] [net-next] net: dwc-xlgmac: include dcbnl.h Jie Deng <Jie.Deng1@synopsys.com> - 2017-03-21 03:40 +0100
Re: [PATCH 1/2] [net-next] net: dwc-xlgmac: include dcbnl.h David Miller <davem@davemloft.net> - 2017-03-22 19:00 +0100
csiph-web