Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1605563 > unrolled thread
| Started by | Jaehoon Chung <jh80.chung@samsung.com> |
|---|---|
| First post | 2017-03-21 13:30 +0100 |
| Last post | 2017-03-25 00:20 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH] scsi: ufs: remove the duplicated checking for supporting clkscaling Jaehoon Chung <jh80.chung@samsung.com> - 2017-03-21 13:30 +0100
Re: [PATCH] scsi: ufs: remove the duplicated checking for supporting clkscaling Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2017-03-22 14:50 +0100
Re: [PATCH] scsi: ufs: remove the duplicated checking for supporting clkscaling Subhash Jadavani <subhashj@codeaurora.org> - 2017-03-25 00:20 +0100
| From | Jaehoon Chung <jh80.chung@samsung.com> |
|---|---|
| Date | 2017-03-21 13:30 +0100 |
| Subject | [PATCH] scsi: ufs: remove the duplicated checking for supporting clkscaling |
| Message-ID | <tnr5f-3gd-13@gated-at.bofh.it> |
There are same conditions for checking whether supporting clkscaling or not. When ufshcd is supporting clkscaling, active_reqs should be decreased by two. Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com> --- drivers/scsi/ufs/ufshcd.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index dc6efbd..f2cbc71 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c @@ -4598,8 +4598,6 @@ static void __ufshcd_transfer_req_compl(struct ufs_hba *hba, } if (ufshcd_is_clkscaling_supported(hba)) hba->clk_scaling.active_reqs--; - if (ufshcd_is_clkscaling_supported(hba)) - hba->clk_scaling.active_reqs--; } /* clear corresponding bits of completed commands */ -- 2.10.2
[toc] | [next] | [standalone]
| From | Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> |
|---|---|
| Date | 2017-03-22 14:50 +0100 |
| Message-ID | <tnOOd-3b8-1@gated-at.bofh.it> |
| In reply to | #1605563 |
Hi, On Tuesday, March 21, 2017 09:19:57 PM Jaehoon Chung wrote: > There are same conditions for checking whether supporting clkscaling or > not. > When ufshcd is supporting clkscaling, active_reqs should be decreased by > two. I guess you meant "one" here, not "two"? > Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com> > --- > drivers/scsi/ufs/ufshcd.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c > index dc6efbd..f2cbc71 100644 > --- a/drivers/scsi/ufs/ufshcd.c > +++ b/drivers/scsi/ufs/ufshcd.c > @@ -4598,8 +4598,6 @@ static void __ufshcd_transfer_req_compl(struct ufs_hba *hba, > } > if (ufshcd_is_clkscaling_supported(hba)) > hba->clk_scaling.active_reqs--; > - if (ufshcd_is_clkscaling_supported(hba)) > - hba->clk_scaling.active_reqs--; > } > > /* clear corresponding bits of completed commands */ Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics
[toc] | [prev] | [next] | [standalone]
| From | Subhash Jadavani <subhashj@codeaurora.org> |
|---|---|
| Date | 2017-03-25 00:20 +0100 |
| Message-ID | <toGEW-m5-21@gated-at.bofh.it> |
| In reply to | #1605563 |
On 2017-03-21 05:19, Jaehoon Chung wrote: > There are same conditions for checking whether supporting clkscaling or > not. > When ufshcd is supporting clkscaling, active_reqs should be decreased > by > two. > > Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com> > --- > drivers/scsi/ufs/ufshcd.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c > index dc6efbd..f2cbc71 100644 > --- a/drivers/scsi/ufs/ufshcd.c > +++ b/drivers/scsi/ufs/ufshcd.c > @@ -4598,8 +4598,6 @@ static void __ufshcd_transfer_req_compl(struct > ufs_hba *hba, > } > if (ufshcd_is_clkscaling_supported(hba)) > hba->clk_scaling.active_reqs--; > - if (ufshcd_is_clkscaling_supported(hba)) > - hba->clk_scaling.active_reqs--; > } > > /* clear corresponding bits of completed commands */ Looks good to me. Reviewed-by: Subhash Jadavani <subhashj@codeaurora.org> -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web