Re: [PATCH] scsi: ufs: remove the duplicated checking for supporting clkscaling

From	Subhash Jadavani <subhashj@codeaurora.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] scsi: ufs: remove the duplicated checking for supporting clkscaling
Date	2017-03-25 00:20 +0100
Message-ID	<toGEW-m5-21@gated-at.bofh.it> (permalink)
References	<tnr5f-3gd-15@gated-at.bofh.it> <tnr5f-3gd-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 2017-03-21 05:19, Jaehoon Chung wrote:
> There are same conditions for checking whether supporting clkscaling or
> not.
> When ufshcd is supporting clkscaling, active_reqs should be decreased 
> by
> two.
> 
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
> ---
>  drivers/scsi/ufs/ufshcd.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index dc6efbd..f2cbc71 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -4598,8 +4598,6 @@ static void __ufshcd_transfer_req_compl(struct
> ufs_hba *hba,
>  		}
>  		if (ufshcd_is_clkscaling_supported(hba))
>  			hba->clk_scaling.active_reqs--;
> -		if (ufshcd_is_clkscaling_supported(hba))
> -			hba->clk_scaling.active_reqs--;
>  	}
> 
>  	/* clear corresponding bits of completed commands */

Looks good to me.
Reviewed-by: Subhash Jadavani <subhashj@codeaurora.org>

-- 
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] scsi: ufs: remove the duplicated checking for supporting  clkscaling Jaehoon Chung <jh80.chung@samsung.com> - 2017-03-21 13:30 +0100
  Re: [PATCH] scsi: ufs: remove the duplicated checking for supporting  clkscaling Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2017-03-22 14:50 +0100
  Re: [PATCH] scsi: ufs: remove the duplicated checking for supporting  clkscaling Subhash Jadavani <subhashj@codeaurora.org> - 2017-03-25 00:20 +0100

csiph-web