Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1602940 > unrolled thread
| Started by | Tony Lindgren <tony@atomide.com> |
|---|---|
| First post | 2017-03-17 01:40 +0100 |
| Last post | 2017-03-20 12:20 +0100 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 4/4] mfd: cpcap: Fix bad use of IRQ sense register Tony Lindgren <tony@atomide.com> - 2017-03-17 01:40 +0100
Re: [PATCH 4/4] mfd: cpcap: Fix bad use of IRQ sense register Sebastian Reichel <sre@kernel.org> - 2017-03-19 03:30 +0100
Re: [PATCH 4/4] mfd: cpcap: Fix bad use of IRQ sense register Tony Lindgren <tony@atomide.com> - 2017-03-19 17:10 +0100
Re: [PATCH 4/4] mfd: cpcap: Fix bad use of IRQ sense register Lee Jones <lee.jones@linaro.org> - 2017-03-20 12:20 +0100
| From | Tony Lindgren <tony@atomide.com> |
|---|---|
| Date | 2017-03-17 01:40 +0100 |
| Subject | [PATCH 4/4] mfd: cpcap: Fix bad use of IRQ sense register |
| Message-ID | <tlO5Y-6ig-17@gated-at.bofh.it> |
The cpcap INTS registers are for getting the value of the line,
not for configuring the type.
Cc: Lee Jones <lee.jones@linaro.org>
Cc: Marcel Partap <mpartap@gmx.net>
Cc: Michael Scott <michael.scott@linaro.org>
Cc: Sebastian Reichel <sre@kernel.org>
Signed-off-by: Tony Lindgrne <tony@atomide.com>
---
drivers/mfd/motorola-cpcap.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mfd/motorola-cpcap.c b/drivers/mfd/motorola-cpcap.c
--- a/drivers/mfd/motorola-cpcap.c
+++ b/drivers/mfd/motorola-cpcap.c
@@ -115,7 +115,6 @@ static struct regmap_irq_chip cpcap_irq_chip[CPCAP_NR_IRQ_CHIPS] = {
.status_base = CPCAP_REG_INT1,
.ack_base = CPCAP_REG_INT1,
.mask_base = CPCAP_REG_INTM1,
- .type_base = CPCAP_REG_INTS1,
.use_ack = true,
.handle_reread = true,
.ack_invert = true,
--
2.11.1
[toc] | [next] | [standalone]
| From | Sebastian Reichel <sre@kernel.org> |
|---|---|
| Date | 2017-03-19 03:30 +0100 |
| Message-ID | <tmyLv-7ff-1@gated-at.bofh.it> |
| In reply to | #1602940 |
[Multipart message — attachments visible in raw view] — view raw
On Thu, Mar 16, 2017 at 05:36:33PM -0700, Tony Lindgren wrote:
> The cpcap INTS registers are for getting the value of the line,
> not for configuring the type.
>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: Marcel Partap <mpartap@gmx.net>
> Cc: Michael Scott <michael.scott@linaro.org>
> Cc: Sebastian Reichel <sre@kernel.org>
Reviewed-By: Sebastian Reichel <sre@kernel.org>
> Signed-off-by: Tony Lindgrne <tony@atomide.com>
https://lwn.net/Articles/717281/ ;)
-- Sebastian
> ---
> drivers/mfd/motorola-cpcap.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mfd/motorola-cpcap.c b/drivers/mfd/motorola-cpcap.c
> --- a/drivers/mfd/motorola-cpcap.c
> +++ b/drivers/mfd/motorola-cpcap.c
> @@ -115,7 +115,6 @@ static struct regmap_irq_chip cpcap_irq_chip[CPCAP_NR_IRQ_CHIPS] = {
> .status_base = CPCAP_REG_INT1,
> .ack_base = CPCAP_REG_INT1,
> .mask_base = CPCAP_REG_INTM1,
> - .type_base = CPCAP_REG_INTS1,
> .use_ack = true,
> .handle_reread = true,
> .ack_invert = true,
> --
> 2.11.1
[toc] | [prev] | [next] | [standalone]
| From | Tony Lindgren <tony@atomide.com> |
|---|---|
| Date | 2017-03-19 17:10 +0100 |
| Message-ID | <tmLz4-89I-25@gated-at.bofh.it> |
| In reply to | #1603882 |
* Sebastian Reichel <sre@kernel.org> [170318 19:03]: > On Thu, Mar 16, 2017 at 05:36:33PM -0700, Tony Lindgren wrote: > > The cpcap INTS registers are for getting the value of the line, > > not for configuring the type. > > > > Cc: Lee Jones <lee.jones@linaro.org> > > Cc: Marcel Partap <mpartap@gmx.net> > > Cc: Michael Scott <michael.scott@linaro.org> > > Cc: Sebastian Reichel <sre@kernel.org> > > Reviewed-By: Sebastian Reichel <sre@kernel.org> > > > Signed-off-by: Tony Lindgrne <tony@atomide.com> > > https://lwn.net/Articles/717281/ ;) Nah, just a time to clean-up the keyboard again! Tony
[toc] | [prev] | [next] | [standalone]
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Date | 2017-03-20 12:20 +0100 |
| Message-ID | <tn3vZ-3VF-31@gated-at.bofh.it> |
| In reply to | #1602940 |
On Thu, 16 Mar 2017, Tony Lindgren wrote:
> The cpcap INTS registers are for getting the value of the line,
> not for configuring the type.
>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: Marcel Partap <mpartap@gmx.net>
> Cc: Michael Scott <michael.scott@linaro.org>
> Cc: Sebastian Reichel <sre@kernel.org>
> Signed-off-by: Tony Lindgrne <tony@atomide.com>
Please resubmit with acquired Acks and your name spelt correctly.
Acked-by: Lee Jones <lee.jones@linaro.org>
> ---
> drivers/mfd/motorola-cpcap.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mfd/motorola-cpcap.c b/drivers/mfd/motorola-cpcap.c
> --- a/drivers/mfd/motorola-cpcap.c
> +++ b/drivers/mfd/motorola-cpcap.c
> @@ -115,7 +115,6 @@ static struct regmap_irq_chip cpcap_irq_chip[CPCAP_NR_IRQ_CHIPS] = {
> .status_base = CPCAP_REG_INT1,
> .ack_base = CPCAP_REG_INT1,
> .mask_base = CPCAP_REG_INTM1,
> - .type_base = CPCAP_REG_INTS1,
> .use_ack = true,
> .handle_reread = true,
> .ack_invert = true,
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web