Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1603882
| From | Sebastian Reichel <sre@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 4/4] mfd: cpcap: Fix bad use of IRQ sense register |
| Date | 2017-03-19 03:30 +0100 |
| Message-ID | <tmyLv-7ff-1@gated-at.bofh.it> (permalink) |
| References | <tlO5X-6ig-5@gated-at.bofh.it> <tlO5Y-6ig-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
On Thu, Mar 16, 2017 at 05:36:33PM -0700, Tony Lindgren wrote:
> The cpcap INTS registers are for getting the value of the line,
> not for configuring the type.
>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: Marcel Partap <mpartap@gmx.net>
> Cc: Michael Scott <michael.scott@linaro.org>
> Cc: Sebastian Reichel <sre@kernel.org>
Reviewed-By: Sebastian Reichel <sre@kernel.org>
> Signed-off-by: Tony Lindgrne <tony@atomide.com>
https://lwn.net/Articles/717281/ ;)
-- Sebastian
> ---
> drivers/mfd/motorola-cpcap.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mfd/motorola-cpcap.c b/drivers/mfd/motorola-cpcap.c
> --- a/drivers/mfd/motorola-cpcap.c
> +++ b/drivers/mfd/motorola-cpcap.c
> @@ -115,7 +115,6 @@ static struct regmap_irq_chip cpcap_irq_chip[CPCAP_NR_IRQ_CHIPS] = {
> .status_base = CPCAP_REG_INT1,
> .ack_base = CPCAP_REG_INT1,
> .mask_base = CPCAP_REG_INTM1,
> - .type_base = CPCAP_REG_INTS1,
> .use_ack = true,
> .handle_reread = true,
> .ack_invert = true,
> --
> 2.11.1
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 4/4] mfd: cpcap: Fix bad use of IRQ sense register Tony Lindgren <tony@atomide.com> - 2017-03-17 01:40 +0100
Re: [PATCH 4/4] mfd: cpcap: Fix bad use of IRQ sense register Sebastian Reichel <sre@kernel.org> - 2017-03-19 03:30 +0100
Re: [PATCH 4/4] mfd: cpcap: Fix bad use of IRQ sense register Tony Lindgren <tony@atomide.com> - 2017-03-19 17:10 +0100
Re: [PATCH 4/4] mfd: cpcap: Fix bad use of IRQ sense register Lee Jones <lee.jones@linaro.org> - 2017-03-20 12:20 +0100
csiph-web