Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1603826 > unrolled thread
| Started by | Borislav Petkov <bp@alien8.de> |
|---|---|
| First post | 2017-03-18 18:40 +0100 |
| Last post | 2017-03-18 19:00 +0100 |
| Articles | 3 — 1 participant |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v4 1/1] EDAC, pnd2_edac: Add new EDAC driver for Intel SoC platforms Borislav Petkov <bp@alien8.de> - 2017-03-18 18:40 +0100
[PATCH 1/2] EDAC: Select DEBUG_FS Borislav Petkov <bp@alien8.de> - 2017-03-18 18:50 +0100
[PATCH 2/2] EDAC, pnd2_edac: Fix !EDAC_DEBUG build Borislav Petkov <bp@alien8.de> - 2017-03-18 19:00 +0100
| From | Borislav Petkov <bp@alien8.de> |
|---|---|
| Date | 2017-03-18 18:40 +0100 |
| Subject | Re: [PATCH v4 1/1] EDAC, pnd2_edac: Add new EDAC driver for Intel SoC platforms |
| Message-ID | <tmquC-1ef-15@gated-at.bofh.it> |
Btw,
just broke the build with pnd2 due to EDAC_DEBUG + DEBUG_FS dependencies
missing. I'm replying to this mail with potential fixes but would like
to hammer on them more when I get back just to be sure I haven't missed
anything.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
--
[toc] | [next] | [standalone]
| From | Borislav Petkov <bp@alien8.de> |
|---|---|
| Date | 2017-03-18 18:50 +0100 |
| Subject | [PATCH 1/2] EDAC: Select DEBUG_FS |
| Message-ID | <tmqEh-1jI-5@gated-at.bofh.it> |
| In reply to | #1603826 |
The debugfs.c functionality relies on DEBUG_FS so select it.
Signed-off-by: Borislav Petkov <bp@suse.de>
---
drivers/edac/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/edac/Kconfig b/drivers/edac/Kconfig
index be3eac6ad54d..4773f2867234 100644
--- a/drivers/edac/Kconfig
+++ b/drivers/edac/Kconfig
@@ -43,6 +43,7 @@ config EDAC_LEGACY_SYSFS
config EDAC_DEBUG
bool "Debugging"
+ select DEBUG_FS
help
This turns on debugging information for the entire EDAC subsystem.
You do so by inserting edac_module with "edac_debug_level=x." Valid
--
2.8.4
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
--
[toc] | [prev] | [next] | [standalone]
| From | Borislav Petkov <bp@alien8.de> |
|---|---|
| Date | 2017-03-18 19:00 +0100 |
| Subject | [PATCH 2/2] EDAC, pnd2_edac: Fix !EDAC_DEBUG build |
| Message-ID | <tmqNX-1rz-3@gated-at.bofh.it> |
| In reply to | #1603826 |
Provide debugfs function stubs when EDAC_DEBUG is not enabled so that we
don't fail the build:
drivers/edac/pnd2_edac.c: In function ‘pnd2_init’:
drivers/edac/pnd2_edac.c:1521:2: error: implicit declaration of function ‘setup_pnd2_debug’ [-Werror=implicit-function-declaration]
setup_pnd2_debug();
^
drivers/edac/pnd2_edac.c: In function ‘pnd2_exit’:
drivers/edac/pnd2_edac.c:1529:2: error: implicit declaration of function ‘teardown_pnd2_debug’ [-Werror=implicit-function-declaration]
teardown_pnd2_debug();
^
Signed-off-by: Borislav Petkov <bp@suse.de>
---
drivers/edac/pnd2_edac.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/edac/pnd2_edac.c b/drivers/edac/pnd2_edac.c
index 14d39f05226e..ec2e349d728d 100644
--- a/drivers/edac/pnd2_edac.c
+++ b/drivers/edac/pnd2_edac.c
@@ -1435,7 +1435,11 @@ static void teardown_pnd2_debug(void)
{
debugfs_remove_recursive(pnd2_test);
}
-#endif
+#else
+static void setup_pnd2_debug(void) {}
+static void teardown_pnd2_debug(void) {}
+#endif /* CONFIG_EDAC_DEBUG */
+
static int pnd2_probe(void)
{
--
2.8.4
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
--
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web