[PATCH 2/2] EDAC, pnd2_edac: Fix !EDAC_DEBUG build

From	Borislav Petkov <bp@alien8.de>
Newsgroups	linux.kernel
Subject	[PATCH 2/2] EDAC, pnd2_edac: Fix !EDAC_DEBUG build
Date	2017-03-18 19:00 +0100
Message-ID	<tmqNX-1rz-3@gated-at.bofh.it> (permalink)
References	<tmquC-1ef-17@gated-at.bofh.it> <tmquC-1ef-19@gated-at.bofh.it> <tmquC-1ef-21@gated-at.bofh.it> <tmquC-1ef-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Provide debugfs function stubs when EDAC_DEBUG is not enabled so that we
don't fail the build:

  drivers/edac/pnd2_edac.c: In function ‘pnd2_init’:
  drivers/edac/pnd2_edac.c:1521:2: error: implicit declaration of function ‘setup_pnd2_debug’ [-Werror=implicit-function-declaration]
    setup_pnd2_debug();
    ^
  drivers/edac/pnd2_edac.c: In function ‘pnd2_exit’:
  drivers/edac/pnd2_edac.c:1529:2: error: implicit declaration of function ‘teardown_pnd2_debug’ [-Werror=implicit-function-declaration]
    teardown_pnd2_debug();
    ^

Signed-off-by: Borislav Petkov <bp@suse.de>
---
 drivers/edac/pnd2_edac.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/edac/pnd2_edac.c b/drivers/edac/pnd2_edac.c
index 14d39f05226e..ec2e349d728d 100644
--- a/drivers/edac/pnd2_edac.c
+++ b/drivers/edac/pnd2_edac.c
@@ -1435,7 +1435,11 @@ static void teardown_pnd2_debug(void)
 {
 	debugfs_remove_recursive(pnd2_test);
 }
-#endif
+#else
+static void setup_pnd2_debug(void)	{}
+static void teardown_pnd2_debug(void)	{}
+#endif /* CONFIG_EDAC_DEBUG */
+
 
 static int pnd2_probe(void)
 {
-- 
2.8.4

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v4 1/1] EDAC, pnd2_edac: Add new EDAC driver for Intel  SoC platforms Borislav Petkov <bp@alien8.de> - 2017-03-18 18:40 +0100
  [PATCH 1/2] EDAC: Select DEBUG_FS Borislav Petkov <bp@alien8.de> - 2017-03-18 18:50 +0100
  [PATCH 2/2] EDAC, pnd2_edac: Fix !EDAC_DEBUG build Borislav Petkov <bp@alien8.de> - 2017-03-18 19:00 +0100

csiph-web