Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1601610 > unrolled thread

Re: [PATCH 2/6] cpufreq: schedutil: ignore the sugov kthread for frequencies selections

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 2/6] cpufreq: schedutil: ignore the sugov kthread for  frequencies selections Patrick Bellasi <patrick.bellasi@arm.com> - 2017-03-15 19:10 +0100

#1601610 — Re: [PATCH 2/6] cpufreq: schedutil: ignore the sugov kthread for frequencies selections

On 06-Mar 09:35, Steven Rostedt wrote:
> On Thu,  2 Mar 2017 15:45:03 +0000
> Patrick Bellasi <patrick.bellasi@arm.com> wrote:
>  
> > @@ -287,6 +289,10 @@ static void sugov_update_shared(struct update_util_data *hook, u64 time,
> >  		goto done;
> >  	}
> >  
> > +	/* Skip updates generated by sugov kthreads */
> > +	if (curr == sg_policy->thread)
> 
> I think you want to put in an "unlikely()" around that statement. I'm
> assuming you don't care about he performance of scheduling in the sugov
> thread. At least tell gcc to optimize for the false path.

Right, good point! Will add it in the next posting! +1

Thanks!

-- 
#include <best/regards.h>

Patrick Bellasi

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web