Re: [PATCH 2/6] cpufreq: schedutil: ignore the sugov kthread for frequencies selections

From	Patrick Bellasi <patrick.bellasi@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/6] cpufreq: schedutil: ignore the sugov kthread for frequencies selections
Date	2017-03-15 19:10 +0100
Message-ID	<tllx0-2TA-19@gated-at.bofh.it> (permalink)
References	<tgB9n-4qi-3@gated-at.bofh.it> <tgBj3-4tT-5@gated-at.bofh.it> <ti1XQ-146-41@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 06-Mar 09:35, Steven Rostedt wrote:
> On Thu,  2 Mar 2017 15:45:03 +0000
> Patrick Bellasi <patrick.bellasi@arm.com> wrote:
>  
> > @@ -287,6 +289,10 @@ static void sugov_update_shared(struct update_util_data *hook, u64 time,
> >  		goto done;
> >  	}
> >  
> > +	/* Skip updates generated by sugov kthreads */
> > +	if (curr == sg_policy->thread)
> 
> I think you want to put in an "unlikely()" around that statement. I'm
> assuming you don't care about he performance of scheduling in the sugov
> thread. At least tell gcc to optimize for the false path.

Right, good point! Will add it in the next posting! +1

Thanks!

-- 
#include <best/regards.h>

Patrick Bellasi

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 2/6] cpufreq: schedutil: ignore the sugov kthread for  frequencies selections Patrick Bellasi <patrick.bellasi@arm.com> - 2017-03-15 19:10 +0100

csiph-web