Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1601211 > unrolled thread

[PATCH v1 1/7] include: dt-bindings: Add pin function index definition for rockchip pinctrl

Started by<cl@rock-chips.com>
First post2017-03-15 11:10 +0100
Last post2017-03-16 09:10 +0100
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCH v1 1/7] include: dt-bindings: Add pin function index definition for rockchip pinctrl <cl@rock-chips.com> - 2017-03-15 11:10 +0100
    Re: [PATCH v1 1/7] include: dt-bindings: Add pin function index definition for rockchip pinctrl Heiko Stübner <heiko@sntech.de> - 2017-03-16 09:10 +0100

#1601211 — [PATCH v1 1/7] include: dt-bindings: Add pin function index definition for rockchip pinctrl

From<cl@rock-chips.com>
Date2017-03-15 11:10 +0100
Subject[PATCH v1 1/7] include: dt-bindings: Add pin function index definition for rockchip pinctrl
Message-ID<tle2t-689-1@gated-at.bofh.it>
From: Chen Liang <cl@rock-chips.com>

The rk3328 soc need more pin function index for pinctrl.

Signed-off-by: Chen Liang <cl@rock-chips.com>
---
 include/dt-bindings/pinctrl/rockchip.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/include/dt-bindings/pinctrl/rockchip.h b/include/dt-bindings/pinctrl/rockchip.h
index aaec8ba..bc2b6af 100644
--- a/include/dt-bindings/pinctrl/rockchip.h
+++ b/include/dt-bindings/pinctrl/rockchip.h
@@ -63,5 +63,8 @@
 #define RK_FUNC_2	2
 #define RK_FUNC_3	3
 #define RK_FUNC_4	4
+#define RK_FUNC_5	5
+#define RK_FUNC_6	6
+#define RK_FUNC_7	7
 
 #endif
-- 
1.9.1

[toc] | [next] | [standalone]


#1602048

FromHeiko Stübner <heiko@sntech.de>
Date2017-03-16 09:10 +0100
Message-ID<tlyDV-3Np-29@gated-at.bofh.it>
In reply to#1601211
Hi,

Am Mittwoch, 15. März 2017, 18:03:51 CET schrieb cl@rock-chips.com:
> From: Chen Liang <cl@rock-chips.com>
> 
> The rk3328 soc need more pin function index for pinctrl.
> 
> Signed-off-by: Chen Liang <cl@rock-chips.com>
> ---
>  include/dt-bindings/pinctrl/rockchip.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/include/dt-bindings/pinctrl/rockchip.h
> b/include/dt-bindings/pinctrl/rockchip.h index aaec8ba..bc2b6af 100644
> --- a/include/dt-bindings/pinctrl/rockchip.h
> +++ b/include/dt-bindings/pinctrl/rockchip.h
> @@ -63,5 +63,8 @@
>  #define RK_FUNC_2	2
>  #define RK_FUNC_3	3
>  #define RK_FUNC_4	4
> +#define RK_FUNC_5	5
> +#define RK_FUNC_6	6
> +#define RK_FUNC_7	7

please don't amend that function list anymore.

Only RK_FUNC_GPIO serves a real purpose but having constants FUNC_7 mapping 
simply to 7 does not help understand things better, so it's way easier to just 
have "7" as function in pinctrl entries in the devicetree.

That list is mainly a remnant to keep compatibility with old devicetrees and I 
guess I should add a deprecated notice at some point :-) .


Heiko

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web