Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1602048

Re: [PATCH v1 1/7] include: dt-bindings: Add pin function index definition for rockchip pinctrl

Show all headers | View raw

Hi,

Am Mittwoch, 15. März 2017, 18:03:51 CET schrieb cl@rock-chips.com:
> From: Chen Liang <cl@rock-chips.com>
> 
> The rk3328 soc need more pin function index for pinctrl.
> 
> Signed-off-by: Chen Liang <cl@rock-chips.com>
> ---
>  include/dt-bindings/pinctrl/rockchip.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/include/dt-bindings/pinctrl/rockchip.h
> b/include/dt-bindings/pinctrl/rockchip.h index aaec8ba..bc2b6af 100644
> --- a/include/dt-bindings/pinctrl/rockchip.h
> +++ b/include/dt-bindings/pinctrl/rockchip.h
> @@ -63,5 +63,8 @@
>  #define RK_FUNC_2	2
>  #define RK_FUNC_3	3
>  #define RK_FUNC_4	4
> +#define RK_FUNC_5	5
> +#define RK_FUNC_6	6
> +#define RK_FUNC_7	7

please don't amend that function list anymore.

Only RK_FUNC_GPIO serves a real purpose but having constants FUNC_7 mapping 
simply to 7 does not help understand things better, so it's way easier to just 
have "7" as function in pinctrl entries in the devicetree.

That list is mainly a remnant to keep compatibility with old devicetrees and I 
guess I should add a deprecated notice at some point :-) .


Heiko

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v1 1/7] include: dt-bindings: Add pin function index definition for rockchip pinctrl <cl@rock-chips.com> - 2017-03-15 11:10 +0100
  Re: [PATCH v1 1/7] include: dt-bindings: Add pin function index definition for rockchip pinctrl Heiko Stübner <heiko@sntech.de> - 2017-03-16 09:10 +0100

csiph-web