Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1599172 > unrolled thread

[PATCH V3 0/5] thermal: minor cleanup/fixes

Back to article view | Back to linux.kernel

Contents

  [PATCH V3 0/5] thermal: minor cleanup/fixes Viresh Kumar <viresh.kumar@linaro.org> - 2017-03-13 11:10 +0100
    [PATCH V3 1/5] thermal: devfreq: Simplify expression Viresh Kumar <viresh.kumar@linaro.org> - 2017-03-13 11:10 +0100
    Re: [PATCH V3 0/5] thermal: minor cleanup/fixes Zhang Rui <rui.zhang@intel.com> - 2017-03-13 12:40 +0100

#1599172 — [PATCH V3 0/5] thermal: minor cleanup/fixes

Hi,

This series contains minor fixes/cleanups for thermal cooling drivers.

V2->V3:
- Added Acks from Rui
- Resending as it was getting ignored until now :(

V1->V2:
- s/dev_warn/dev_err (Rafael)
  - Two new patches to make similar (^^) change at other places

Viresh Kumar (5):
  thermal: devfreq: Simplify expression
  thermal: devfreq_cooling: Replace dev_warn with dev_err
  thermal: devfreq: Check OPP for errors
  thermal: cpu_cooling: Replace dev_warn with dev_err
  thermal: cpu_cooling: Check OPP for errors

 drivers/thermal/cpu_cooling.c     | 19 +++++++++++++------
 drivers/thermal/devfreq_cooling.c | 14 ++++++++++----
 2 files changed, 23 insertions(+), 10 deletions(-)

-- 
2.7.1.410.g6faf27b

[toc] | [next] | [standalone]

#1599173 — [PATCH V3 1/5] thermal: devfreq: Simplify expression

There is no need to check for IS_ERR() as we are looking for a very
particular error value here. Drop the first check.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Acked-by: Zhang Rui <rui.zhang@intel.com>
---
 drivers/thermal/devfreq_cooling.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/thermal/devfreq_cooling.c b/drivers/thermal/devfreq_cooling.c
index 7743a78d4723..4793fc7b06dd 100644
--- a/drivers/thermal/devfreq_cooling.c
+++ b/drivers/thermal/devfreq_cooling.c
@@ -186,7 +186,7 @@ get_static_power(struct devfreq_cooling_device *dfc, unsigned long freq)
 		return 0;
 
 	opp = dev_pm_opp_find_freq_exact(dev, freq, true);
-	if (IS_ERR(opp) && (PTR_ERR(opp) == -ERANGE))
+	if (PTR_ERR(opp) == -ERANGE)
 		opp = dev_pm_opp_find_freq_exact(dev, freq, false);
 
 	voltage = dev_pm_opp_get_voltage(opp) / 1000; /* mV */
-- 
2.7.1.410.g6faf27b

[toc] | [prev] | [next] | [standalone]

#1599237

On Mon, 2017-03-13 at 15:37 +0530, Viresh Kumar wrote:
> Hi,
> 
> This series contains minor fixes/cleanups for thermal cooling
> drivers.
> 
> V2->V3:
> - Added Acks from Rui
> - Resending as it was getting ignored until now :(

I just applied V2 this morning, and has not pushed to kernel.org yet.
The patch set should be queued for next -rc.

thanks,
rui
> 
> V1->V2:
> - s/dev_warn/dev_err (Rafael)
>   - Two new patches to make similar (^^) change at other places
> 
> Viresh Kumar (5):
>   thermal: devfreq: Simplify expression
>   thermal: devfreq_cooling: Replace dev_warn with dev_err
>   thermal: devfreq: Check OPP for errors
>   thermal: cpu_cooling: Replace dev_warn with dev_err
>   thermal: cpu_cooling: Check OPP for errors
> 
>  drivers/thermal/cpu_cooling.c     | 19 +++++++++++++------
>  drivers/thermal/devfreq_cooling.c | 14 ++++++++++----
>  2 files changed, 23 insertions(+), 10 deletions(-)
> 

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web