Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1599173
| From | Viresh Kumar <viresh.kumar@linaro.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH V3 1/5] thermal: devfreq: Simplify expression |
| Date | 2017-03-13 11:10 +0100 |
| Message-ID | <tkv5p-7pV-35@gated-at.bofh.it> (permalink) |
| References | <tkv5n-7pV-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
There is no need to check for IS_ERR() as we are looking for a very particular error value here. Drop the first check. Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> Acked-by: Zhang Rui <rui.zhang@intel.com> --- drivers/thermal/devfreq_cooling.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thermal/devfreq_cooling.c b/drivers/thermal/devfreq_cooling.c index 7743a78d4723..4793fc7b06dd 100644 --- a/drivers/thermal/devfreq_cooling.c +++ b/drivers/thermal/devfreq_cooling.c @@ -186,7 +186,7 @@ get_static_power(struct devfreq_cooling_device *dfc, unsigned long freq) return 0; opp = dev_pm_opp_find_freq_exact(dev, freq, true); - if (IS_ERR(opp) && (PTR_ERR(opp) == -ERANGE)) + if (PTR_ERR(opp) == -ERANGE) opp = dev_pm_opp_find_freq_exact(dev, freq, false); voltage = dev_pm_opp_get_voltage(opp) / 1000; /* mV */ -- 2.7.1.410.g6faf27b
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH V3 0/5] thermal: minor cleanup/fixes Viresh Kumar <viresh.kumar@linaro.org> - 2017-03-13 11:10 +0100 [PATCH V3 1/5] thermal: devfreq: Simplify expression Viresh Kumar <viresh.kumar@linaro.org> - 2017-03-13 11:10 +0100 Re: [PATCH V3 0/5] thermal: minor cleanup/fixes Zhang Rui <rui.zhang@intel.com> - 2017-03-13 12:40 +0100
csiph-web