Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1598713 > unrolled thread
| Started by | Bartosz Golaszewski <bgolaszewski@baylibre.com> |
|---|---|
| First post | 2017-03-12 20:00 +0100 |
| Last post | 2017-03-13 10:50 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] hid: cp2112: select GPIOLIB_IRQCHIP instead of depending on it Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2017-03-12 20:00 +0100
Re: [PATCH] hid: cp2112: select GPIOLIB_IRQCHIP instead of depending on it Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2017-03-13 10:50 +0100
| From | Bartosz Golaszewski <bgolaszewski@baylibre.com> |
|---|---|
| Date | 2017-03-12 20:00 +0100 |
| Subject | [PATCH] hid: cp2112: select GPIOLIB_IRQCHIP instead of depending on it |
| Message-ID | <tkgSK-5tn-7@gated-at.bofh.it> |
GPIOLIB_IRQCHIP is not visible to user, so we can't depend on it. Depend on GPIOLIB but select GPIOLIB_IRQCHIP. Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> --- drivers/hid/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig index 1aeb80e..00e2809 100644 --- a/drivers/hid/Kconfig +++ b/drivers/hid/Kconfig @@ -214,7 +214,8 @@ config HID_CMEDIA config HID_CP2112 tristate "Silicon Labs CP2112 HID USB-to-SMBus Bridge support" - depends on USB_HID && I2C && GPIOLIB && GPIOLIB_IRQCHIP + depends on USB_HID && I2C && GPIOLIB + select GPIOLIB_IRQCHIP ---help--- Support for Silicon Labs CP2112 HID USB to SMBus Master Bridge. This is a HID device driver which registers as an i2c adapter -- 2.9.3
[toc] | [next] | [standalone]
| From | Benjamin Tissoires <benjamin.tissoires@redhat.com> |
|---|---|
| Date | 2017-03-13 10:50 +0100 |
| Subject | Re: [PATCH] hid: cp2112: select GPIOLIB_IRQCHIP instead of depending on it |
| Message-ID | <tkuM2-717-23@gated-at.bofh.it> |
| In reply to | #1598713 |
On Mar 12 2017 or thereabouts, Bartosz Golaszewski wrote: > GPIOLIB_IRQCHIP is not visible to user, so we can't depend on it. > > Depend on GPIOLIB but select GPIOLIB_IRQCHIP. > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> > --- Makes sense. Good catch Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> > drivers/hid/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig > index 1aeb80e..00e2809 100644 > --- a/drivers/hid/Kconfig > +++ b/drivers/hid/Kconfig > @@ -214,7 +214,8 @@ config HID_CMEDIA > > config HID_CP2112 > tristate "Silicon Labs CP2112 HID USB-to-SMBus Bridge support" > - depends on USB_HID && I2C && GPIOLIB && GPIOLIB_IRQCHIP > + depends on USB_HID && I2C && GPIOLIB > + select GPIOLIB_IRQCHIP > ---help--- > Support for Silicon Labs CP2112 HID USB to SMBus Master Bridge. > This is a HID device driver which registers as an i2c adapter > -- > 2.9.3 >
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web