Re: [PATCH] hid: cp2112: select GPIOLIB_IRQCHIP instead of depending on it

From	Benjamin Tissoires <benjamin.tissoires@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] hid: cp2112: select GPIOLIB_IRQCHIP instead of depending on it
Date	2017-03-13 10:50 +0100
Message-ID	<tkuM2-717-23@gated-at.bofh.it> (permalink)
References	<tkgSK-5tn-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mar 12 2017 or thereabouts, Bartosz Golaszewski wrote:
> GPIOLIB_IRQCHIP is not visible to user, so we can't depend on it.
> 
> Depend on GPIOLIB but select GPIOLIB_IRQCHIP.
> 
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> ---

Makes sense. Good catch

Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>

>  drivers/hid/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> index 1aeb80e..00e2809 100644
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -214,7 +214,8 @@ config HID_CMEDIA
>  
>  config HID_CP2112
>  	tristate "Silicon Labs CP2112 HID USB-to-SMBus Bridge support"
> -	depends on USB_HID && I2C && GPIOLIB && GPIOLIB_IRQCHIP
> +	depends on USB_HID && I2C && GPIOLIB
> +	select GPIOLIB_IRQCHIP
>  	---help---
>  	Support for Silicon Labs CP2112 HID USB to SMBus Master Bridge.
>  	This is a HID device driver which registers as an i2c adapter
> -- 
> 2.9.3
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] hid: cp2112: select GPIOLIB_IRQCHIP instead of depending on it Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2017-03-12 20:00 +0100
  Re: [PATCH] hid: cp2112: select GPIOLIB_IRQCHIP instead of depending  on it Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2017-03-13 10:50 +0100

csiph-web