Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1598558 > unrolled thread

[PATCH] KVM: nVMX: don't reset kvm mmu twice

Started byWanpeng Li <kernellwp@gmail.com>
First post2017-03-12 10:00 +0100
Last post2017-03-13 09:40 +0100
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] KVM: nVMX: don't reset kvm mmu twice Wanpeng Li <kernellwp@gmail.com> - 2017-03-12 10:00 +0100
    Re: [PATCH] KVM: nVMX: don't reset kvm mmu twice David Hildenbrand <david@redhat.com> - 2017-03-13 09:40 +0100

#1598558 — [PATCH] KVM: nVMX: don't reset kvm mmu twice

FromWanpeng Li <kernellwp@gmail.com>
Date2017-03-12 10:00 +0100
Subject[PATCH] KVM: nVMX: don't reset kvm mmu twice
Message-ID<tk7w5-7rz-7@gated-at.bofh.it>
From: Wanpeng Li <wanpeng.li@hotmail.com>

kvm mmu is reset once successfully loading CR3 as part of emulating vmentry 
in nested_vmx_load_cr3(). We should not reset kvm mmu twice.

Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Radim Krčmář <rkrcmar@redhat.com>
Signed-off-by: Wanpeng Li <wanpeng.li@hotmail.com>
---
 arch/x86/kvm/vmx.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
index 98e82ee..bca8d7a 100644
--- a/arch/x86/kvm/vmx.c
+++ b/arch/x86/kvm/vmx.c
@@ -10286,8 +10286,6 @@ static int prepare_vmcs02(struct kvm_vcpu *vcpu, struct vmcs12 *vmcs12,
 				entry_failure_code))
 		return 1;
 
-	kvm_mmu_reset_context(vcpu);
-
 	if (!enable_ept)
 		vcpu->arch.walk_mmu->inject_page_fault = vmx_inject_page_fault_nested;
 
-- 
2.7.4

[toc] | [next] | [standalone]


#1598946

FromDavid Hildenbrand <david@redhat.com>
Date2017-03-13 09:40 +0100
Message-ID<tktGi-6dB-23@gated-at.bofh.it>
In reply to#1598558
Am 12.03.2017 um 09:53 schrieb Wanpeng Li:
> From: Wanpeng Li <wanpeng.li@hotmail.com>
> 
> kvm mmu is reset once successfully loading CR3 as part of emulating vmentry 
> in nested_vmx_load_cr3(). We should not reset kvm mmu twice.
> 
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Radim Krčmář <rkrcmar@redhat.com>
> Signed-off-by: Wanpeng Li <wanpeng.li@hotmail.com>
> ---
>  arch/x86/kvm/vmx.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index 98e82ee..bca8d7a 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -10286,8 +10286,6 @@ static int prepare_vmcs02(struct kvm_vcpu *vcpu, struct vmcs12 *vmcs12,
>  				entry_failure_code))
>  		return 1;
>  
> -	kvm_mmu_reset_context(vcpu);
> -
>  	if (!enable_ept)
>  		vcpu->arch.walk_mmu->inject_page_fault = vmx_inject_page_fault_nested;
>  
> 

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Thanks,

David

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web