Re: [PATCH] KVM: nVMX: don't reset kvm mmu twice

From	David Hildenbrand <david@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] KVM: nVMX: don't reset kvm mmu twice
Date	2017-03-13 09:40 +0100
Message-ID	<tktGi-6dB-23@gated-at.bofh.it> (permalink)
References	<tk7w5-7rz-7@gated-at.bofh.it>
Organization	Red Hat GmbH

Show all headers | View raw

Am 12.03.2017 um 09:53 schrieb Wanpeng Li:
> From: Wanpeng Li <wanpeng.li@hotmail.com>
> 
> kvm mmu is reset once successfully loading CR3 as part of emulating vmentry 
> in nested_vmx_load_cr3(). We should not reset kvm mmu twice.
> 
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Radim Krčmář <rkrcmar@redhat.com>
> Signed-off-by: Wanpeng Li <wanpeng.li@hotmail.com>
> ---
>  arch/x86/kvm/vmx.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index 98e82ee..bca8d7a 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -10286,8 +10286,6 @@ static int prepare_vmcs02(struct kvm_vcpu *vcpu, struct vmcs12 *vmcs12,
>  				entry_failure_code))
>  		return 1;
>  
> -	kvm_mmu_reset_context(vcpu);
> -
>  	if (!enable_ept)
>  		vcpu->arch.walk_mmu->inject_page_fault = vmx_inject_page_fault_nested;
>  
> 

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Thanks,

David

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] KVM: nVMX: don't reset kvm mmu twice Wanpeng Li <kernellwp@gmail.com> - 2017-03-12 10:00 +0100
  Re: [PATCH] KVM: nVMX: don't reset kvm mmu twice David Hildenbrand <david@redhat.com> - 2017-03-13 09:40 +0100

csiph-web