Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1600573 > unrolled thread

Re: [PATCH] pinctrl: rockchip: add irq_enable & irq_disable ops

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] pinctrl: rockchip: add irq_enable & irq_disable ops Linus Walleij <linus.walleij@linaro.org> - 2017-03-14 16:10 +0100

#1600573 — Re: [PATCH] pinctrl: rockchip: add irq_enable & irq_disable ops

On Thu, Mar 2, 2017 at 6:56 AM, Jeffy Chen <jeffy.chen@rock-chips.com> wrote:

> Currently we are trying to enable/disable the clk of irq's gpio bank when
> unmask/mask irq. But the kernel's "lazy disable approach" will skip masking
> irq when the irq chip doesn't support irq_disable ops.
>
> So we may hit this case:
>         irq_enable-> enable clk
>         irq_disable-> noop
>         irq_enable-> enable clk again
>         irq_disable-> noop
>
> Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>

Heiko, can you look at this patch?

Yours,
Linus Walleij

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web