Re: [PATCH] pinctrl: rockchip: add irq_enable & irq_disable ops

From	Linus Walleij <linus.walleij@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] pinctrl: rockchip: add irq_enable & irq_disable ops
Date	2017-03-14 16:10 +0100
Message-ID	<tkWfh-1T2-63@gated-at.bofh.it> (permalink)
References	<tgrWp-6db-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Mar 2, 2017 at 6:56 AM, Jeffy Chen <jeffy.chen@rock-chips.com> wrote:

> Currently we are trying to enable/disable the clk of irq's gpio bank when
> unmask/mask irq. But the kernel's "lazy disable approach" will skip masking
> irq when the irq chip doesn't support irq_disable ops.
>
> So we may hit this case:
>         irq_enable-> enable clk
>         irq_disable-> noop
>         irq_enable-> enable clk again
>         irq_disable-> noop
>
> Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>

Heiko, can you look at this patch?

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] pinctrl: rockchip: add irq_enable & irq_disable ops Linus Walleij <linus.walleij@linaro.org> - 2017-03-14 16:10 +0100

csiph-web