Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1600568 > unrolled thread

[PATCH v5 0/7] perf/sdt: Directly record SDT events with 'perf record'

Started byRavi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
First post2017-03-14 16:10 +0100
Last post2017-03-17 06:00 +0100
Articles 8 — 2 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH v5 0/7] perf/sdt: Directly record SDT events with 'perf record' Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> - 2017-03-14 16:10 +0100
    [PATCH v5 6/7] perf/sdt: List events fetched from uprobe_events Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> - 2017-03-14 16:10 +0100
    [PATCH v5 7/7] perf/sdt: List events fetched from uprobe_events Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> - 2017-03-14 16:10 +0100
      Re: [PATCH v5 7/7] perf/sdt: List events fetched from uprobe_events Masami Hiramatsu <mhiramat@kernel.org> - 2017-03-18 01:00 +0100
        Re: [PATCH v5 7/7] perf/sdt: List events fetched from uprobe_events Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> - 2017-03-20 10:20 +0100
    Re: [PATCH v5 0/7] perf/sdt: Directly record SDT events with 'perf  record' Masami Hiramatsu <mhiramat@kernel.org> - 2017-03-16 11:00 +0100
      Re: [PATCH v5 0/7] perf/sdt: Directly record SDT events with 'perf  record' Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> - 2017-03-16 12:30 +0100
        Re: [PATCH v5 0/7] perf/sdt: Directly record SDT events with 'perf  record' Masami Hiramatsu <mhiramat@kernel.org> - 2017-03-17 06:00 +0100

#1600568 — [PATCH v5 0/7] perf/sdt: Directly record SDT events with 'perf record'

FromRavi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
Date2017-03-14 16:10 +0100
Subject[PATCH v5 0/7] perf/sdt: Directly record SDT events with 'perf record'
Message-ID<tkWfg-1T2-33@gated-at.bofh.it>
All events from 'perf list', except SDT events, can be directly recorded
with 'perf record'. But, the flow is little different for SDT events.
Probe point for SDT event needs to be created using 'perf probe' before
recording it using 'perf record'.

As suggested by Ingo[1], it's better to make this process simple by
creating probe point automatically with 'perf record' for SDT events.

Features:
  - Allow both 'perf probe' and 'perf record' on sdt events without
    changing current functionality.

  - Event starting with 'sdt_' or '%' will be considered as SDT event.

  - Always prioritize events from uprobe_events by first checking if
    event exists with exact name. If not found and user has used
    pattern, again try to find pattern matching entries from
    uprobe_events. If found use them. If not, lookup into probe-cache.
    If events found from probe-cache, again check if any event exists
    in uprobe_events by matching filepath+address, as it might exists
    in uprobe_events but with different name. Reuse those events which
    exists in uprobe_events and create new entries for missing one.
    Also maintain list for new entries being created and at the end
    of the session, delete them.

  - Show various warnings/hints to help user understand _which_ events
    are being recorded and _why_. For ex,

    When multiple events of same name found and all are being recorded:

      $ sudo ./perf record -a -e sdt_libpthread:mutex_entry
        Warning: Recording on 2 occurrences of sdt_libpthread:mutex_entry

    Events being reused from uprobe_events is listed as 'name addr@file'
    followed by hint on how to delete them:

      $ sudo ./perf record -a -e sdt_libpthread:mutex_entry
        Matching event(s) from uprobe_events:
          sdt_libpthread:mutex_entry  0x9ddb@/usr/lib64/libpthread-2.24.so
        Use 'perf probe -d <event>' to delete event(s).

    If number of events found from cache is not equal to number of events
    being recorded:

      $ sudo ./perf record -a -e sdt_libpthread:mutex_entry
        Warning: Found 2 events from probe-cache with name 'sdt_libpthread:mutex_entry'.
                 Since 1 probe point already exists, recording only it.
        Hint: Please use 'perf probe -d sdt_libpthread:mutex_entry' to allow record on all events.

  - If all events found from probe-cache are not present in uprobe_events,
    and user has used pattern to specify event, perf will record only
    those events which are present in uprobe_events. This is to make perf
    semantics consistent across normal and SDT events. And If user has
    not used pattern, perf will record all events found from probe-cache
    by reusing name for existing one and adding entries for missing one.
    For ex,

      $ sudo ./perf probe sdt_libpthread:mutex_release
        Added new events:
          sdt_libpthread:mutex_release (on %mutex_release in /usr/lib64/libpthread-2.24.so)
          sdt_libpthread:mutex_release_1 (on %mutex_release in /usr/lib64/libpthread-2.24.so)
          sdt_libpthread:mutex_release_2 (on %mutex_release in /usr/lib64/libpthread-2.24.so)
          sdt_libpthread:mutex_release_3 (on %mutex_release in /usr/lib64/libpthread-2.24.so)
      $ sudo ./perf probe -d sdt_libpthread:mutex_release
      $ sudo ./perf probe -d sdt_libpthread:mutex_release_2

      $ sudo ./perf record -a -e sdt_libpthread:mutex_release*
        Warning: Recording on 2 occurrences of sdt_libpthread:mutex_release*

      $ sudo ./perf record -a -e sdt_libpthread:mutex_release
        Warning: Recording on 4 occurrences of sdt_libpthread:mutex_release

Changes in v5:
  - Patch 2/7 is new. New option introduced in this patch helps to pass
    custome data from builtin-*.c to libperf.

  - All direct callbacks from libelf to builtin-record.c is removed.
 
  - Merged 2nd and 4th patch of v4 into patch 2 of v5.

  - Moved all functions from util/probe-file.c to util/probe-event.c
    which operates on perf_probe_event.

  - Made free_sdt_list() static as it's only used inside util/probe-event.c.

  - Couple of other changes as Masami has suggested in v4 review.

Note: Patchset is prepared on top of acme/perf/core.

v4 link: https://lkml.org/lkml/2017/3/6/565

[1] https://lkml.org/lkml/2017/2/7/59
[2] https://lkml.org/lkml/2016/5/3/810


Hemant Kumar (1):
  perf/sdt: Directly record SDT events with 'perf record'

Ravi Bangoria (6):
  perf/sdt: Introduce util func is_sdt_event()
  perf tool: Add option macro OPT_CALLBACK_ARG
  perf/sdt: Allow recording of existing events
  perf/sdt: Warn when number of events recorded are not equal to cached
    events
  perf/sdt: List events fetched from uprobe_events
  perf/sdt: List events fetched from uprobe_events

 tools/lib/api/fs/tracing_path.c  |  17 +-
 tools/lib/subcmd/parse-options.h |   4 +
 tools/perf/builtin-record.c      |  27 ++-
 tools/perf/util/parse-events.c   |  60 +++++++
 tools/perf/util/parse-events.h   |  23 +++
 tools/perf/util/probe-event.c    | 362 +++++++++++++++++++++++++++++++++++++--
 tools/perf/util/probe-event.h    |  16 ++
 tools/perf/util/probe-file.c     |  48 ++++++
 tools/perf/util/probe-file.h     |   1 +
 9 files changed, 527 insertions(+), 31 deletions(-)

-- 
2.9.3

[toc] | [next] | [standalone]

#1600570 — [PATCH v5 6/7] perf/sdt: List events fetched from uprobe_events

FromRavi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
Date2017-03-14 16:10 +0100
Subject[PATCH v5 6/7] perf/sdt: List events fetched from uprobe_events
Message-ID<tkWfi-1T2-77@gated-at.bofh.it>
In reply to#1600568
List those events which are fetched from uprobe_events as 'event addr@file'
followed by hint on how these events can be deleted with 'perf probe -d'
command.

For example:
  $ sudo cat /sys/kernel/debug/tracing/uprobe_events
    p:sdt_libpthread/mutex_release /usr/lib64/libpthread-2.24.so:0x000000000000b126

  $ sudo ./perf record -a -e sdt_libpthread:mutex_release
    Matching event(s) from uprobe_events:
       sdt_libpthread:mutex_release  0xb126@/usr/lib64/libpthread-2.24.so
    Use 'perf probe -d <event>' to delete event(s).

Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
---
 tools/perf/util/probe-event.c | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
index 7bf8783..e150de0 100644
--- a/tools/perf/util/probe-event.c
+++ b/tools/perf/util/probe-event.c
@@ -3593,6 +3593,24 @@ static void sdt_warn_multi_events(int ctr, struct perf_probe_event *pev)
 		   ctr, pev->group, pev->event);
 }
 
+static void print_exst_sdt_events(struct probe_trace_event *tev)
+{
+	static bool msg_head;
+
+	if (!msg_head) {
+		pr_info("Matching event(s) from uprobe_events:\n");
+		msg_head = true;
+	}
+
+	pr_info("   %s:%s  0x%" PRIx64 "@%s\n", tev->group,
+		tev->event, tev->point.address, tev->point.module);
+}
+
+static void print_exst_sdt_event_footer(void)
+{
+	pr_info("Use 'perf probe -d <event>' to delete event(s).\n\n");
+}
+
 static int sdt_event_probepoint_exists(struct perf_probe_event *pev,
 				       struct probe_trace_event *tevs,
 				       int ntevs,
@@ -3607,10 +3625,14 @@ static int sdt_event_probepoint_exists(struct perf_probe_event *pev,
 			if (ret < 0)
 				return ret;
 
+			print_exst_sdt_events(&tevs[i]);
 			ctr++;
 		}
 	}
 
+	if (ctr > 0)
+		print_exst_sdt_event_footer();
+
 	if (ctr > 1)
 		sdt_warn_multi_events(ctr, pev);
 
@@ -3660,11 +3682,16 @@ static int sdt_merge_events(struct perf_probe_event *pev,
 
 				if (!ptrn_used)
 					shift_sdt_events(pev, i);
+
+				print_exst_sdt_events(&exst_tevs[j]);
 				ctr++;
 			}
 		}
 	}
 
+	if (ctr > 0)
+		print_exst_sdt_event_footer();
+
 	if (!ptrn_used || ctr == 0) {
 		/*
 		 * Create probe point for all probe-cached events by
-- 
2.9.3

[toc] | [prev] | [next] | [standalone]

#1600574 — [PATCH v5 7/7] perf/sdt: List events fetched from uprobe_events

FromRavi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
Date2017-03-14 16:10 +0100
Subject[PATCH v5 7/7] perf/sdt: List events fetched from uprobe_events
Message-ID<tkWfi-1T2-89@gated-at.bofh.it>
In reply to#1600568
Perf was showing warning if user tries to record sdt event without
creating a probepoint. Now we are allowing direct record on sdt
events, remove this stale warning/hint.

Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
---
 tools/lib/api/fs/tracing_path.c | 17 ++++-------------
 1 file changed, 4 insertions(+), 13 deletions(-)

diff --git a/tools/lib/api/fs/tracing_path.c b/tools/lib/api/fs/tracing_path.c
index 3e606b9..fa52e67 100644
--- a/tools/lib/api/fs/tracing_path.c
+++ b/tools/lib/api/fs/tracing_path.c
@@ -103,19 +103,10 @@ int tracing_path__strerror_open_tp(int err, char *buf, size_t size,
 		 * - jirka
 		 */
 		if (debugfs__configured() || tracefs__configured()) {
-			/* sdt markers */
-			if (!strncmp(filename, "sdt_", 4)) {
-				snprintf(buf, size,
-					"Error:\tFile %s/%s not found.\n"
-					"Hint:\tSDT event cannot be directly recorded on.\n"
-					"\tPlease first use 'perf probe %s:%s' before recording it.\n",
-					tracing_events_path, filename, sys, name);
-			} else {
-				snprintf(buf, size,
-					 "Error:\tFile %s/%s not found.\n"
-					 "Hint:\tPerhaps this kernel misses some CONFIG_ setting to enable this feature?.\n",
-					 tracing_events_path, filename);
-			}
+			snprintf(buf, size,
+				 "Error:\tFile %s/%s not found.\n"
+				 "Hint:\tPerhaps this kernel misses some CONFIG_ setting to enable this feature?.\n",
+				 tracing_events_path, filename);
 			break;
 		}
 		snprintf(buf, size, "%s",
-- 
2.9.3

[toc] | [prev] | [next] | [standalone]

#1603667 — Re: [PATCH v5 7/7] perf/sdt: List events fetched from uprobe_events

FromMasami Hiramatsu <mhiramat@kernel.org>
Date2017-03-18 01:00 +0100
SubjectRe: [PATCH v5 7/7] perf/sdt: List events fetched from uprobe_events
Message-ID<tm9WO-5YC-19@gated-at.bofh.it>
In reply to#1600574
The title of this patch seems not correct.

On Tue, 14 Mar 2017 20:36:58 +0530
Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> wrote:

> Perf was showing warning if user tries to record sdt event without
> creating a probepoint. Now we are allowing direct record on sdt
> events, remove this stale warning/hint.
> 
> Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
> ---
>  tools/lib/api/fs/tracing_path.c | 17 ++++-------------
>  1 file changed, 4 insertions(+), 13 deletions(-)
> 
> diff --git a/tools/lib/api/fs/tracing_path.c b/tools/lib/api/fs/tracing_path.c
> index 3e606b9..fa52e67 100644
> --- a/tools/lib/api/fs/tracing_path.c
> +++ b/tools/lib/api/fs/tracing_path.c
> @@ -103,19 +103,10 @@ int tracing_path__strerror_open_tp(int err, char *buf, size_t size,
>  		 * - jirka
>  		 */
>  		if (debugfs__configured() || tracefs__configured()) {
> -			/* sdt markers */
> -			if (!strncmp(filename, "sdt_", 4)) {
> -				snprintf(buf, size,
> -					"Error:\tFile %s/%s not found.\n"
> -					"Hint:\tSDT event cannot be directly recorded on.\n"
> -					"\tPlease first use 'perf probe %s:%s' before recording it.\n",
> -					tracing_events_path, filename, sys, name);
> -			} else {
> -				snprintf(buf, size,
> -					 "Error:\tFile %s/%s not found.\n"
> -					 "Hint:\tPerhaps this kernel misses some CONFIG_ setting to enable this feature?.\n",
> -					 tracing_events_path, filename);
> -			}
> +			snprintf(buf, size,
> +				 "Error:\tFile %s/%s not found.\n"
> +				 "Hint:\tPerhaps this kernel misses some CONFIG_ setting to enable this feature?.\n",
> +				 tracing_events_path, filename);
>  			break;
>  		}
>  		snprintf(buf, size, "%s",
> -- 
> 2.9.3
> 


-- 
Masami Hiramatsu <mhiramat@kernel.org>

[toc] | [prev] | [next] | [standalone]

#1604267 — Re: [PATCH v5 7/7] perf/sdt: List events fetched from uprobe_events

FromRavi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
Date2017-03-20 10:20 +0100
SubjectRe: [PATCH v5 7/7] perf/sdt: List events fetched from uprobe_events
Message-ID<tn1DP-2AT-11@gated-at.bofh.it>
In reply to#1603667

On Saturday 18 March 2017 04:44 AM, Masami Hiramatsu wrote:
> The title of this patch seems not correct.

Oops. Sorry about that. Actual title is:

    "perf/sdt: Remove stale warning"

Thanks for reporting,
Ravi

> On Tue, 14 Mar 2017 20:36:58 +0530
> Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> wrote:
>
>> Perf was showing warning if user tries to record sdt event without
>> creating a probepoint. Now we are allowing direct record on sdt
>> events, remove this stale warning/hint.
>>
>> Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>

[toc] | [prev] | [next] | [standalone]

#1602144 — Re: [PATCH v5 0/7] perf/sdt: Directly record SDT events with 'perf record'

FromMasami Hiramatsu <mhiramat@kernel.org>
Date2017-03-16 11:00 +0100
SubjectRe: [PATCH v5 0/7] perf/sdt: Directly record SDT events with 'perf record'
Message-ID<tlAmm-4QJ-9@gated-at.bofh.it>
In reply to#1600568
On Tue, 14 Mar 2017 20:36:51 +0530
Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> wrote:

> All events from 'perf list', except SDT events, can be directly recorded
> with 'perf record'. But, the flow is little different for SDT events.
> Probe point for SDT event needs to be created using 'perf probe' before
> recording it using 'perf record'.
> 
> As suggested by Ingo[1], it's better to make this process simple by
> creating probe point automatically with 'perf record' for SDT events.
> 
> Features:
>   - Allow both 'perf probe' and 'perf record' on sdt events without
>     changing current functionality.
> 
>   - Event starting with 'sdt_' or '%' will be considered as SDT event.
> 
>   - Always prioritize events from uprobe_events by first checking if
>     event exists with exact name. If not found and user has used
>     pattern, again try to find pattern matching entries from
>     uprobe_events. If found use them. If not, lookup into probe-cache.
>     If events found from probe-cache, again check if any event exists
>     in uprobe_events by matching filepath+address, as it might exists
>     in uprobe_events but with different name. Reuse those events which
>     exists in uprobe_events and create new entries for missing one.
>     Also maintain list for new entries being created and at the end
>     of the session, delete them.
> 
>   - Show various warnings/hints to help user understand _which_ events
>     are being recorded and _why_. For ex,
> 
>     When multiple events of same name found and all are being recorded:
> 
>       $ sudo ./perf record -a -e sdt_libpthread:mutex_entry
>         Warning: Recording on 2 occurrences of sdt_libpthread:mutex_entry
> 
>     Events being reused from uprobe_events is listed as 'name addr@file'
>     followed by hint on how to delete them:
> 
>       $ sudo ./perf record -a -e sdt_libpthread:mutex_entry
>         Matching event(s) from uprobe_events:
>           sdt_libpthread:mutex_entry  0x9ddb@/usr/lib64/libpthread-2.24.so
>         Use 'perf probe -d <event>' to delete event(s).
> 
>     If number of events found from cache is not equal to number of events
>     being recorded:
> 
>       $ sudo ./perf record -a -e sdt_libpthread:mutex_entry
>         Warning: Found 2 events from probe-cache with name 'sdt_libpthread:mutex_entry'.
>                  Since 1 probe point already exists, recording only it.
>         Hint: Please use 'perf probe -d sdt_libpthread:mutex_entry' to allow record on all events.
> 
>   - If all events found from probe-cache are not present in uprobe_events,
>     and user has used pattern to specify event, perf will record only
>     those events which are present in uprobe_events. This is to make perf
>     semantics consistent across normal and SDT events. And If user has
>     not used pattern, perf will record all events found from probe-cache
>     by reusing name for existing one and adding entries for missing one.
>     For ex,
> 
>       $ sudo ./perf probe sdt_libpthread:mutex_release
>         Added new events:
>           sdt_libpthread:mutex_release (on %mutex_release in /usr/lib64/libpthread-2.24.so)
>           sdt_libpthread:mutex_release_1 (on %mutex_release in /usr/lib64/libpthread-2.24.so)
>           sdt_libpthread:mutex_release_2 (on %mutex_release in /usr/lib64/libpthread-2.24.so)
>           sdt_libpthread:mutex_release_3 (on %mutex_release in /usr/lib64/libpthread-2.24.so)
>       $ sudo ./perf probe -d sdt_libpthread:mutex_release
>       $ sudo ./perf probe -d sdt_libpthread:mutex_release_2
> 
>       $ sudo ./perf record -a -e sdt_libpthread:mutex_release*
>         Warning: Recording on 2 occurrences of sdt_libpthread:mutex_release*
> 
>       $ sudo ./perf record -a -e sdt_libpthread:mutex_release
>         Warning: Recording on 4 occurrences of sdt_libpthread:mutex_release
> 
> Changes in v5:
>   - Patch 2/7 is new. New option introduced in this patch helps to pass
>     custome data from builtin-*.c to libperf.
> 
>   - All direct callbacks from libelf to builtin-record.c is removed.
>  
>   - Merged 2nd and 4th patch of v4 into patch 2 of v5.
> 
>   - Moved all functions from util/probe-file.c to util/probe-event.c
>     which operates on perf_probe_event.
> 
>   - Made free_sdt_list() static as it's only used inside util/probe-event.c.
> 
>   - Couple of other changes as Masami has suggested in v4 review.

Hi Ravi,
Could you also describe which patches are updated? It seems 1/7 is not
modified, correct?

Thank you,

-- 
Masami Hiramatsu <mhiramat@kernel.org>

[toc] | [prev] | [next] | [standalone]

#1602196 — Re: [PATCH v5 0/7] perf/sdt: Directly record SDT events with 'perf record'

FromRavi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
Date2017-03-16 12:30 +0100
SubjectRe: [PATCH v5 0/7] perf/sdt: Directly record SDT events with 'perf record'
Message-ID<tlBLs-5Y6-11@gated-at.bofh.it>
In reply to#1602144
Hi Masami,

On Thursday 16 March 2017 03:21 PM, Masami Hiramatsu wrote:
> On Tue, 14 Mar 2017 20:36:51 +0530
> Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> wrote:
>
>> Changes in v5:
>>   - Patch 2/7 is new. New option introduced in this patch helps to pass
>>     custome data from builtin-*.c to libperf.
>>
>>   - All direct callbacks from libelf to builtin-record.c is removed.
>>  

Minor correction.. s/libelf/libperf/

>>   - Merged 2nd and 4th patch of v4 into patch 2 of v5.

s/patch 2 of v5/patch 3 of v5/

>>
>>   - Moved all functions from util/probe-file.c to util/probe-event.c
>>     which operates on perf_probe_event.
>>
>>   - Made free_sdt_list() static as it's only used inside util/probe-event.c.
>>
>>   - Couple of other changes as Masami has suggested in v4 review.
> Hi Ravi,
> Could you also describe which patches are updated? It seems 1/7 is not
> modified, correct?

Let me list a patch-wise brief changelog.

patch 1/7:- Introduced dummy version of is_sdt_event() which always return false
             if !HAVE_LIBELF_SUPPORT.

patch 2/7: - is new. A new option introduced in this patch helps to passcustom
             data from builtin-*.c to libperf.

patch 3/7: - Removed direct calls from libperf to builtin-record.c which was used
             to prepare record.sdt_event_list. Instead pass list to libperf and let
             libperf manage it.

           - Introduce new wrapper func record__parse_events_option() that can
             differentiate between sdt and other events while parsing them in
             perf record.

           - Moved all functions from util/probe-file.c to util/probe-event.c
             which operates on perf_probe_event.

           - Merged 2nd and 4th patch of v4 into this patch.

           - Made free_sdt_list() static as it's only used inside util/probe-event.c.

patch 4/7:- Removed direct calls from libperf to builtin-record.c which was used
             to prepare record.sdt_event_list. Instead pass list to libperf and let
             libperf manage it.

           - Moved all functions from util/probe-file.c to util/probe-event.c
             which operates on perf_probe_event.

patch 5/7: No changes

patch 6/7: No changes

patch 7/7: No changes

Let me know if you need more details.

Thanks,
Ravi

[toc] | [prev] | [next] | [standalone]

#1603036 — Re: [PATCH v5 0/7] perf/sdt: Directly record SDT events with 'perf record'

FromMasami Hiramatsu <mhiramat@kernel.org>
Date2017-03-17 06:00 +0100
SubjectRe: [PATCH v5 0/7] perf/sdt: Directly record SDT events with 'perf record'
Message-ID<tlS9z-Ec-3@gated-at.bofh.it>
In reply to#1602196
Hi Ravi,

On Thu, 16 Mar 2017 16:57:52 +0530
Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> wrote:

> Hi Masami,
> 
> On Thursday 16 March 2017 03:21 PM, Masami Hiramatsu wrote:
> > On Tue, 14 Mar 2017 20:36:51 +0530
> > Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> wrote:
> >
> >> Changes in v5:
> >>   - Patch 2/7 is new. New option introduced in this patch helps to pass
> >>     custome data from builtin-*.c to libperf.
> >>
> >>   - All direct callbacks from libelf to builtin-record.c is removed.
> >>  
> 
> Minor correction.. s/libelf/libperf/
> 
> >>   - Merged 2nd and 4th patch of v4 into patch 2 of v5.
> 
> s/patch 2 of v5/patch 3 of v5/
> 
> >>
> >>   - Moved all functions from util/probe-file.c to util/probe-event.c
> >>     which operates on perf_probe_event.
> >>
> >>   - Made free_sdt_list() static as it's only used inside util/probe-event.c.
> >>
> >>   - Couple of other changes as Masami has suggested in v4 review.
> > Hi Ravi,
> > Could you also describe which patches are updated? It seems 1/7 is not
> > modified, correct?
> 
> Let me list a patch-wise brief changelog.
> 
> patch 1/7:- Introduced dummy version of is_sdt_event() which always return false
>              if !HAVE_LIBELF_SUPPORT.
> 
> patch 2/7: - is new. A new option introduced in this patch helps to passcustom
>              data from builtin-*.c to libperf.
> 
> patch 3/7: - Removed direct calls from libperf to builtin-record.c which was used
>              to prepare record.sdt_event_list. Instead pass list to libperf and let
>              libperf manage it.
> 
>            - Introduce new wrapper func record__parse_events_option() that can
>              differentiate between sdt and other events while parsing them in
>              perf record.
> 
>            - Moved all functions from util/probe-file.c to util/probe-event.c
>              which operates on perf_probe_event.
> 
>            - Merged 2nd and 4th patch of v4 into this patch.
> 
>            - Made free_sdt_list() static as it's only used inside util/probe-event.c.
> 
> patch 4/7:- Removed direct calls from libperf to builtin-record.c which was used
>              to prepare record.sdt_event_list. Instead pass list to libperf and let
>              libperf manage it.
> 
>            - Moved all functions from util/probe-file.c to util/probe-event.c
>              which operates on perf_probe_event.
> 
> patch 5/7: No changes
> 
> patch 6/7: No changes
> 
> patch 7/7: No changes
> 
> Let me know if you need more details.

Thanks! that's very helpful for me to review it.


-- 
Masami Hiramatsu <mhiramat@kernel.org>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web