Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1603667
| From | Masami Hiramatsu <mhiramat@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v5 7/7] perf/sdt: List events fetched from uprobe_events |
| Date | 2017-03-18 01:00 +0100 |
| Message-ID | <tm9WO-5YC-19@gated-at.bofh.it> (permalink) |
| References | <tkWfg-1T2-33@gated-at.bofh.it> <tkWfi-1T2-89@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
The title of this patch seems not correct.
On Tue, 14 Mar 2017 20:36:58 +0530
Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> wrote:
> Perf was showing warning if user tries to record sdt event without
> creating a probepoint. Now we are allowing direct record on sdt
> events, remove this stale warning/hint.
>
> Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
> ---
> tools/lib/api/fs/tracing_path.c | 17 ++++-------------
> 1 file changed, 4 insertions(+), 13 deletions(-)
>
> diff --git a/tools/lib/api/fs/tracing_path.c b/tools/lib/api/fs/tracing_path.c
> index 3e606b9..fa52e67 100644
> --- a/tools/lib/api/fs/tracing_path.c
> +++ b/tools/lib/api/fs/tracing_path.c
> @@ -103,19 +103,10 @@ int tracing_path__strerror_open_tp(int err, char *buf, size_t size,
> * - jirka
> */
> if (debugfs__configured() || tracefs__configured()) {
> - /* sdt markers */
> - if (!strncmp(filename, "sdt_", 4)) {
> - snprintf(buf, size,
> - "Error:\tFile %s/%s not found.\n"
> - "Hint:\tSDT event cannot be directly recorded on.\n"
> - "\tPlease first use 'perf probe %s:%s' before recording it.\n",
> - tracing_events_path, filename, sys, name);
> - } else {
> - snprintf(buf, size,
> - "Error:\tFile %s/%s not found.\n"
> - "Hint:\tPerhaps this kernel misses some CONFIG_ setting to enable this feature?.\n",
> - tracing_events_path, filename);
> - }
> + snprintf(buf, size,
> + "Error:\tFile %s/%s not found.\n"
> + "Hint:\tPerhaps this kernel misses some CONFIG_ setting to enable this feature?.\n",
> + tracing_events_path, filename);
> break;
> }
> snprintf(buf, size, "%s",
> --
> 2.9.3
>
--
Masami Hiramatsu <mhiramat@kernel.org>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v5 0/7] perf/sdt: Directly record SDT events with 'perf record' Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> - 2017-03-14 16:10 +0100
[PATCH v5 6/7] perf/sdt: List events fetched from uprobe_events Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> - 2017-03-14 16:10 +0100
[PATCH v5 7/7] perf/sdt: List events fetched from uprobe_events Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> - 2017-03-14 16:10 +0100
Re: [PATCH v5 7/7] perf/sdt: List events fetched from uprobe_events Masami Hiramatsu <mhiramat@kernel.org> - 2017-03-18 01:00 +0100
Re: [PATCH v5 7/7] perf/sdt: List events fetched from uprobe_events Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> - 2017-03-20 10:20 +0100
Re: [PATCH v5 0/7] perf/sdt: Directly record SDT events with 'perf record' Masami Hiramatsu <mhiramat@kernel.org> - 2017-03-16 11:00 +0100
Re: [PATCH v5 0/7] perf/sdt: Directly record SDT events with 'perf record' Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> - 2017-03-16 12:30 +0100
Re: [PATCH v5 0/7] perf/sdt: Directly record SDT events with 'perf record' Masami Hiramatsu <mhiramat@kernel.org> - 2017-03-17 06:00 +0100
csiph-web