Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1600273 > unrolled thread
| Started by | Sudeep Holla <sudeep.holla@arm.com> |
|---|---|
| First post | 2017-03-14 13:10 +0100 |
| Last post | 2017-03-14 16:40 +0100 |
| Articles | 5 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v3 02/25] openrisc: add cache way information to cpuinfo Sudeep Holla <sudeep.holla@arm.com> - 2017-03-14 13:10 +0100
Re: [PATCH v3 02/25] openrisc: add cache way information to cpuinfo Sudeep Holla <sudeep.holla@arm.com> - 2017-03-14 15:00 +0100
Re: [PATCH v3 02/25] openrisc: add cache way information to cpuinfo Stafford Horne <shorne@gmail.com> - 2017-03-14 15:10 +0100
Re: [PATCH v3 02/25] openrisc: add cache way information to cpuinfo Sudeep Holla <sudeep.holla@arm.com> - 2017-03-14 17:00 +0100
Re: [PATCH v3 02/25] openrisc: add cache way information to cpuinfo Stefan Kristiansson <stefan.kristiansson@saunalahti.fi> - 2017-03-14 16:40 +0100
| From | Sudeep Holla <sudeep.holla@arm.com> |
|---|---|
| Date | 2017-03-14 13:10 +0100 |
| Subject | Re: [PATCH v3 02/25] openrisc: add cache way information to cpuinfo |
| Message-ID | <tkTr4-8mX-19@gated-at.bofh.it> |
On Tue, Feb 21, 2017 at 7:11 PM, Stafford Horne <shorne@gmail.com> wrote: > From: Stefan Kristiansson <stefan.kristiansson@saunalahti.fi> > > Motivation for this is to be able to print the way information > properly in print_cpuinfo(), instead of hardcoding it to one. > Any particular reason not to use generic cacheinfo sysfs infrastructure ? -- Regards, Sudeep
[toc] | [next] | [standalone]
| From | Sudeep Holla <sudeep.holla@arm.com> |
|---|---|
| Date | 2017-03-14 15:00 +0100 |
| Message-ID | <tkV9w-Uf-7@gated-at.bofh.it> |
| In reply to | #1600273 |
On 14/03/17 13:11, Stefan Kristiansson wrote: > On Tue, Mar 14, 2017 at 12:08:33PM +0000, Sudeep Holla wrote: >> On Tue, Feb 21, 2017 at 7:11 PM, Stafford Horne <shorne@gmail.com> wrote: >>> From: Stefan Kristiansson <stefan.kristiansson@saunalahti.fi> >>> >>> Motivation for this is to be able to print the way information >>> properly in print_cpuinfo(), instead of hardcoding it to one. >>> >> >> Any particular reason not to use generic cacheinfo sysfs infrastructure ? >> > > No reason as far as I can see, the creation of this patch predates the > generic cacheinfo sysfs infrastructure. > > The patch itself doesn't add cache information to cpuinfo though, > only corrects a bug in the information that is already there. > > We should look into exposing the info in the generic cache info sysfs > and potentially removing the information from cpuinfo. > Ah OK, sorry I mistook it as a new addition rather than bug fox. -- Regards, Sudeep
[toc] | [prev] | [next] | [standalone]
| From | Stafford Horne <shorne@gmail.com> |
|---|---|
| Date | 2017-03-14 15:10 +0100 |
| Message-ID | <tkVjc-1eJ-29@gated-at.bofh.it> |
| In reply to | #1600429 |
On Tue, Mar 14, 2017 at 01:45:24PM +0000, Sudeep Holla wrote: > > > On 14/03/17 13:11, Stefan Kristiansson wrote: > > On Tue, Mar 14, 2017 at 12:08:33PM +0000, Sudeep Holla wrote: > >> On Tue, Feb 21, 2017 at 7:11 PM, Stafford Horne <shorne@gmail.com> wrote: > >>> From: Stefan Kristiansson <stefan.kristiansson@saunalahti.fi> > >>> > >>> Motivation for this is to be able to print the way information > >>> properly in print_cpuinfo(), instead of hardcoding it to one. > >>> > >> > >> Any particular reason not to use generic cacheinfo sysfs infrastructure ? > >> > > > > No reason as far as I can see, the creation of this patch predates the > > generic cacheinfo sysfs infrastructure. > > > > The patch itself doesn't add cache information to cpuinfo though, > > only corrects a bug in the information that is already there. > > > > We should look into exposing the info in the generic cache info sysfs > > and potentially removing the information from cpuinfo. > > > > Ah OK, sorry I mistook it as a new addition rather than bug fox. Hello, The comment is appreciated I didnt know about the generic cacheinfo intrstructure to be honest. The simplifications it brings look good, I will put this on my todo list. If you want to have a go at patching it in for openrisc it would be appreciated. :) -Stafford
[toc] | [prev] | [next] | [standalone]
| From | Sudeep Holla <sudeep.holla@arm.com> |
|---|---|
| Date | 2017-03-14 17:00 +0100 |
| Message-ID | <tkX1D-2dV-5@gated-at.bofh.it> |
| In reply to | #1600451 |
On 14/03/17 14:09, Stafford Horne wrote: > On Tue, Mar 14, 2017 at 01:45:24PM +0000, Sudeep Holla wrote: >> >> >> On 14/03/17 13:11, Stefan Kristiansson wrote: >>> On Tue, Mar 14, 2017 at 12:08:33PM +0000, Sudeep Holla wrote: >>>> On Tue, Feb 21, 2017 at 7:11 PM, Stafford Horne <shorne@gmail.com> wrote: >>>>> From: Stefan Kristiansson <stefan.kristiansson@saunalahti.fi> >>>>> >>>>> Motivation for this is to be able to print the way information >>>>> properly in print_cpuinfo(), instead of hardcoding it to one. >>>>> >>>> >>>> Any particular reason not to use generic cacheinfo sysfs infrastructure ? >>>> >>> >>> No reason as far as I can see, the creation of this patch predates the >>> generic cacheinfo sysfs infrastructure. >>> >>> The patch itself doesn't add cache information to cpuinfo though, >>> only corrects a bug in the information that is already there. >>> >>> We should look into exposing the info in the generic cache info sysfs >>> and potentially removing the information from cpuinfo. >>> >> >> Ah OK, sorry I mistook it as a new addition rather than bug fox. > > Hello, > > The comment is appreciated I didnt know about the generic cacheinfo > intrstructure to be honest. The simplifications it brings look good, I > will put this on my todo list. > Thanks. > If you want to have a go at patching it in for openrisc it would be > appreciated. :) > Sure I can try if I get time before someone else does that ;) -- Regards, Sudeep
[toc] | [prev] | [next] | [standalone]
| From | Stefan Kristiansson <stefan.kristiansson@saunalahti.fi> |
|---|---|
| Date | 2017-03-14 16:40 +0100 |
| Message-ID | <tkV9w-Uf-9@gated-at.bofh.it> |
| In reply to | #1600273 |
On Tue, Mar 14, 2017 at 12:08:33PM +0000, Sudeep Holla wrote: > On Tue, Feb 21, 2017 at 7:11 PM, Stafford Horne <shorne@gmail.com> wrote: > > From: Stefan Kristiansson <stefan.kristiansson@saunalahti.fi> > > > > Motivation for this is to be able to print the way information > > properly in print_cpuinfo(), instead of hardcoding it to one. > > > > Any particular reason not to use generic cacheinfo sysfs infrastructure ? > No reason as far as I can see, the creation of this patch predates the generic cacheinfo sysfs infrastructure. The patch itself doesn't add cache information to cpuinfo though, only corrects a bug in the information that is already there. We should look into exposing the info in the generic cache info sysfs and potentially removing the information from cpuinfo. Stefan
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web