Re: [PATCH v3 02/25] openrisc: add cache way information to cpuinfo

From	Stafford Horne <shorne@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 02/25] openrisc: add cache way information to cpuinfo
Date	2017-03-14 15:10 +0100
Message-ID	<tkVjc-1eJ-29@gated-at.bofh.it> (permalink)
References	<tdo8F-6Sm-3@gated-at.bofh.it> <tdo8I-6Sm-83@gated-at.bofh.it> <tkTr4-8mX-19@gated-at.bofh.it> <tkV9w-Uf-9@gated-at.bofh.it> <tkV9w-Uf-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Mar 14, 2017 at 01:45:24PM +0000, Sudeep Holla wrote:
> 
> 
> On 14/03/17 13:11, Stefan Kristiansson wrote:
> > On Tue, Mar 14, 2017 at 12:08:33PM +0000, Sudeep Holla wrote:
> >> On Tue, Feb 21, 2017 at 7:11 PM, Stafford Horne <shorne@gmail.com> wrote:
> >>> From: Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>
> >>>
> >>> Motivation for this is to be able to print the way information
> >>> properly in print_cpuinfo(), instead of hardcoding it to one.
> >>>
> >>
> >> Any particular reason not to use generic cacheinfo sysfs infrastructure ?
> >>
> > 
> > No reason as far as I can see, the creation of this patch predates the
> > generic cacheinfo sysfs infrastructure.
> > 
> > The patch itself doesn't add cache information to cpuinfo though,
> > only corrects a bug in the information that is already there.
> > 
> > We should look into exposing the info in the generic cache info sysfs
> > and potentially removing the information from cpuinfo.
> > 
> 
> Ah OK, sorry I mistook it as a new addition rather than bug fox.

Hello,

The comment is appreciated I didnt know about the generic cacheinfo
intrstructure to be honest.  The simplifications it brings look good, I
will put this on my todo list.

If you want to have a go at patching it in for openrisc it would be
appreciated. :)

-Stafford

Thread

Re: [PATCH v3 02/25] openrisc: add cache way information to cpuinfo Sudeep Holla <sudeep.holla@arm.com> - 2017-03-14 13:10 +0100
  Re: [PATCH v3 02/25] openrisc: add cache way information to cpuinfo Sudeep Holla <sudeep.holla@arm.com> - 2017-03-14 15:00 +0100
    Re: [PATCH v3 02/25] openrisc: add cache way information to cpuinfo Stafford Horne <shorne@gmail.com> - 2017-03-14 15:10 +0100
      Re: [PATCH v3 02/25] openrisc: add cache way information to cpuinfo Sudeep Holla <sudeep.holla@arm.com> - 2017-03-14 17:00 +0100
  Re: [PATCH v3 02/25] openrisc: add cache way information to cpuinfo Stefan Kristiansson <stefan.kristiansson@saunalahti.fi> - 2017-03-14 16:40 +0100

csiph-web