Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1595683 > unrolled thread
| Started by | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| First post | 2017-03-09 07:00 +0100 |
| Last post | 2017-03-14 10:30 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH v2] platform/x86: dell-laptop: Handle return error form dell_get_intensity. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-03-09 07:00 +0100
Re: [PATCH v2] platform/x86: dell-laptop: Handle return error form dell_get_intensity. Pali Rohár <pali.rohar@gmail.com> - 2017-03-14 10:30 +0100
| From | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| Date | 2017-03-09 07:00 +0100 |
| Subject | [PATCH v2] platform/x86: dell-laptop: Handle return error form dell_get_intensity. |
| Message-ID | <tiZhg-F6-3@gated-at.bofh.it> |
Here, This patch is to handle a return error from dell_get_intensity.
This change is done using Coccinelle.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/platform/x86/dell-laptop.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c
index f57dd28..7fcf680 100644
--- a/drivers/platform/x86/dell-laptop.c
+++ b/drivers/platform/x86/dell-laptop.c
@@ -2053,11 +2053,17 @@ static int __init dell_init(void)
dell_backlight_device->props.brightness =
dell_get_intensity(dell_backlight_device);
+ if (dell_backlight_device->props.brightness < 0) {
+ ret = dell_backlight_device->props.brightness;
+ goto fail_get_brightness;
+ }
backlight_update_status(dell_backlight_device);
}
return 0;
+fail_get_brightness:
+ backlight_device_unregister(dell_backlight_device);
fail_backlight:
dell_cleanup_rfkill();
fail_rfkill:
--
1.9.1
[toc] | [next] | [standalone]
| From | Pali Rohár <pali.rohar@gmail.com> |
|---|---|
| Date | 2017-03-14 10:30 +0100 |
| Subject | Re: [PATCH v2] platform/x86: dell-laptop: Handle return error form dell_get_intensity. |
| Message-ID | <tkQWe-6sZ-9@gated-at.bofh.it> |
| In reply to | #1595683 |
On Thursday 09 March 2017 11:19:56 Arvind Yadav wrote:
> Here, This patch is to handle a return error from dell_get_intensity.
> This change is done using Coccinelle.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Ok, seems good. You can add my Acked-By.
> ---
> drivers/platform/x86/dell-laptop.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c
> index f57dd28..7fcf680 100644
> --- a/drivers/platform/x86/dell-laptop.c
> +++ b/drivers/platform/x86/dell-laptop.c
> @@ -2053,11 +2053,17 @@ static int __init dell_init(void)
>
> dell_backlight_device->props.brightness =
> dell_get_intensity(dell_backlight_device);
> + if (dell_backlight_device->props.brightness < 0) {
> + ret = dell_backlight_device->props.brightness;
> + goto fail_get_brightness;
> + }
> backlight_update_status(dell_backlight_device);
> }
>
> return 0;
>
> +fail_get_brightness:
> + backlight_device_unregister(dell_backlight_device);
> fail_backlight:
> dell_cleanup_rfkill();
> fail_rfkill:
--
Pali Rohár
pali.rohar@gmail.com
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web