Re: [PATCH v2] platform/x86: dell-laptop: Handle return error form dell_get_intensity.

From	Pali Rohár <pali.rohar@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] platform/x86: dell-laptop: Handle return error form dell_get_intensity.
Date	2017-03-14 10:30 +0100
Message-ID	<tkQWe-6sZ-9@gated-at.bofh.it> (permalink)
References	<tiZhg-F6-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thursday 09 March 2017 11:19:56 Arvind Yadav wrote:
> Here, This patch is to handle a return error from dell_get_intensity.
> This change is done using Coccinelle.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>

Ok, seems good. You can add my Acked-By.

> ---
>  drivers/platform/x86/dell-laptop.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c
> index f57dd28..7fcf680 100644
> --- a/drivers/platform/x86/dell-laptop.c
> +++ b/drivers/platform/x86/dell-laptop.c
> @@ -2053,11 +2053,17 @@ static int __init dell_init(void)
>  
>  		dell_backlight_device->props.brightness =
>  			dell_get_intensity(dell_backlight_device);
> +		if (dell_backlight_device->props.brightness < 0) {
> +			ret = dell_backlight_device->props.brightness;
> +			goto fail_get_brightness;
> +		}
>  		backlight_update_status(dell_backlight_device);
>  	}
>  
>  	return 0;
>  
> +fail_get_brightness:
> +	backlight_device_unregister(dell_backlight_device);
>  fail_backlight:
>  	dell_cleanup_rfkill();
>  fail_rfkill:

-- 
Pali Rohár
pali.rohar@gmail.com

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] platform/x86: dell-laptop: Handle return error form dell_get_intensity. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-03-09 07:00 +0100
  Re: [PATCH v2] platform/x86: dell-laptop: Handle return error form  dell_get_intensity. Pali Rohár <pali.rohar@gmail.com> - 2017-03-14 10:30 +0100

csiph-web