Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1598341 > unrolled thread

[PATCH v1 00/10] staging: iio: Remove exceptional & on functions name

Back to article view | Back to linux.kernel

Contents

  [PATCH v1 00/10] staging: iio: Remove exceptional & on functions name simran singhal <singhalsimran0@gmail.com> - 2017-03-11 15:30 +0100
    [PATCH v1 01/10] staging: iio: ad7192: Remove exceptional & on function name simran singhal <singhalsimran0@gmail.com> - 2017-03-11 15:30 +0100
      Re: [PATCH v1 01/10] staging: iio: ad7192: Remove exceptional & on  function name Jonathan Cameron <jic23@kernel.org> - 2017-03-11 19:40 +0100
    [PATCH v1 03/10] staging: iio: cdc: ad7746: Remove exceptional & on function name simran singhal <singhalsimran0@gmail.com> - 2017-03-11 15:30 +0100
      Re: [PATCH v1 03/10] staging: iio: cdc: ad7746: Remove exceptional &  on function name Jonathan Cameron <jic23@kernel.org> - 2017-03-11 19:40 +0100
    [PATCH v1 08/10] staging: iio: adis16203: Remove exceptional & on function name simran singhal <singhalsimran0@gmail.com> - 2017-03-11 15:30 +0100
      Re: [PATCH v1 08/10] staging: iio: adis16203: Remove exceptional & on  function name Jonathan Cameron <jic23@kernel.org> - 2017-03-11 19:50 +0100
    [PATCH v1 02/10] staging: iio: ad7780: Remove exceptional & on function name simran singhal <singhalsimran0@gmail.com> - 2017-03-11 15:30 +0100
      Re: [PATCH v1 02/10] staging: iio: ad7780: Remove exceptional & on  function name Jonathan Cameron <jic23@kernel.org> - 2017-03-11 19:40 +0100
    [PATCH v1 04/10] staging: iio: cdc: ad7152: Remove exceptional & on function name simran singhal <singhalsimran0@gmail.com> - 2017-03-11 15:30 +0100
      Re: [PATCH v1 04/10] staging: iio: cdc: ad7152: Remove exceptional &  on function name Jonathan Cameron <jic23@kernel.org> - 2017-03-11 19:50 +0100
    Re: [PATCH v1 00/10] staging: iio: Remove exceptional & on functions  name Jonathan Cameron <jic23@kernel.org> - 2017-03-11 19:40 +0100

#1598341 — [PATCH v1 00/10] staging: iio: Remove exceptional & on functions name

This patch-series removes exceptional & on functions name.

v1:
  -Change the commit message of all the patches of the patch-series

simran singhal (10):
  staging: iio: ad7192: Remove exceptional & on function name
  staging: iio: ad7780: Remove exceptional & on function name
  staging: iio: cdc: ad7746: Remove exceptional & on function name
  staging: iio: cdc: ad7152: Remove exceptional & on function name
  staging: iio: adis16240: Remove exceptional & on function name
  staging: iio: adis16201: Remove exceptional & on function name
  staging: iio: adis16209: Remove exceptional & on function name
  staging: iio: adis16203: Remove exceptional & on function name
  staging: iio: resolver: Remove exceptional & on function name
  staging: iio: gyro: Remove exceptional & on function name

 drivers/staging/iio/accel/adis16201.c     |  4 ++--
 drivers/staging/iio/accel/adis16203.c     |  4 ++--
 drivers/staging/iio/accel/adis16209.c     |  4 ++--
 drivers/staging/iio/accel/adis16240.c     |  4 ++--
 drivers/staging/iio/adc/ad7192.c          | 12 ++++++------
 drivers/staging/iio/adc/ad7780.c          |  2 +-
 drivers/staging/iio/cdc/ad7152.c          |  6 +++---
 drivers/staging/iio/cdc/ad7746.c          |  4 ++--
 drivers/staging/iio/gyro/adis16060_core.c |  2 +-
 drivers/staging/iio/resolver/ad2s1200.c   |  2 +-
 drivers/staging/iio/resolver/ad2s90.c     |  2 +-
 11 files changed, 23 insertions(+), 23 deletions(-)

-- 
2.7.4

[toc] | [next] | [standalone]

#1598342 — [PATCH v1 01/10] staging: iio: ad7192: Remove exceptional & on function name

Remove & from function pointers to conform to the style found elsewhere
in the file.  Done using the following semantic patch

// <smpl>
@r@
identifier f;
@@

f(...) { ... }
@@
identifier r.f;
@@

- &f
+ f
// </smpl>

Signed-off-by: simran singhal <singhalsimran0@gmail.com>
---
 drivers/staging/iio/adc/ad7192.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
index 4fc8588..d11c6de 100644
--- a/drivers/staging/iio/adc/ad7192.c
+++ b/drivers/staging/iio/adc/ad7192.c
@@ -564,18 +564,18 @@ static int ad7192_write_raw_get_fmt(struct iio_dev *indio_dev,
 }
 
 static const struct iio_info ad7192_info = {
-	.read_raw = &ad7192_read_raw,
-	.write_raw = &ad7192_write_raw,
-	.write_raw_get_fmt = &ad7192_write_raw_get_fmt,
+	.read_raw = ad7192_read_raw,
+	.write_raw = ad7192_write_raw,
+	.write_raw_get_fmt = ad7192_write_raw_get_fmt,
 	.attrs = &ad7192_attribute_group,
 	.validate_trigger = ad_sd_validate_trigger,
 	.driver_module = THIS_MODULE,
 };
 
 static const struct iio_info ad7195_info = {
-	.read_raw = &ad7192_read_raw,
-	.write_raw = &ad7192_write_raw,
-	.write_raw_get_fmt = &ad7192_write_raw_get_fmt,
+	.read_raw = ad7192_read_raw,
+	.write_raw = ad7192_write_raw,
+	.write_raw_get_fmt = ad7192_write_raw_get_fmt,
 	.attrs = &ad7195_attribute_group,
 	.validate_trigger = ad_sd_validate_trigger,
 	.driver_module = THIS_MODULE,
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1598408 — Re: [PATCH v1 01/10] staging: iio: ad7192: Remove exceptional & on function name

On 11/03/17 14:26, simran singhal wrote:
> Remove & from function pointers to conform to the style found elsewhere
> in the file.  Done using the following semantic patch
> 
> // <smpl>
> @r@
> identifier f;
> @@
> 
> f(...) { ... }
> @@
> identifier r.f;
> @@
> 
> - &f
> + f
> // </smpl>
> 
> Signed-off-by: simran singhal <singhalsimran0@gmail.com>
Applied to the togreg branch of iio.git and pushed out as
testing for the autobuilders to play with it.

Thanks,

Jonathan
> ---
>  drivers/staging/iio/adc/ad7192.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
> index 4fc8588..d11c6de 100644
> --- a/drivers/staging/iio/adc/ad7192.c
> +++ b/drivers/staging/iio/adc/ad7192.c
> @@ -564,18 +564,18 @@ static int ad7192_write_raw_get_fmt(struct iio_dev *indio_dev,
>  }
>  
>  static const struct iio_info ad7192_info = {
> -	.read_raw = &ad7192_read_raw,
> -	.write_raw = &ad7192_write_raw,
> -	.write_raw_get_fmt = &ad7192_write_raw_get_fmt,
> +	.read_raw = ad7192_read_raw,
> +	.write_raw = ad7192_write_raw,
> +	.write_raw_get_fmt = ad7192_write_raw_get_fmt,
>  	.attrs = &ad7192_attribute_group,
>  	.validate_trigger = ad_sd_validate_trigger,
>  	.driver_module = THIS_MODULE,
>  };
>  
>  static const struct iio_info ad7195_info = {
> -	.read_raw = &ad7192_read_raw,
> -	.write_raw = &ad7192_write_raw,
> -	.write_raw_get_fmt = &ad7192_write_raw_get_fmt,
> +	.read_raw = ad7192_read_raw,
> +	.write_raw = ad7192_write_raw,
> +	.write_raw_get_fmt = ad7192_write_raw_get_fmt,
>  	.attrs = &ad7195_attribute_group,
>  	.validate_trigger = ad_sd_validate_trigger,
>  	.driver_module = THIS_MODULE,
> 

[toc] | [prev] | [next] | [standalone]

#1598343 — [PATCH v1 03/10] staging: iio: cdc: ad7746: Remove exceptional & on function name

Remove & from function pointers to conform to the style found elsewhere
in the file.  Done using the following semantic patch

// <smpl>
@r@
identifier f;
@@

f(...) { ... }
@@
identifier r.f;
@@

- &f
+ f
// </smpl>

Signed-off-by: simran singhal <singhalsimran0@gmail.com>
---
 drivers/staging/iio/cdc/ad7746.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/iio/cdc/ad7746.c b/drivers/staging/iio/cdc/ad7746.c
index 81f8b9e..6294de7 100644
--- a/drivers/staging/iio/cdc/ad7746.c
+++ b/drivers/staging/iio/cdc/ad7746.c
@@ -664,8 +664,8 @@ static int ad7746_read_raw(struct iio_dev *indio_dev,
 
 static const struct iio_info ad7746_info = {
 	.attrs = &ad7746_attribute_group,
-	.read_raw = &ad7746_read_raw,
-	.write_raw = &ad7746_write_raw,
+	.read_raw = ad7746_read_raw,
+	.write_raw = ad7746_write_raw,
 	.driver_module = THIS_MODULE,
 };
 
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1598404 — Re: [PATCH v1 03/10] staging: iio: cdc: ad7746: Remove exceptional & on function name

On 11/03/17 14:26, simran singhal wrote:
> Remove & from function pointers to conform to the style found elsewhere
> in the file.  Done using the following semantic patch
> 
> // <smpl>
> @r@
> identifier f;
> @@
> 
> f(...) { ... }
> @@
> identifier r.f;
> @@
> 
> - &f
> + f
> // </smpl>
> 
> Signed-off-by: simran singhal <singhalsimran0@gmail.com>
Applied.

It's a little unobvious that other function pointers in this
one don't have the & as they are only used via macros.

However, I'm in general in favour of the change so don't
really care that much!

Jonathan
> ---
>  drivers/staging/iio/cdc/ad7746.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/iio/cdc/ad7746.c b/drivers/staging/iio/cdc/ad7746.c
> index 81f8b9e..6294de7 100644
> --- a/drivers/staging/iio/cdc/ad7746.c
> +++ b/drivers/staging/iio/cdc/ad7746.c
> @@ -664,8 +664,8 @@ static int ad7746_read_raw(struct iio_dev *indio_dev,
>  
>  static const struct iio_info ad7746_info = {
>  	.attrs = &ad7746_attribute_group,
> -	.read_raw = &ad7746_read_raw,
> -	.write_raw = &ad7746_write_raw,
> +	.read_raw = ad7746_read_raw,
> +	.write_raw = ad7746_write_raw,
>  	.driver_module = THIS_MODULE,
>  };
>  
> 

[toc] | [prev] | [next] | [standalone]

#1598344 — [PATCH v1 08/10] staging: iio: adis16203: Remove exceptional & on function name

Remove & from function pointers to conform to the style found elsewhere
in the file.  Done using the following semantic patch

// <smpl>
@r@
identifier f;
@@

f(...) { ... }
@@
identifier r.f;
@@

- &f
+ f
// </smpl>

Signed-off-by: simran singhal <singhalsimran0@gmail.com>
---
 drivers/staging/iio/accel/adis16203.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/iio/accel/adis16203.c b/drivers/staging/iio/accel/adis16203.c
index 68189ad..b59755a 100644
--- a/drivers/staging/iio/accel/adis16203.c
+++ b/drivers/staging/iio/accel/adis16203.c
@@ -233,8 +233,8 @@ static const struct iio_chan_spec adis16203_channels[] = {
 };
 
 static const struct iio_info adis16203_info = {
-	.read_raw = &adis16203_read_raw,
-	.write_raw = &adis16203_write_raw,
+	.read_raw = adis16203_read_raw,
+	.write_raw = adis16203_write_raw,
 	.update_scan_mode = adis_update_scan_mode,
 	.driver_module = THIS_MODULE,
 };
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1598409 — Re: [PATCH v1 08/10] staging: iio: adis16203: Remove exceptional & on function name

On 11/03/17 14:26, simran singhal wrote:
> Remove & from function pointers to conform to the style found elsewhere
> in the file.  Done using the following semantic patch
> 
> // <smpl>
> @r@
> identifier f;
> @@
> 
> f(...) { ... }
> @@
> identifier r.f;
> @@
> 
> - &f
> + f
> // </smpl>
> 
> Signed-off-by: simran singhal <singhalsimran0@gmail.com>
Applied.
> ---
>  drivers/staging/iio/accel/adis16203.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/iio/accel/adis16203.c b/drivers/staging/iio/accel/adis16203.c
> index 68189ad..b59755a 100644
> --- a/drivers/staging/iio/accel/adis16203.c
> +++ b/drivers/staging/iio/accel/adis16203.c
> @@ -233,8 +233,8 @@ static const struct iio_chan_spec adis16203_channels[] = {
>  };
>  
>  static const struct iio_info adis16203_info = {
> -	.read_raw = &adis16203_read_raw,
> -	.write_raw = &adis16203_write_raw,
> +	.read_raw = adis16203_read_raw,
> +	.write_raw = adis16203_write_raw,
>  	.update_scan_mode = adis_update_scan_mode,
>  	.driver_module = THIS_MODULE,
>  };
> 

[toc] | [prev] | [next] | [standalone]

#1598345 — [PATCH v1 02/10] staging: iio: ad7780: Remove exceptional & on function name

Remove & from function pointers to conform to the style found elsewhere
in the file.  Done using the following semantic patch

// <smpl>
@r@
identifier f;
@@

f(...) { ... }
@@
identifier r.f;
@@

- &f
+ f
// </smpl>

Signed-off-by: simran singhal <singhalsimran0@gmail.com>
---
 drivers/staging/iio/adc/ad7780.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/iio/adc/ad7780.c b/drivers/staging/iio/adc/ad7780.c
index e149600..dec3ba6 100644
--- a/drivers/staging/iio/adc/ad7780.c
+++ b/drivers/staging/iio/adc/ad7780.c
@@ -154,7 +154,7 @@ static const struct ad7780_chip_info ad7780_chip_info_tbl[] = {
 };
 
 static const struct iio_info ad7780_info = {
-	.read_raw = &ad7780_read_raw,
+	.read_raw = ad7780_read_raw,
 	.driver_module = THIS_MODULE,
 };
 
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1598405 — Re: [PATCH v1 02/10] staging: iio: ad7780: Remove exceptional & on function name

On 11/03/17 14:26, simran singhal wrote:
> Remove & from function pointers to conform to the style found elsewhere
> in the file.  Done using the following semantic patch
> 
> // <smpl>
> @r@
> identifier f;
> @@
> 
> f(...) { ... }
> @@
> identifier r.f;
> @@
> 
> - &f
> + f
> // </smpl>
> 
> Signed-off-by: simran singhal <singhalsimran0@gmail.com>
Applied.

Thanks,
> ---
>  drivers/staging/iio/adc/ad7780.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/iio/adc/ad7780.c b/drivers/staging/iio/adc/ad7780.c
> index e149600..dec3ba6 100644
> --- a/drivers/staging/iio/adc/ad7780.c
> +++ b/drivers/staging/iio/adc/ad7780.c
> @@ -154,7 +154,7 @@ static const struct ad7780_chip_info ad7780_chip_info_tbl[] = {
>  };
>  
>  static const struct iio_info ad7780_info = {
> -	.read_raw = &ad7780_read_raw,
> +	.read_raw = ad7780_read_raw,
>  	.driver_module = THIS_MODULE,
>  };
>  
> 

[toc] | [prev] | [next] | [standalone]

#1598346 — [PATCH v1 04/10] staging: iio: cdc: ad7152: Remove exceptional & on function name

Remove & from function pointers to conform to the style found elsewhere
in the file.  Done using the following semantic patch

// <smpl>
@r@
identifier f;
@@

f(...) { ... }
@@
identifier r.f;
@@

- &f
+ f
// </smpl>

Signed-off-by: simran singhal <singhalsimran0@gmail.com>
---
 drivers/staging/iio/cdc/ad7152.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/iio/cdc/ad7152.c b/drivers/staging/iio/cdc/ad7152.c
index e8609b8..59ef93c 100644
--- a/drivers/staging/iio/cdc/ad7152.c
+++ b/drivers/staging/iio/cdc/ad7152.c
@@ -441,9 +441,9 @@ static int ad7152_write_raw_get_fmt(struct iio_dev *indio_dev,
 
 static const struct iio_info ad7152_info = {
 	.attrs = &ad7152_attribute_group,
-	.read_raw = &ad7152_read_raw,
-	.write_raw = &ad7152_write_raw,
-	.write_raw_get_fmt = &ad7152_write_raw_get_fmt,
+	.read_raw = ad7152_read_raw,
+	.write_raw = ad7152_write_raw,
+	.write_raw_get_fmt = ad7152_write_raw_get_fmt,
 	.driver_module = THIS_MODULE,
 };
 
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1598416 — Re: [PATCH v1 04/10] staging: iio: cdc: ad7152: Remove exceptional & on function name

On 11/03/17 14:26, simran singhal wrote:
> Remove & from function pointers to conform to the style found elsewhere
> in the file.  Done using the following semantic patch
> 
> // <smpl>
> @r@
> identifier f;
> @@
> 
> f(...) { ... }
> @@
> identifier r.f;
> @@
> 
> - &f
> + f
> // </smpl>
> 
> Signed-off-by: simran singhal <singhalsimran0@gmail.com>
Applied.
> ---
>  drivers/staging/iio/cdc/ad7152.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/iio/cdc/ad7152.c b/drivers/staging/iio/cdc/ad7152.c
> index e8609b8..59ef93c 100644
> --- a/drivers/staging/iio/cdc/ad7152.c
> +++ b/drivers/staging/iio/cdc/ad7152.c
> @@ -441,9 +441,9 @@ static int ad7152_write_raw_get_fmt(struct iio_dev *indio_dev,
>  
>  static const struct iio_info ad7152_info = {
>  	.attrs = &ad7152_attribute_group,
> -	.read_raw = &ad7152_read_raw,
> -	.write_raw = &ad7152_write_raw,
> -	.write_raw_get_fmt = &ad7152_write_raw_get_fmt,
> +	.read_raw = ad7152_read_raw,
> +	.write_raw = ad7152_write_raw,
> +	.write_raw_get_fmt = ad7152_write_raw_get_fmt,
>  	.driver_module = THIS_MODULE,
>  };
>  
> 

[toc] | [prev] | [next] | [standalone]

#1598406 — Re: [PATCH v1 00/10] staging: iio: Remove exceptional & on functions name

On 11/03/17 14:26, simran singhal wrote:
> This patch-series removes exceptional & on functions name.
> 
> v1:
>   -Change the commit message of all the patches of the patch-series
Usual convention is to call the first (unlabelled) revision v1
implicitly which would have made this V2.  Doesn't really matter
though!

Jonathan
> 
> simran singhal (10):
>   staging: iio: ad7192: Remove exceptional & on function name
>   staging: iio: ad7780: Remove exceptional & on function name
>   staging: iio: cdc: ad7746: Remove exceptional & on function name
>   staging: iio: cdc: ad7152: Remove exceptional & on function name
>   staging: iio: adis16240: Remove exceptional & on function name
>   staging: iio: adis16201: Remove exceptional & on function name
>   staging: iio: adis16209: Remove exceptional & on function name
>   staging: iio: adis16203: Remove exceptional & on function name
>   staging: iio: resolver: Remove exceptional & on function name
>   staging: iio: gyro: Remove exceptional & on function name
> 
>  drivers/staging/iio/accel/adis16201.c     |  4 ++--
>  drivers/staging/iio/accel/adis16203.c     |  4 ++--
>  drivers/staging/iio/accel/adis16209.c     |  4 ++--
>  drivers/staging/iio/accel/adis16240.c     |  4 ++--
>  drivers/staging/iio/adc/ad7192.c          | 12 ++++++------
>  drivers/staging/iio/adc/ad7780.c          |  2 +-
>  drivers/staging/iio/cdc/ad7152.c          |  6 +++---
>  drivers/staging/iio/cdc/ad7746.c          |  4 ++--
>  drivers/staging/iio/gyro/adis16060_core.c |  2 +-
>  drivers/staging/iio/resolver/ad2s1200.c   |  2 +-
>  drivers/staging/iio/resolver/ad2s90.c     |  2 +-
>  11 files changed, 23 insertions(+), 23 deletions(-)
> 

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web