Re: [PATCH v1 01/10] staging: iio: ad7192: Remove exceptional & on function name

From	Jonathan Cameron <jic23@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v1 01/10] staging: iio: ad7192: Remove exceptional & on function name
Date	2017-03-11 19:40 +0100
Message-ID	<tjU5Q-6Jb-13@gated-at.bofh.it> (permalink)
References	<tjQbT-41k-3@gated-at.bofh.it> <tjQbU-41k-41@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 11/03/17 14:26, simran singhal wrote:
> Remove & from function pointers to conform to the style found elsewhere
> in the file.  Done using the following semantic patch
> 
> // <smpl>
> @r@
> identifier f;
> @@
> 
> f(...) { ... }
> @@
> identifier r.f;
> @@
> 
> - &f
> + f
> // </smpl>
> 
> Signed-off-by: simran singhal <singhalsimran0@gmail.com>
Applied to the togreg branch of iio.git and pushed out as
testing for the autobuilders to play with it.

Thanks,

Jonathan
> ---
>  drivers/staging/iio/adc/ad7192.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
> index 4fc8588..d11c6de 100644
> --- a/drivers/staging/iio/adc/ad7192.c
> +++ b/drivers/staging/iio/adc/ad7192.c
> @@ -564,18 +564,18 @@ static int ad7192_write_raw_get_fmt(struct iio_dev *indio_dev,
>  }
>  
>  static const struct iio_info ad7192_info = {
> -	.read_raw = &ad7192_read_raw,
> -	.write_raw = &ad7192_write_raw,
> -	.write_raw_get_fmt = &ad7192_write_raw_get_fmt,
> +	.read_raw = ad7192_read_raw,
> +	.write_raw = ad7192_write_raw,
> +	.write_raw_get_fmt = ad7192_write_raw_get_fmt,
>  	.attrs = &ad7192_attribute_group,
>  	.validate_trigger = ad_sd_validate_trigger,
>  	.driver_module = THIS_MODULE,
>  };
>  
>  static const struct iio_info ad7195_info = {
> -	.read_raw = &ad7192_read_raw,
> -	.write_raw = &ad7192_write_raw,
> -	.write_raw_get_fmt = &ad7192_write_raw_get_fmt,
> +	.read_raw = ad7192_read_raw,
> +	.write_raw = ad7192_write_raw,
> +	.write_raw_get_fmt = ad7192_write_raw_get_fmt,
>  	.attrs = &ad7195_attribute_group,
>  	.validate_trigger = ad_sd_validate_trigger,
>  	.driver_module = THIS_MODULE,
>

Thread

[PATCH v1 00/10] staging: iio: Remove exceptional & on functions name simran singhal <singhalsimran0@gmail.com> - 2017-03-11 15:30 +0100
  [PATCH v1 01/10] staging: iio: ad7192: Remove exceptional & on function name simran singhal <singhalsimran0@gmail.com> - 2017-03-11 15:30 +0100
    Re: [PATCH v1 01/10] staging: iio: ad7192: Remove exceptional & on  function name Jonathan Cameron <jic23@kernel.org> - 2017-03-11 19:40 +0100
  [PATCH v1 03/10] staging: iio: cdc: ad7746: Remove exceptional & on function name simran singhal <singhalsimran0@gmail.com> - 2017-03-11 15:30 +0100
    Re: [PATCH v1 03/10] staging: iio: cdc: ad7746: Remove exceptional &  on function name Jonathan Cameron <jic23@kernel.org> - 2017-03-11 19:40 +0100
  [PATCH v1 08/10] staging: iio: adis16203: Remove exceptional & on function name simran singhal <singhalsimran0@gmail.com> - 2017-03-11 15:30 +0100
    Re: [PATCH v1 08/10] staging: iio: adis16203: Remove exceptional & on  function name Jonathan Cameron <jic23@kernel.org> - 2017-03-11 19:50 +0100
  [PATCH v1 02/10] staging: iio: ad7780: Remove exceptional & on function name simran singhal <singhalsimran0@gmail.com> - 2017-03-11 15:30 +0100
    Re: [PATCH v1 02/10] staging: iio: ad7780: Remove exceptional & on  function name Jonathan Cameron <jic23@kernel.org> - 2017-03-11 19:40 +0100
  [PATCH v1 04/10] staging: iio: cdc: ad7152: Remove exceptional & on function name simran singhal <singhalsimran0@gmail.com> - 2017-03-11 15:30 +0100
    Re: [PATCH v1 04/10] staging: iio: cdc: ad7152: Remove exceptional &  on function name Jonathan Cameron <jic23@kernel.org> - 2017-03-11 19:50 +0100
  Re: [PATCH v1 00/10] staging: iio: Remove exceptional & on functions  name Jonathan Cameron <jic23@kernel.org> - 2017-03-11 19:40 +0100

csiph-web