Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1594165 > unrolled thread
| Started by | Masahiro Yamada <yamada.masahiro@socionext.com> |
|---|---|
| First post | 2017-03-07 13:20 +0100 |
| Last post | 2017-03-08 02:40 +0100 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v2 3/3] mtd: nand: Remove unused chip->write_page() hook Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-03-07 13:20 +0100
Re: [PATCH v2 3/3] mtd: nand: Remove unused chip->write_page() hook Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-03-07 19:40 +0100
Re: [PATCH v2 3/3] mtd: nand: Remove unused chip->write_page() hook Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-03-08 02:40 +0100
| From | Masahiro Yamada <yamada.masahiro@socionext.com> |
|---|---|
| Date | 2017-03-07 13:20 +0100 |
| Subject | Re: [PATCH v2 3/3] mtd: nand: Remove unused chip->write_page() hook |
| Message-ID | <timfU-7nz-9@gated-at.bofh.it> |
Hi Boris, 2017-02-20 21:28 GMT+09:00 Boris Brezillon <boris.brezillon@free-electrons.com>: > The last/only user of the chip->write_page() hook (the Atmel NAND > controller driver) has been reworked and is no longer specifying a custom > ->write_page() implementation. > Drop this hook before someone else start abusing it. > > Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com> Just a minor comment. /** * nand_write_page - [REPLACEABLE] write one page * @mtd: MTD device structure Can you update the comment block for nand_write_page(), too? [REPLACEABLE] -> [INTERNAL] -- Best Regards Masahiro Yamada
[toc] | [next] | [standalone]
| From | Boris Brezillon <boris.brezillon@free-electrons.com> |
|---|---|
| Date | 2017-03-07 19:40 +0100 |
| Message-ID | <tisbE-31Z-29@gated-at.bofh.it> |
| In reply to | #1594165 |
On Tue, 7 Mar 2017 21:04:50 +0900 Masahiro Yamada <yamada.masahiro@socionext.com> wrote: > Hi Boris, > > 2017-02-20 21:28 GMT+09:00 Boris Brezillon <boris.brezillon@free-electrons.com>: > > The last/only user of the chip->write_page() hook (the Atmel NAND > > controller driver) has been reworked and is no longer specifying a custom > > ->write_page() implementation. > > Drop this hook before someone else start abusing it. > > > > Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com> > > > Just a minor comment. > > > /** > * nand_write_page - [REPLACEABLE] write one page > * @mtd: MTD device structure > > > Can you update the comment block for nand_write_page(), too? > > [REPLACEABLE] -> [INTERNAL] I think I'll just drop it, it does not mean anything to flag a static function as replaceable (the ->write_page() method could be overloaded, but not the nand_write_page() implementation itself).
[toc] | [prev] | [next] | [standalone]
| From | Masahiro Yamada <yamada.masahiro@socionext.com> |
|---|---|
| Date | 2017-03-08 02:40 +0100 |
| Message-ID | <tiyK6-7HW-9@gated-at.bofh.it> |
| In reply to | #1594511 |
2017-03-08 3:34 GMT+09:00 Boris Brezillon <boris.brezillon@free-electrons.com>: > On Tue, 7 Mar 2017 21:04:50 +0900 > Masahiro Yamada <yamada.masahiro@socionext.com> wrote: > >> Hi Boris, >> >> 2017-02-20 21:28 GMT+09:00 Boris Brezillon <boris.brezillon@free-electrons.com>: >> > The last/only user of the chip->write_page() hook (the Atmel NAND >> > controller driver) has been reworked and is no longer specifying a custom >> > ->write_page() implementation. >> > Drop this hook before someone else start abusing it. >> > >> > Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com> >> >> >> Just a minor comment. >> >> >> /** >> * nand_write_page - [REPLACEABLE] write one page >> * @mtd: MTD device structure >> >> >> Can you update the comment block for nand_write_page(), too? >> >> [REPLACEABLE] -> [INTERNAL] > > I think I'll just drop it, it does not mean anything to flag a static > function as replaceable (the ->write_page() method could be overloaded, > but not the nand_write_page() implementation itself). > Sounds good to me. Thank you! -- Best Regards Masahiro Yamada
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web