Re: [PATCH v2 3/3] mtd: nand: Remove unused chip->write_page() hook

From	Boris Brezillon <boris.brezillon@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 3/3] mtd: nand: Remove unused chip->write_page() hook
Date	2017-03-07 19:40 +0100
Message-ID	<tisbE-31Z-29@gated-at.bofh.it> (permalink)
References	<tcVgm-4Bz-11@gated-at.bofh.it> <tcVgm-4Bz-21@gated-at.bofh.it> <timfU-7nz-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, 7 Mar 2017 21:04:50 +0900
Masahiro Yamada <yamada.masahiro@socionext.com> wrote:

> Hi Boris,
> 
> 2017-02-20 21:28 GMT+09:00 Boris Brezillon <boris.brezillon@free-electrons.com>:
> > The last/only user of the chip->write_page() hook (the Atmel NAND
> > controller driver) has been reworked and is no longer specifying a custom  
> > ->write_page() implementation.  
> > Drop this hook before someone else start abusing it.
> >
> > Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>  
> 
> 
> Just a minor comment.
> 
> 
> /**
>  * nand_write_page - [REPLACEABLE] write one page
>  * @mtd: MTD device structure
> 
> 
> Can you update the comment block for nand_write_page(), too?
> 
>   [REPLACEABLE]  ->  [INTERNAL]

I think I'll just drop it, it does not mean anything to flag a static
function as replaceable (the ->write_page() method could be overloaded,
but not the nand_write_page() implementation itself).

Thread

Re: [PATCH v2 3/3] mtd: nand: Remove unused chip->write_page() hook Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-03-07 13:20 +0100
  Re: [PATCH v2 3/3] mtd: nand: Remove unused chip->write_page() hook Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-03-07 19:40 +0100
    Re: [PATCH v2 3/3] mtd: nand: Remove unused chip->write_page() hook Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-03-08 02:40 +0100

csiph-web