Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1594565 > unrolled thread

Re: [PATCH] eeepc-laptop: Skip unknown key messages 0x50 0x51

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] eeepc-laptop: Skip unknown key messages 0x50 0x51 Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-03-07 20:30 +0100
    Re: [PATCH] eeepc-laptop: Skip unknown key messages 0x50 0x51 Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-03-13 17:10 +0100

#1594565 — Re: [PATCH] eeepc-laptop: Skip unknown key messages 0x50 0x51

On Fri, Feb 24, 2017 at 02:01:30PM +0100, Pau Espin Pedrol wrote:
> >> Dmitry, do we have special events for AC (un)plug? What is the best
> >> approach in your opinion?
> >
> > Not route them through input as they not input events would be the best.
> >
> Is my patch good enough for this or would you recommend doing it another way?

From input POV your patch makes sense.

> 
> > I'd look into hooking up power_supply class.
> >
> Whys is this necessay? All the related information required is already
> present in my system.
> I already have two power_supply instances:
> * /sys/class/power_supply/AC0/ (provided by module "ac"), contains
> property "online" which is correctly updated to 1 when AC is plugged
> and 0 when AC is unplugged.
> * /sys/class/power_supply/BAT0/ (provided by module "battery"),
> contains property "status" which is correctly updated to "Charging"
> when AC is plugged and "Discharging" when AC is unplugged.

If everything is already working then it is not necessary. I was
trying to say that if it does not quite work, then you shoudl look into
integrating it better with power supply subsystem, instead of trying to
shoehorn it into input.

Thanks.

-- 
Dmitry

[toc] | [next] | [standalone]

#1599555

On Tue, Mar 7, 2017 at 9:27 PM, Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
> On Fri, Feb 24, 2017 at 02:01:30PM +0100, Pau Espin Pedrol wrote:
>> >> Dmitry, do we have special events for AC (un)plug? What is the best
>> >> approach in your opinion?
>> >
>> > Not route them through input as they not input events would be the best.
>> >
>> Is my patch good enough for this or would you recommend doing it another way?
>

> From input POV your patch makes sense.

Could you give your tag?

>
>>
>> > I'd look into hooking up power_supply class.
>> >
>> Whys is this necessay? All the related information required is already
>> present in my system.
>> I already have two power_supply instances:
>> * /sys/class/power_supply/AC0/ (provided by module "ac"), contains
>> property "online" which is correctly updated to 1 when AC is plugged
>> and 0 when AC is unplugged.
>> * /sys/class/power_supply/BAT0/ (provided by module "battery"),
>> contains property "status" which is correctly updated to "Charging"
>> when AC is plugged and "Discharging" when AC is unplugged.
>
> If everything is already working then it is not necessary. I was
> trying to say that if it does not quite work, then you shoudl look into
> integrating it better with power supply subsystem, instead of trying to
> shoehorn it into input.

-- 
With Best Regards,
Andy Shevchenko

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web