Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1594457 > unrolled thread
| Started by | Fabio Estevam <festevam@gmail.com> |
|---|---|
| First post | 2017-03-07 18:40 +0100 |
| Last post | 2017-03-07 21:20 +0100 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH 1/2] pinctrl: imx: use generic pinctrl helpers for managing groups Fabio Estevam <festevam@gmail.com> - 2017-03-07 18:40 +0100
Re: [PATCH 1/2] pinctrl: imx: use generic pinctrl helpers for managing groups Tony Lindgren <tony@atomide.com> - 2017-03-07 19:20 +0100
Re: [PATCH 1/2] pinctrl: imx: use generic pinctrl helpers for managing groups Fabio Estevam <festevam@gmail.com> - 2017-03-07 20:40 +0100
Re: [PATCH 1/2] pinctrl: imx: use generic pinctrl helpers for managing groups Gary Bisson <gary.bisson@boundarydevices.com> - 2017-03-07 21:20 +0100
| From | Fabio Estevam <festevam@gmail.com> |
|---|---|
| Date | 2017-03-07 18:40 +0100 |
| Subject | Re: [PATCH 1/2] pinctrl: imx: use generic pinctrl helpers for managing groups |
| Message-ID | <tirfA-2oi-17@gated-at.bofh.it> |
Hi Gary, On Mon, Jan 2, 2017 at 4:20 PM, Gary Bisson <gary.bisson@boundarydevices.com> wrote: > Now using group_desc structure instead of imx_pin_group. > > Also leveraging generic functions to retrieve groups count/name/pins. > > The imx_free_pingroups function can be removed since it is now handled by > the core driver during unregister. > > Finally the device tree parsing is moved after the pinctrl driver registration > since this latter initializes the radix trees. > > Signed-off-by: Gary Bisson <gary.bisson@boundarydevices.com> This patch is in 4.11-rc1 now and it causes a regression on the hog group: [ 0.061005] imx6q-pinctrl 20e0000.iomuxc: unable to find group for node hoggrp The hog pins can no longer be initialized. Could you take a look, please?
[toc] | [next] | [standalone]
| From | Tony Lindgren <tony@atomide.com> |
|---|---|
| Date | 2017-03-07 19:20 +0100 |
| Message-ID | <tirSi-2Tr-17@gated-at.bofh.it> |
| In reply to | #1594457 |
* Fabio Estevam <festevam@gmail.com> [170307 09:39]: > Hi Gary, > > On Tue, Mar 7, 2017 at 2:26 PM, Gary Bisson > <gary.bisson@boundarydevices.com> wrote: > > > No it isn't because of the use of radix but instead of: > > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=950b0d91dc10 > > > > It has been discussed here: > > https://lkml.org/lkml/2017/2/28/140 > > Thanks for the clarification. > > > Tony offered a patch in that thread which works. Tony, have you > > submitted it yet? > > Looking forward to this one :-) Still waiting to hear back from Linus on what he prefers. Regards, Tony
[toc] | [prev] | [next] | [standalone]
| From | Fabio Estevam <festevam@gmail.com> |
|---|---|
| Date | 2017-03-07 20:40 +0100 |
| Message-ID | <tirSi-2Tr-21@gated-at.bofh.it> |
| In reply to | #1594457 |
Hi Gary, On Tue, Mar 7, 2017 at 2:26 PM, Gary Bisson <gary.bisson@boundarydevices.com> wrote: > No it isn't because of the use of radix but instead of: > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=950b0d91dc10 > > It has been discussed here: > https://lkml.org/lkml/2017/2/28/140 Thanks for the clarification. > Tony offered a patch in that thread which works. Tony, have you > submitted it yet? Looking forward to this one :-) Thanks
[toc] | [prev] | [next] | [standalone]
| From | Gary Bisson <gary.bisson@boundarydevices.com> |
|---|---|
| Date | 2017-03-07 21:20 +0100 |
| Message-ID | <tirSi-2Tr-19@gated-at.bofh.it> |
| In reply to | #1594457 |
Hi Fabio, On Tue, Mar 7, 2017 at 6:19 PM, Fabio Estevam <festevam@gmail.com> wrote: > Hi Gary, > > On Mon, Jan 2, 2017 at 4:20 PM, Gary Bisson > <gary.bisson@boundarydevices.com> wrote: >> Now using group_desc structure instead of imx_pin_group. >> >> Also leveraging generic functions to retrieve groups count/name/pins. >> >> The imx_free_pingroups function can be removed since it is now handled by >> the core driver during unregister. >> >> Finally the device tree parsing is moved after the pinctrl driver registration >> since this latter initializes the radix trees. >> >> Signed-off-by: Gary Bisson <gary.bisson@boundarydevices.com> > > This patch is in 4.11-rc1 now and it causes a regression on the hog group: > > [ 0.061005] imx6q-pinctrl 20e0000.iomuxc: unable to find group for > node hoggrp > > The hog pins can no longer be initialized. > > Could you take a look, please? No it isn't because of the use of radix but instead of: http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=950b0d91dc10 It has been discussed here: https://lkml.org/lkml/2017/2/28/140 Tony offered a patch in that thread which works. Tony, have you submitted it yet? Regards, Gary
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web