Re: [PATCH 1/2] pinctrl: imx: use generic pinctrl helpers for managing groups

From	Fabio Estevam <festevam@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] pinctrl: imx: use generic pinctrl helpers for managing groups
Date	2017-03-07 18:40 +0100
Message-ID	<tirfA-2oi-17@gated-at.bofh.it> (permalink)
References	<sVfwR-2pw-9@gated-at.bofh.it> <sVfwR-2pw-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Gary,

On Mon, Jan 2, 2017 at 4:20 PM, Gary Bisson
<gary.bisson@boundarydevices.com> wrote:
> Now using group_desc structure instead of imx_pin_group.
>
> Also leveraging generic functions to retrieve groups count/name/pins.
>
> The imx_free_pingroups function can be removed since it is now handled by
> the core driver during unregister.
>
> Finally the device tree parsing is moved after the pinctrl driver registration
> since this latter initializes the radix trees.
>
> Signed-off-by: Gary Bisson <gary.bisson@boundarydevices.com>

This patch is in 4.11-rc1 now and it causes a regression on the hog group:

[    0.061005] imx6q-pinctrl 20e0000.iomuxc: unable to find group for
node hoggrp

The hog pins can no longer be initialized.

Could you take a look, please?

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/2] pinctrl: imx: use generic pinctrl helpers for  managing groups Fabio Estevam <festevam@gmail.com> - 2017-03-07 18:40 +0100
  Re: [PATCH 1/2] pinctrl: imx: use generic pinctrl helpers for  managing groups Tony Lindgren <tony@atomide.com> - 2017-03-07 19:20 +0100
  Re: [PATCH 1/2] pinctrl: imx: use generic pinctrl helpers for  managing groups Fabio Estevam <festevam@gmail.com> - 2017-03-07 20:40 +0100
  Re: [PATCH 1/2] pinctrl: imx: use generic pinctrl helpers for  managing groups Gary Bisson <gary.bisson@boundarydevices.com> - 2017-03-07 21:20 +0100

csiph-web