Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1590685 > unrolled thread
| Started by | Guenter Roeck <linux@roeck-us.net> |
|---|---|
| First post | 2017-03-02 00:20 +0100 |
| Last post | 2017-03-10 09:50 +0100 |
| Articles | 5 — 4 participants |
Back to article view | Back to linux.kernel
[PATCH] mmc: core: Fix access to HS400-ES devices Guenter Roeck <linux@roeck-us.net> - 2017-03-02 00:20 +0100
Re: [PATCH] mmc: core: Fix access to HS400-ES devices Doug Anderson <dianders@chromium.org> - 2017-03-02 00:40 +0100
Re: [PATCH] mmc: core: Fix access to HS400-ES devices Shawn Lin <shawn.lin@rock-chips.com> - 2017-03-02 02:20 +0100
Re: [PATCH] mmc: core: Fix access to HS400-ES devices Guenter Roeck <linux@roeck-us.net> - 2017-03-07 04:50 +0100
Re: mmc: core: Fix access to HS400-ES devices Heiko Stübner <heiko@sntech.de> - 2017-03-10 09:50 +0100
| From | Guenter Roeck <linux@roeck-us.net> |
|---|---|
| Date | 2017-03-02 00:20 +0100 |
| Subject | [PATCH] mmc: core: Fix access to HS400-ES devices |
| Message-ID | <tglHk-1Og-11@gated-at.bofh.it> |
HS400-ES devices fail to initialize with the following error messages.
mmc1: power class selection to bus width 8 ddr 0 failed
mmc1: error -110 whilst initialising MMC card
This was seen on Samsung Chromebook Plus. Code analysis points to
commit 3d4ef329757c ("mmc: core: fix multi-bit bus width without
high-speed mode"), which attempts to set the bus width for all but
HS200 devices unconditionally. However, for HS400-ES, the bus width
is already selected.
Cc: Anssi Hannula <anssi.hannula@bitwise.fi>
Cc: Douglas Anderson <dianders@chromium.org>
Cc: Brian Norris <briannorris@chromium.org>
Fixes: 3d4ef329757c ("mmc: core: fix multi-bit bus width ...")
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
drivers/mmc/core/mmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
index 7fd722868875..b502601df228 100644
--- a/drivers/mmc/core/mmc.c
+++ b/drivers/mmc/core/mmc.c
@@ -1730,7 +1730,7 @@ static int mmc_init_card(struct mmc_host *host, u32 ocr,
err = mmc_select_hs400(card);
if (err)
goto free_card;
- } else {
+ } else if (!mmc_card_hs400es(card)) {
/* Select the desired bus width optionally */
err = mmc_select_bus_width(card);
if (err > 0 && mmc_card_hs(card)) {
--
2.7.4
[toc] | [next] | [standalone]
| From | Doug Anderson <dianders@chromium.org> |
|---|---|
| Date | 2017-03-02 00:40 +0100 |
| Message-ID | <tgm0F-1V5-9@gated-at.bofh.it> |
| In reply to | #1590685 |
Hi,
On Wed, Mar 1, 2017 at 2:11 PM, Guenter Roeck <linux@roeck-us.net> wrote:
> HS400-ES devices fail to initialize with the following error messages.
>
> mmc1: power class selection to bus width 8 ddr 0 failed
> mmc1: error -110 whilst initialising MMC card
>
> This was seen on Samsung Chromebook Plus. Code analysis points to
> commit 3d4ef329757c ("mmc: core: fix multi-bit bus width without
> high-speed mode"), which attempts to set the bus width for all but
> HS200 devices unconditionally. However, for HS400-ES, the bus width
> is already selected.
>
> Cc: Anssi Hannula <anssi.hannula@bitwise.fi>
> Cc: Douglas Anderson <dianders@chromium.org>
> Cc: Brian Norris <briannorris@chromium.org>
> Fixes: 3d4ef329757c ("mmc: core: fix multi-bit bus width ...")
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/mmc/core/mmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
> index 7fd722868875..b502601df228 100644
> --- a/drivers/mmc/core/mmc.c
> +++ b/drivers/mmc/core/mmc.c
> @@ -1730,7 +1730,7 @@ static int mmc_init_card(struct mmc_host *host, u32 ocr,
> err = mmc_select_hs400(card);
> if (err)
> goto free_card;
> - } else {
> + } else if (!mmc_card_hs400es(card)) {
> /* Select the desired bus width optionally */
> err = mmc_select_bus_width(card);
> if (err > 0 && mmc_card_hs(card)) {
Right, so the key point here is that for normal hs400 we hit the
"mmc_card_hs200()" check above because hs400 transitions through
hs200. ...but for hs400es we don't do that transition (we jump
straight to hs400-es), so we need an extra case to avoid this
problematic mmc_select_bus_width().
Reviewed-by: Douglas Anderson <dianders@chromium.org>
-Doug
[toc] | [prev] | [next] | [standalone]
| From | Shawn Lin <shawn.lin@rock-chips.com> |
|---|---|
| Date | 2017-03-02 02:20 +0100 |
| Message-ID | <tgnzs-34a-23@gated-at.bofh.it> |
| In reply to | #1590685 |
On 2017/3/2 6:11, Guenter Roeck wrote:
> HS400-ES devices fail to initialize with the following error messages.
>
> mmc1: power class selection to bus width 8 ddr 0 failed
> mmc1: error -110 whilst initialising MMC card
>
> This was seen on Samsung Chromebook Plus. Code analysis points to
> commit 3d4ef329757c ("mmc: core: fix multi-bit bus width without
> high-speed mode"), which attempts to set the bus width for all but
> HS200 devices unconditionally. However, for HS400-ES, the bus width
> is already selected.
>
Thanks Guenter for catching this early!
Well, I wasn't cc'ed for that patch and it was queued for just one day
without fully reviewed. And Doug pointed out the key point here, so,
Reviewed-by: Shawn Lin <shawn.lin@rock-chip.com>
btw, I think kernelci need some rk3399 platforms with hs400es
and CQ engine support for future test. I will try to find a way
to help kernelci to get some boards if possible..
> Cc: Anssi Hannula <anssi.hannula@bitwise.fi>
> Cc: Douglas Anderson <dianders@chromium.org>
> Cc: Brian Norris <briannorris@chromium.org>
> Fixes: 3d4ef329757c ("mmc: core: fix multi-bit bus width ...")
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/mmc/core/mmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
> index 7fd722868875..b502601df228 100644
> --- a/drivers/mmc/core/mmc.c
> +++ b/drivers/mmc/core/mmc.c
> @@ -1730,7 +1730,7 @@ static int mmc_init_card(struct mmc_host *host, u32 ocr,
> err = mmc_select_hs400(card);
> if (err)
> goto free_card;
> - } else {
> + } else if (!mmc_card_hs400es(card)) {
> /* Select the desired bus width optionally */
> err = mmc_select_bus_width(card);
> if (err > 0 && mmc_card_hs(card)) {
>
--
Best Regards
Shawn Lin
[toc] | [prev] | [next] | [standalone]
| From | Guenter Roeck <linux@roeck-us.net> |
|---|---|
| Date | 2017-03-07 04:50 +0100 |
| Message-ID | <tieil-1rh-9@gated-at.bofh.it> |
| In reply to | #1590685 |
ping ...
Ulf,
I know it is early for a ping. However, the patch causing all HS400-ES
devices to fail already made it into various stable releases, and I think
it would be very desirable to get those back to working.
Thanks,
Guenter
On Wed, Mar 01, 2017 at 02:11:47PM -0800, Guenter Roeck wrote:
> HS400-ES devices fail to initialize with the following error messages.
>
> mmc1: power class selection to bus width 8 ddr 0 failed
> mmc1: error -110 whilst initialising MMC card
>
> This was seen on Samsung Chromebook Plus. Code analysis points to
> commit 3d4ef329757c ("mmc: core: fix multi-bit bus width without
> high-speed mode"), which attempts to set the bus width for all but
> HS200 devices unconditionally. However, for HS400-ES, the bus width
> is already selected.
>
> Cc: Anssi Hannula <anssi.hannula@bitwise.fi>
> Cc: Douglas Anderson <dianders@chromium.org>
> Cc: Brian Norris <briannorris@chromium.org>
> Fixes: 3d4ef329757c ("mmc: core: fix multi-bit bus width ...")
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/mmc/core/mmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
> index 7fd722868875..b502601df228 100644
> --- a/drivers/mmc/core/mmc.c
> +++ b/drivers/mmc/core/mmc.c
> @@ -1730,7 +1730,7 @@ static int mmc_init_card(struct mmc_host *host, u32 ocr,
> err = mmc_select_hs400(card);
> if (err)
> goto free_card;
> - } else {
> + } else if (!mmc_card_hs400es(card)) {
> /* Select the desired bus width optionally */
> err = mmc_select_bus_width(card);
> if (err > 0 && mmc_card_hs(card)) {
> --
> 2.7.4
>
[toc] | [prev] | [next] | [standalone]
| From | Heiko Stübner <heiko@sntech.de> |
|---|---|
| Date | 2017-03-10 09:50 +0100 |
| Subject | Re: mmc: core: Fix access to HS400-ES devices |
| Message-ID | <tjopj-1j2-13@gated-at.bofh.it> |
| In reply to | #1590685 |
Am Mittwoch, 1. März 2017, 14:11:47 CET schrieb Guenter Roeck:
> HS400-ES devices fail to initialize with the following error messages.
>
> mmc1: power class selection to bus width 8 ddr 0 failed
> mmc1: error -110 whilst initialising MMC card
>
> This was seen on Samsung Chromebook Plus. Code analysis points to
> commit 3d4ef329757c ("mmc: core: fix multi-bit bus width without
> high-speed mode"), which attempts to set the bus width for all but
> HS200 devices unconditionally. However, for HS400-ES, the bus width
> is already selected.
>
> Cc: Anssi Hannula <anssi.hannula@bitwise.fi>
> Cc: Douglas Anderson <dianders@chromium.org>
> Cc: Brian Norris <briannorris@chromium.org>
> Fixes: 3d4ef329757c ("mmc: core: fix multi-bit bus width ...")
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
> Reviewed-by: Shawn Lin <shawn.lin@rock-chip.com>
On a rk3399-kevin and the current mainline kernel from 20170309 it makes the
issue go away and the emmc work again, so
Tested-by: Heiko Stuebner <heiko@sntech.de>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web