Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1590770

Re: [PATCH] mmc: core: Fix access to HS400-ES devices

Show all headers | View raw

On 2017/3/2 6:11, Guenter Roeck wrote:
> HS400-ES devices fail to initialize with the following error messages.
>
> mmc1: power class selection to bus width 8 ddr 0 failed
> mmc1: error -110 whilst initialising MMC card
>
> This was seen on Samsung Chromebook Plus. Code analysis points to
> commit 3d4ef329757c ("mmc: core: fix multi-bit bus width without
> high-speed mode"), which attempts to set the bus width for all but
> HS200 devices unconditionally. However, for HS400-ES, the bus width
> is already selected.
>

Thanks Guenter for catching this early!

Well, I wasn't cc'ed for that patch and it was queued for just one day
without fully reviewed. And Doug pointed out the key point here, so,

Reviewed-by: Shawn Lin <shawn.lin@rock-chip.com>

btw, I think kernelci need some rk3399 platforms with hs400es
and CQ engine support for future test. I will try to find a way
to help kernelci to get some boards if possible..


> Cc: Anssi Hannula <anssi.hannula@bitwise.fi>
> Cc: Douglas Anderson <dianders@chromium.org>
> Cc: Brian Norris <briannorris@chromium.org>
> Fixes: 3d4ef329757c ("mmc: core: fix multi-bit bus width ...")
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
>  drivers/mmc/core/mmc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
> index 7fd722868875..b502601df228 100644
> --- a/drivers/mmc/core/mmc.c
> +++ b/drivers/mmc/core/mmc.c
> @@ -1730,7 +1730,7 @@ static int mmc_init_card(struct mmc_host *host, u32 ocr,
>  		err = mmc_select_hs400(card);
>  		if (err)
>  			goto free_card;
> -	} else {
> +	} else if (!mmc_card_hs400es(card)) {
>  		/* Select the desired bus width optionally */
>  		err = mmc_select_bus_width(card);
>  		if (err > 0 && mmc_card_hs(card)) {
>


-- 
Best Regards
Shawn Lin

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] mmc: core: Fix access to HS400-ES devices Guenter Roeck <linux@roeck-us.net> - 2017-03-02 00:20 +0100
  Re: [PATCH] mmc: core: Fix access to HS400-ES devices Doug Anderson <dianders@chromium.org> - 2017-03-02 00:40 +0100
  Re: [PATCH] mmc: core: Fix access to HS400-ES devices Shawn Lin <shawn.lin@rock-chips.com> - 2017-03-02 02:20 +0100
  Re: [PATCH] mmc: core: Fix access to HS400-ES devices Guenter Roeck <linux@roeck-us.net> - 2017-03-07 04:50 +0100
  Re: mmc: core: Fix access to HS400-ES devices Heiko Stübner <heiko@sntech.de> - 2017-03-10 09:50 +0100

csiph-web