Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1592592 > unrolled thread

Re: [PATCH] scsi: lpfc: remove redundant assignment of sgel

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] scsi: lpfc: remove redundant assignment of sgel James Smart <james.smart@broadcom.com> - 2017-03-04 18:50 +0100

#1592592 — Re: [PATCH] scsi: lpfc: remove redundant assignment of sgel

Looks good. I included it in the lpfc patch set just posted.

-- james



On 2/24/2017 5:45 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> In the NVMET_FCOP_RSP case, sgel is assigned but never used and
> hence is redundant and can be removed.
>
> Detected by CoverityScan, CID#1411658 ("Unused value")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   drivers/scsi/lpfc/lpfc_nvmet.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_nvmet.c b/drivers/scsi/lpfc/lpfc_nvmet.c
> index c421e17..e59a0a8 100644
> --- a/drivers/scsi/lpfc/lpfc_nvmet.c
> +++ b/drivers/scsi/lpfc/lpfc_nvmet.c
> @@ -1445,7 +1445,6 @@ lpfc_nvmet_prep_fcp_wqe(struct lpfc_hba *phba,
>   
>   	case NVMET_FCOP_RSP:
>   		/* Words 0 - 2 */
> -		sgel = &rsp->sg[0];
>   		physaddr = rsp->rspdma;
>   		wqe->fcp_trsp.bde.tus.f.bdeFlags = BUFF_TYPE_BDE_64;
>   		wqe->fcp_trsp.bde.tus.f.bdeSize = rsp->rsplen;

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web