Re: [PATCH] scsi: lpfc: remove redundant assignment of sgel

From	James Smart <james.smart@broadcom.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] scsi: lpfc: remove redundant assignment of sgel
Date	2017-03-04 18:50 +0100
Message-ID	<thlYC-4gH-25@gated-at.bofh.it> (permalink)
References	<teopY-Q9-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Looks good. I included it in the lpfc patch set just posted.

-- james



On 2/24/2017 5:45 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> In the NVMET_FCOP_RSP case, sgel is assigned but never used and
> hence is redundant and can be removed.
>
> Detected by CoverityScan, CID#1411658 ("Unused value")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   drivers/scsi/lpfc/lpfc_nvmet.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_nvmet.c b/drivers/scsi/lpfc/lpfc_nvmet.c
> index c421e17..e59a0a8 100644
> --- a/drivers/scsi/lpfc/lpfc_nvmet.c
> +++ b/drivers/scsi/lpfc/lpfc_nvmet.c
> @@ -1445,7 +1445,6 @@ lpfc_nvmet_prep_fcp_wqe(struct lpfc_hba *phba,
>   
>   	case NVMET_FCOP_RSP:
>   		/* Words 0 - 2 */
> -		sgel = &rsp->sg[0];
>   		physaddr = rsp->rspdma;
>   		wqe->fcp_trsp.bde.tus.f.bdeFlags = BUFF_TYPE_BDE_64;
>   		wqe->fcp_trsp.bde.tus.f.bdeSize = rsp->rsplen;

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] scsi: lpfc: remove redundant assignment of sgel James Smart <james.smart@broadcom.com> - 2017-03-04 18:50 +0100

csiph-web