Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1593263 > unrolled thread
| Started by | Jiri Kosina <jikos@kernel.org> |
|---|---|
| First post | 2017-03-06 13:20 +0100 |
| Last post | 2017-03-06 15:50 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v2 05/15] HID: logitech-hidpp: forward device info in power_supply Jiri Kosina <jikos@kernel.org> - 2017-03-06 13:20 +0100
Re: [PATCH v2 05/15] HID: logitech-hidpp: forward device info in power_supply Bastien Nocera <hadess@hadess.net> - 2017-03-06 13:40 +0100
Re: [PATCH v2 05/15] HID: logitech-hidpp: forward device info in power_supply Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2017-03-06 15:50 +0100
| From | Jiri Kosina <jikos@kernel.org> |
|---|---|
| Date | 2017-03-06 13:20 +0100 |
| Subject | Re: [PATCH v2 05/15] HID: logitech-hidpp: forward device info in power_supply |
| Message-ID | <thZMm-83M-17@gated-at.bofh.it> |
On Tue, 7 Feb 2017, Benjamin Tissoires wrote: > > > + case POWER_SUPPLY_PROP_MANUFACTURER: > > > + val->strval = "Logitech, Inc."; > > > > I don't like this change. I'd prefer the concatenated manufacturer and > > model strings leading to user-friendly strings, and "Logitech T650" is > > better than "Logitech, Inc. T650". > > Is this the only problematic issue? We are at rc7 already so I would > like to have the final version ready ASAP. Bastien, do you have any input on the rest of the series please? Thanks, -- Jiri Kosina SUSE Labs
[toc] | [next] | [standalone]
| From | Bastien Nocera <hadess@hadess.net> |
|---|---|
| Date | 2017-03-06 13:40 +0100 |
| Message-ID | <ti05H-8bx-3@gated-at.bofh.it> |
| In reply to | #1593263 |
On Mon, 2017-03-06 at 13:18 +0100, Jiri Kosina wrote: > On Tue, 7 Feb 2017, Benjamin Tissoires wrote: > > > > > + case POWER_SUPPLY_PROP_MANUFACTURER: > > > > + val->strval = "Logitech, Inc."; > > > > > > I don't like this change. I'd prefer the concatenated > > > manufacturer and > > > model strings leading to user-friendly strings, and "Logitech > > > T650" is > > > better than "Logitech, Inc. T650". > > > > Is this the only problematic issue? We are at rc7 already so I > > would > > like to have the final version ready ASAP. > > Bastien, do you have any input on the rest of the series please? My comment about "[PATCH 04/15] HID: logitech-hidpp: battery: remove overloads and provide ONLINE" is the blocker. No particular comments about the rest of the series.
[toc] | [prev] | [next] | [standalone]
| From | Benjamin Tissoires <benjamin.tissoires@redhat.com> |
|---|---|
| Date | 2017-03-06 15:50 +0100 |
| Message-ID | <ti27w-199-9@gated-at.bofh.it> |
| In reply to | #1593273 |
On Mar 06 2017 or thereabouts, Bastien Nocera wrote: > On Mon, 2017-03-06 at 13:18 +0100, Jiri Kosina wrote: > > On Tue, 7 Feb 2017, Benjamin Tissoires wrote: > > > > > > > + case POWER_SUPPLY_PROP_MANUFACTURER: > > > > > + val->strval = "Logitech, Inc."; > > > > > > > > I don't like this change. I'd prefer the concatenated > > > > manufacturer and > > > > model strings leading to user-friendly strings, and "Logitech > > > > T650" is > > > > better than "Logitech, Inc. T650". > > > > > > Is this the only problematic issue? We are at rc7 already so I > > > would > > > like to have the final version ready ASAP. > > > > Bastien, do you have any input on the rest of the series please? > > My comment about "[PATCH 04/15] HID: logitech-hidpp: battery: remove > overloads and provide ONLINE" is the blocker. > > No particular comments about the rest of the series. Yes, sorry, this is still on my plate. I'll send out a revised series soon hopefully. Cheers, Benjamin
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web