Re: [PATCH v2 05/15] HID: logitech-hidpp: forward device info in power_supply

From	Jiri Kosina <jikos@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 05/15] HID: logitech-hidpp: forward device info in power_supply
Date	2017-03-06 13:20 +0100
Message-ID	<thZMm-83M-17@gated-at.bofh.it> (permalink)
References	<t6qoV-58b-3@gated-at.bofh.it> <t6qoW-58b-23@gated-at.bofh.it> <t6NES-38j-29@gated-at.bofh.it> <t89tD-rN-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, 7 Feb 2017, Benjamin Tissoires wrote:

> > > +               case POWER_SUPPLY_PROP_MANUFACTURER:
> > > +                       val->strval = "Logitech, Inc.";
> > 
> > I don't like this change. I'd prefer the concatenated manufacturer and
> > model strings leading to user-friendly strings, and "Logitech T650" is
> > better than "Logitech, Inc. T650".
> 
> Is this the only problematic issue? We are at rc7 already so I would
> like to have the final version ready ASAP.

Bastien, do you have any input on the rest of the series please?

Thanks,

-- 
Jiri Kosina
SUSE Labs

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 05/15] HID: logitech-hidpp: forward device info in  power_supply Jiri Kosina <jikos@kernel.org> - 2017-03-06 13:20 +0100
  Re: [PATCH v2 05/15] HID: logitech-hidpp: forward device info in  power_supply Bastien Nocera <hadess@hadess.net> - 2017-03-06 13:40 +0100
    Re: [PATCH v2 05/15] HID: logitech-hidpp: forward device info in  power_supply Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2017-03-06 15:50 +0100

csiph-web