Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1592899 > unrolled thread
| Started by | Mark Stenglein <mark@stengle.in> |
|---|---|
| First post | 2017-03-06 03:40 +0100 |
| Last post | 2017-03-07 20:30 +0100 |
| Articles | 5 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] Staging: wlan-ng: hfa384x.h: fixed a newline coding style issue Mark Stenglein <mark@stengle.in> - 2017-03-06 03:40 +0100
Re: [PATCH] Staging: wlan-ng: hfa384x.h: fixed a newline coding style issue Greg KH <gregkh@linuxfoundation.org> - 2017-03-06 08:00 +0100
Re: [PATCH] Staging: wlan-ng: hfa384x.h: fixed a newline coding style issue Dan Carpenter <dan.carpenter@oracle.com> - 2017-03-07 18:40 +0100
Re: [PATCH] Staging: wlan-ng: hfa384x.h: fixed a newline coding style issue Dan Carpenter <dan.carpenter@oracle.com> - 2017-03-07 18:50 +0100
Re: [PATCH] Staging: wlan-ng: hfa384x.h: fixed a newline coding style issue Mark Stenglein <mark@stengle.in> - 2017-03-07 20:30 +0100
| From | Mark Stenglein <mark@stengle.in> |
|---|---|
| Date | 2017-03-06 03:40 +0100 |
| Subject | [PATCH] Staging: wlan-ng: hfa384x.h: fixed a newline coding style issue |
| Message-ID | <thQJ3-19o-7@gated-at.bofh.it> |
Fixed a coding style issue.
Signed-off-by: Mark Stenglein <mark@stengle.in>
---
drivers/staging/wlan-ng/hfa384x.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h
index 5f1851c85f12..f19984747b1e 100644
--- a/drivers/staging/wlan-ng/hfa384x.h
+++ b/drivers/staging/wlan-ng/hfa384x.h
@@ -1175,6 +1175,7 @@ struct hfa384x_usbctlx {
enum ctlx_state state; /* Tracks running state */
struct completion done;
+
volatile int reapable; /* Food for the reaper task */
ctlx_cmdcb_t cmdcb; /* Async command callback */
--
2.12.0
[toc] | [next] | [standalone]
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2017-03-06 08:00 +0100 |
| Subject | Re: [PATCH] Staging: wlan-ng: hfa384x.h: fixed a newline coding style issue |
| Message-ID | <thUMG-43s-11@gated-at.bofh.it> |
| In reply to | #1592899 |
On Sun, Mar 05, 2017 at 09:09:12PM -0500, Mark Stenglein wrote:
> Fixed a coding style issue.
What issue would that be?
> Signed-off-by: Mark Stenglein <mark@stengle.in>
> ---
> drivers/staging/wlan-ng/hfa384x.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h
> index 5f1851c85f12..f19984747b1e 100644
> --- a/drivers/staging/wlan-ng/hfa384x.h
> +++ b/drivers/staging/wlan-ng/hfa384x.h
> @@ -1175,6 +1175,7 @@ struct hfa384x_usbctlx {
> enum ctlx_state state; /* Tracks running state */
>
> struct completion done;
> +
> volatile int reapable; /* Food for the reaper task */
What is wrong with the original code here?
Please don't blindly trust checkpatch.pl all the time, sometimes you
have to use your brain when reading the results.
thanks,
greg k-h
[toc] | [prev] | [next] | [standalone]
| From | Dan Carpenter <dan.carpenter@oracle.com> |
|---|---|
| Date | 2017-03-07 18:40 +0100 |
| Subject | Re: [PATCH] Staging: wlan-ng: hfa384x.h: fixed a newline coding style issue |
| Message-ID | <tirfz-2oi-1@gated-at.bofh.it> |
| In reply to | #1592899 |
On Sun, Mar 05, 2017 at 09:09:12PM -0500, Mark Stenglein wrote:
> Fixed a coding style issue.
>
> Signed-off-by: Mark Stenglein <mark@stengle.in>
> ---
> drivers/staging/wlan-ng/hfa384x.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h
> index 5f1851c85f12..f19984747b1e 100644
> --- a/drivers/staging/wlan-ng/hfa384x.h
> +++ b/drivers/staging/wlan-ng/hfa384x.h
> @@ -1175,6 +1175,7 @@ struct hfa384x_usbctlx {
> enum ctlx_state state; /* Tracks running state */
>
> struct completion done;
> +
> volatile int reapable; /* Food for the reaper task */
No blank line needed. The original is OK. (Except for the volatile is
wrong obviously).
regards,
dan carpenter
[toc] | [prev] | [next] | [standalone]
| From | Dan Carpenter <dan.carpenter@oracle.com> |
|---|---|
| Date | 2017-03-07 18:50 +0100 |
| Subject | Re: [PATCH] Staging: wlan-ng: hfa384x.h: fixed a newline coding style issue |
| Message-ID | <tirph-2s0-37@gated-at.bofh.it> |
| In reply to | #1594453 |
On Tue, Mar 07, 2017 at 12:36:46PM -0500, Mark Stenglein wrote: > All, > > Thanks for the feedback. Trying to introduce myself and in retrospect > this seems to be a fairly non-productive way to go about it. Apologies > for any time lost. > It's fine. I'm just rushing through patches as fast as possible. It doesn't take any time. regards, dan carpenter
[toc] | [prev] | [next] | [standalone]
| From | Mark Stenglein <mark@stengle.in> |
|---|---|
| Date | 2017-03-07 20:30 +0100 |
| Subject | Re: [PATCH] Staging: wlan-ng: hfa384x.h: fixed a newline coding style issue |
| Message-ID | <tirph-2s0-39@gated-at.bofh.it> |
| In reply to | #1594453 |
All,
Thanks for the feedback. Trying to introduce myself and in retrospect
this seems to be a fairly non-productive way to go about it. Apologies
for any time lost.
Best,
Mark Stenglein
On Tue, Mar 07, 2017 at 08:31:13PM +0300, Dan Carpenter wrote:
> On Sun, Mar 05, 2017 at 09:09:12PM -0500, Mark Stenglein wrote:
> > Fixed a coding style issue.
> >
> > Signed-off-by: Mark Stenglein <mark@stengle.in>
> > ---
> > drivers/staging/wlan-ng/hfa384x.h | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h
> > index 5f1851c85f12..f19984747b1e 100644
> > --- a/drivers/staging/wlan-ng/hfa384x.h
> > +++ b/drivers/staging/wlan-ng/hfa384x.h
> > @@ -1175,6 +1175,7 @@ struct hfa384x_usbctlx {
> > enum ctlx_state state; /* Tracks running state */
> >
> > struct completion done;
> > +
> > volatile int reapable; /* Food for the reaper task */
>
> No blank line needed. The original is OK. (Except for the volatile is
> wrong obviously).
>
> regards,
> dan carpenter
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web