Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1590803 > unrolled thread

Re: [PATCH 0/4] Improve intel-hid's self-consistency

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 0/4] Improve intel-hid's self-consistency Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-03-02 03:20 +0100
    Re: [PATCH 0/4] Improve intel-hid's self-consistency Alex Hung <alex.hung@canonical.com> - 2017-03-02 11:30 +0100
      Re: [PATCH 0/4] Improve intel-hid's self-consistency Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-03-03 19:40 +0100

#1590803 — Re: [PATCH 0/4] Improve intel-hid's self-consistency

On Fri, Feb 24, 2017 at 12:33 PM, Michał Kępień <kernel@kempniu.pl> wrote:
> Commit 2cfa4b311acc ("platform/x86: intel-hid: Support 5 button array")
> contains some coding style cleanups compared to the code it was based
> on.  This patch series "backports" these cleanups to the rest of the
> driver in order to make it more self-consistent and removes a redundant
> set_bit() call as a bonus.
>
> This series was not tested on hardware supported by intel-hid.

Alex, do you have an access to hardware to test? I wouldn't going to
apply this until I get your tag(s) (in the best case
Reviewed-and-tested-by).

-- 
With Best Regards,
Andy Shevchenko

[toc] | [next] | [standalone]

#1590963

On Thu, Mar 2, 2017 at 7:03 AM, Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Fri, Feb 24, 2017 at 12:33 PM, Michał Kępień <kernel@kempniu.pl> wrote:
>> Commit 2cfa4b311acc ("platform/x86: intel-hid: Support 5 button array")
>> contains some coding style cleanups compared to the code it was based
>> on.  This patch series "backports" these cleanups to the rest of the
>> driver in order to make it more self-consistent and removes a redundant
>> set_bit() call as a bonus.
>>
>> This series was not tested on hardware supported by intel-hid.
>
> Alex, do you have an access to hardware to test? I wouldn't going to
> apply this until I get your tag(s) (in the best case
> Reviewed-and-tested-by).

The patches look good and tested on Latitude 7480

Reviewed-and-tested-by: Alex Hung <alex.hung@canonical.com>

>
> --
> With Best Regards,
> Andy Shevchenko

[toc] | [prev] | [next] | [standalone]

#1592200

On Thu, Mar 2, 2017 at 12:17 PM, Alex Hung <alex.hung@canonical.com> wrote:
> On Thu, Mar 2, 2017 at 7:03 AM, Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
>> On Fri, Feb 24, 2017 at 12:33 PM, Michał Kępień <kernel@kempniu.pl> wrote:
>>> Commit 2cfa4b311acc ("platform/x86: intel-hid: Support 5 button array")
>>> contains some coding style cleanups compared to the code it was based
>>> on.  This patch series "backports" these cleanups to the rest of the
>>> driver in order to make it more self-consistent and removes a redundant
>>> set_bit() call as a bonus.
>>>
>>> This series was not tested on hardware supported by intel-hid.
>>
>> Alex, do you have an access to hardware to test? I wouldn't going to
>> apply this until I get your tag(s) (in the best case
>> Reviewed-and-tested-by).
>
> The patches look good and tested on Latitude 7480
>
> Reviewed-and-tested-by: Alex Hung <alex.hung@canonical.com>

Pushed to testing.
Thanks.

-- 
With Best Regards,
Andy Shevchenko

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web