Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1588278 > unrolled thread

Recommended notation for OPP to avoid DTC warnings

Started byMasahiro Yamada <yamada.masahiro@socionext.com>
First post2017-02-26 06:40 +0100
Last post2017-02-27 12:30 +0100
Articles 5 — 3 participants

Back to article view | Back to linux.kernel

Contents

  Recommended notation for OPP to avoid DTC warnings Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-02-26 06:40 +0100
    Re: Recommended notation for OPP to avoid DTC warnings Viresh Kumar <viresh.kumar@linaro.org> - 2017-02-27 05:20 +0100
    Re: Recommended notation for OPP to avoid DTC warnings Mark Rutland <mark.rutland@arm.com> - 2017-02-27 12:00 +0100
      Re: Recommended notation for OPP to avoid DTC warnings Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-02-27 12:00 +0100
      Re: Recommended notation for OPP to avoid DTC warnings Viresh Kumar <viresh.kumar@linaro.org> - 2017-02-27 12:30 +0100

#1588278 — Recommended notation for OPP to avoid DTC warnings

FromMasahiro Yamada <yamada.masahiro@socionext.com>
Date2017-02-26 06:40 +0100
SubjectRecommended notation for OPP to avoid DTC warnings
Message-ID<teZIR-2eX-5@gated-at.bofh.it>
Hi.


Decumentation/devicetree/bindings/opp/opp.txt
takes examples like this:

        opp@1000000000 {
                opp-hz = /bits/ 64 <1000000000>;
                opp-microvolt = <970000 975000 985000>;
                opp-microamp = <70000>;
                clock-latency-ns = <300000>;
                opp-suspend;
        };
        opp@1100000000 {
                opp-hz = /bits/ 64 <1100000000>;
                opp-microvolt = <980000 1000000 1010000>;
                opp-microamp = <80000>;
                clock-latency-ns = <310000>;
        };
        opp@1200000000 {
                opp-hz = /bits/ 64 <1200000000>;
                opp-microvolt = <1025000>;
                clock-latency-ns = <290000>;
                turbo-mode;
        };


If we follow this notation and the device-tree is built with W=1,
DTC warns like follows:


Warning (unit_address_vs_reg): Node /opp_table0/opp@1000000000 has a
unit name, but no reg property


Is there a recommended notation to avoid it?

Maybe, simply omit the "@" ?



-- 
Best Regards
Masahiro Yamada

[toc] | [next] | [standalone]

#1588504

FromViresh Kumar <viresh.kumar@linaro.org>
Date2017-02-27 05:20 +0100
Message-ID<tfkWZ-8ul-3@gated-at.bofh.it>
In reply to#1588278
On 26-02-17, 14:18, Masahiro Yamada wrote:
> Hi.
> 
> 
> Decumentation/devicetree/bindings/opp/opp.txt
> takes examples like this:
> 
>         opp@1000000000 {
>                 opp-hz = /bits/ 64 <1000000000>;
>                 opp-microvolt = <970000 975000 985000>;
>                 opp-microamp = <70000>;
>                 clock-latency-ns = <300000>;
>                 opp-suspend;
>         };
>         opp@1100000000 {
>                 opp-hz = /bits/ 64 <1100000000>;
>                 opp-microvolt = <980000 1000000 1010000>;
>                 opp-microamp = <80000>;
>                 clock-latency-ns = <310000>;
>         };
>         opp@1200000000 {
>                 opp-hz = /bits/ 64 <1200000000>;
>                 opp-microvolt = <1025000>;
>                 clock-latency-ns = <290000>;
>                 turbo-mode;
>         };
> 
> 
> If we follow this notation and the device-tree is built with W=1,
> DTC warns like follows:
> 
> 
> Warning (unit_address_vs_reg): Node /opp_table0/opp@1000000000 has a
> unit name, but no reg property
> 
> 
> Is there a recommended notation to avoid it?
> 
> Maybe, simply omit the "@" ?

I would let Rob suggest something here.

-- 
viresh

[toc] | [prev] | [next] | [standalone]

#1588603

FromMark Rutland <mark.rutland@arm.com>
Date2017-02-27 12:00 +0100
Message-ID<tfrc6-4pq-7@gated-at.bofh.it>
In reply to#1588278
On Sun, Feb 26, 2017 at 02:18:03PM +0900, Masahiro Yamada wrote:
> Hi.
> 
> 
> Decumentation/devicetree/bindings/opp/opp.txt
> takes examples like this:
> 
>         opp@1000000000 {
>                 opp-hz = /bits/ 64 <1000000000>;
>                 opp-microvolt = <970000 975000 985000>;
>                 opp-microamp = <70000>;
>                 clock-latency-ns = <300000>;
>                 opp-suspend;
>         };

> If we follow this notation and the device-tree is built with W=1,
> DTC warns like follows:
> 
> Warning (unit_address_vs_reg): Node /opp_table0/opp@1000000000 has a
> unit name, but no reg property
> 
> Is there a recommended notation to avoid it?
> 
> Maybe, simply omit the "@" ?

I think just s/@/-/ should be fine, e.g. call the above opp-1000000000.

Thanks,
Mark.

[toc] | [prev] | [next] | [standalone]

#1588605

FromMasahiro Yamada <yamada.masahiro@socionext.com>
Date2017-02-27 12:00 +0100
Message-ID<tfrc6-4pq-15@gated-at.bofh.it>
In reply to#1588603
2017-02-27 19:55 GMT+09:00 Viresh Kumar <viresh.kumar@linaro.org>:
> On 27-02-17, 10:44, Mark Rutland wrote:
>> On Sun, Feb 26, 2017 at 02:18:03PM +0900, Masahiro Yamada wrote:
>> > Hi.
>> >
>> >
>> > Decumentation/devicetree/bindings/opp/opp.txt
>> > takes examples like this:
>> >
>> >         opp@1000000000 {
>> >                 opp-hz = /bits/ 64 <1000000000>;
>> >                 opp-microvolt = <970000 975000 985000>;
>> >                 opp-microamp = <70000>;
>> >                 clock-latency-ns = <300000>;
>> >                 opp-suspend;
>> >         };
>>
>> > If we follow this notation and the device-tree is built with W=1,
>> > DTC warns like follows:
>> >
>> > Warning (unit_address_vs_reg): Node /opp_table0/opp@1000000000 has a
>> > unit name, but no reg property
>> >
>> > Is there a recommended notation to avoid it?
>> >
>> > Maybe, simply omit the "@" ?
>>
>> I think just s/@/-/ should be fine, e.g. call the above opp-1000000000.
>
> That's fine with me. I can send a patch to fix all existing users if we all
> agree for it.


OK with me.

Also, please remember to update the examples
in Documentation/devicetree/bindings/opp/opp.txt





-- 
Best Regards
Masahiro Yamada

[toc] | [prev] | [next] | [standalone]

#1588615

FromViresh Kumar <viresh.kumar@linaro.org>
Date2017-02-27 12:30 +0100
Message-ID<tfrc6-4pq-17@gated-at.bofh.it>
In reply to#1588603
On 27-02-17, 10:44, Mark Rutland wrote:
> On Sun, Feb 26, 2017 at 02:18:03PM +0900, Masahiro Yamada wrote:
> > Hi.
> > 
> > 
> > Decumentation/devicetree/bindings/opp/opp.txt
> > takes examples like this:
> > 
> >         opp@1000000000 {
> >                 opp-hz = /bits/ 64 <1000000000>;
> >                 opp-microvolt = <970000 975000 985000>;
> >                 opp-microamp = <70000>;
> >                 clock-latency-ns = <300000>;
> >                 opp-suspend;
> >         };
> 
> > If we follow this notation and the device-tree is built with W=1,
> > DTC warns like follows:
> > 
> > Warning (unit_address_vs_reg): Node /opp_table0/opp@1000000000 has a
> > unit name, but no reg property
> > 
> > Is there a recommended notation to avoid it?
> > 
> > Maybe, simply omit the "@" ?
> 
> I think just s/@/-/ should be fine, e.g. call the above opp-1000000000.

That's fine with me. I can send a patch to fix all existing users if we all
agree for it.

-- 
viresh

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web