Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1589533 > unrolled thread

[PATCH] staging: rtl8192e: removed unnecessary white lines from crtl_wx.c

Back to article view | Back to linux.kernel

Contents

  [PATCH] staging: rtl8192e: removed unnecessary white lines from  crtl_wx.c Sumantro <saggy.zone@gmail.com> - 2017-02-28 16:00 +0100
    Re: [PATCH] staging: rtl8192e: removed unnecessary white lines from  crtl_wx.c Greg KH <gregkh@linuxfoundation.org> - 2017-02-28 19:20 +0100

#1589533 — [PATCH] staging: rtl8192e: removed unnecessary white lines from crtl_wx.c

staging:rtl8192e: removed extra whitelines which were giving warnings 
Signed-off-by: Sumantro <saggy.zone@gmail.com>
---
 drivers/staging/rtl8192e/rtl8192e/rtl_wx.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
index 8ffb458..78eb871 100644
--- a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
+++ b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
@@ -475,12 +475,10 @@ static int _rtl92e_wx_set_scan(struct net_device *dev,
 	return ret;
 }
 
-
 static int _rtl92e_wx_get_scan(struct net_device *dev,
 			       struct iw_request_info *a,
 			       union iwreq_data *wrqu, char *b)
 {
-
 	int ret;
 	struct r8192_priv *priv = rtllib_priv(dev);
 
@@ -654,7 +652,6 @@ static int _rtl92e_wx_set_wap(struct net_device *dev,
 
 }
 
-
 static int _rtl92e_wx_get_wap(struct net_device *dev,
 			      struct iw_request_info *info,
 			      union iwreq_data *wrqu, char *extra)
@@ -664,7 +661,6 @@ static int _rtl92e_wx_get_wap(struct net_device *dev,
 	return rtllib_wx_get_wap(priv->rtllib, info, wrqu, extra);
 }
 
-
 static int _rtl92e_wx_get_enc(struct net_device *dev,
 			      struct iw_request_info *info,
 			      union iwreq_data *wrqu, char *key)
@@ -831,7 +827,6 @@ static int _rtl92e_wx_get_retry(struct net_device *dev,
 {
 	struct r8192_priv *priv = rtllib_priv(dev);
 
-
 	wrqu->retry.disabled = 0; /* can't be disabled */
 
 	if ((wrqu->retry.flags & IW_RETRY_TYPE) ==
@@ -969,7 +964,6 @@ static int _rtl92e_wx_set_encode_ext(struct net_device *dev,
 	priv->rtllib->wx_set_enc = 0;
 	mutex_unlock(&priv->wx_mutex);
 	return ret;
-
 }
 
 static int _rtl92e_wx_set_auth(struct net_device *dev,
-- 
2.7.4

[toc] | [next] | [standalone]

#1589668

On Tue, Feb 28, 2017 at 08:16:25PM +0530, Sumantro wrote:
> staging:rtl8192e: removed extra whitelines which were giving warnings 
> Signed-off-by: Sumantro <saggy.zone@gmail.com>

We need a blank line before the signed-off-by line, as well as a
"real/full" name being used (unless you use only "Sumantro" on legal
documents.)

Also, you need to be a bit more verbose in the changelog text, no need
to repeat the driver and subsystem name, it's up there in the subject
line.

Look at other patches for the driver for examples of what needs to be
done here.

thanks,

greg k-h

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web