Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1589668

Re: [PATCH] staging: rtl8192e: removed unnecessary white lines from crtl_wx.c

Show all headers | View raw

On Tue, Feb 28, 2017 at 08:16:25PM +0530, Sumantro wrote:
> staging:rtl8192e: removed extra whitelines which were giving warnings 
> Signed-off-by: Sumantro <saggy.zone@gmail.com>

We need a blank line before the signed-off-by line, as well as a
"real/full" name being used (unless you use only "Sumantro" on legal
documents.)

Also, you need to be a bit more verbose in the changelog text, no need
to repeat the driver and subsystem name, it's up there in the subject
line.

Look at other patches for the driver for examples of what needs to be
done here.

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] staging: rtl8192e: removed unnecessary white lines from  crtl_wx.c Sumantro <saggy.zone@gmail.com> - 2017-02-28 16:00 +0100
  Re: [PATCH] staging: rtl8192e: removed unnecessary white lines from  crtl_wx.c Greg KH <gregkh@linuxfoundation.org> - 2017-02-28 19:20 +0100

csiph-web