Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1588998 > unrolled thread
| Started by | Ruslan Bilovol <ruslan.bilovol@gmail.com> |
|---|---|
| First post | 2017-02-27 23:30 +0100 |
| Last post | 2017-02-28 00:50 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH RESEND] checkpatch: remove obsolete CONFIG_EXPERIMENTAL checks Ruslan Bilovol <ruslan.bilovol@gmail.com> - 2017-02-27 23:30 +0100
Re: [PATCH RESEND] checkpatch: remove obsolete CONFIG_EXPERIMENTAL checks Kees Cook <keescook@chromium.org> - 2017-02-28 00:00 +0100
Re: [PATCH RESEND] checkpatch: remove obsolete CONFIG_EXPERIMENTAL checks Joe Perches <joe@perches.com> - 2017-02-28 00:50 +0100
| From | Ruslan Bilovol <ruslan.bilovol@gmail.com> |
|---|---|
| Date | 2017-02-27 23:30 +0100 |
| Subject | [PATCH RESEND] checkpatch: remove obsolete CONFIG_EXPERIMENTAL checks |
| Message-ID | <tfBXQ-3Cf-19@gated-at.bofh.it> |
Config EXPERIMENTAL has been removed from kernel in 2013
(see 3d374d0: "final removal of CONFIG_EXPERIMENTAL"),
there is no any reason to do these checks now.
Signed-off-by: Ruslan Bilovol <ruslan.bilovol@gmail.com>
---
scripts/checkpatch.pl | 13 -------------
1 file changed, 13 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 982c52c..e0a34e6 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2746,13 +2746,6 @@ sub process {
#print "is_start<$is_start> is_end<$is_end> length<$length>\n";
}
-# discourage the addition of CONFIG_EXPERIMENTAL in Kconfig.
- if ($realfile =~ /Kconfig/ &&
- $line =~ /.\s*depends on\s+.*\bEXPERIMENTAL\b/) {
- WARN("CONFIG_EXPERIMENTAL",
- "Use of CONFIG_EXPERIMENTAL is deprecated. For alternatives, see https://lkml.org/lkml/2012/10/23/580\n");
- }
-
# discourage the use of boolean for type definition attributes of Kconfig options
if ($realfile =~ /Kconfig/ &&
$line =~ /^\+\s*\bboolean\b/) {
@@ -3146,12 +3139,6 @@ sub process {
}
}
-# discourage the addition of CONFIG_EXPERIMENTAL in #if(def).
- if ($line =~ /^\+\s*\#\s*if.*\bCONFIG_EXPERIMENTAL\b/) {
- WARN("CONFIG_EXPERIMENTAL",
- "Use of CONFIG_EXPERIMENTAL is deprecated. For alternatives, see https://lkml.org/lkml/2012/10/23/580\n");
- }
-
# check for RCS/CVS revision markers
if ($rawline =~ /^\+.*\$(Revision|Log|Id)(?:\$|)/) {
WARN("CVS_KEYWORD",
--
1.9.1
[toc] | [next] | [standalone]
| From | Kees Cook <keescook@chromium.org> |
|---|---|
| Date | 2017-02-28 00:00 +0100 |
| Message-ID | <tfCqS-3Po-21@gated-at.bofh.it> |
| In reply to | #1588998 |
On Mon, Feb 27, 2017 at 2:21 PM, Ruslan Bilovol
<ruslan.bilovol@gmail.com> wrote:
> Config EXPERIMENTAL has been removed from kernel in 2013
> (see 3d374d0: "final removal of CONFIG_EXPERIMENTAL"),
> there is no any reason to do these checks now.
>
> Signed-off-by: Ruslan Bilovol <ruslan.bilovol@gmail.com>
Acked-by: Kees Cook <keescook@chromium.org>
-Kees
> ---
> scripts/checkpatch.pl | 13 -------------
> 1 file changed, 13 deletions(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 982c52c..e0a34e6 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2746,13 +2746,6 @@ sub process {
> #print "is_start<$is_start> is_end<$is_end> length<$length>\n";
> }
>
> -# discourage the addition of CONFIG_EXPERIMENTAL in Kconfig.
> - if ($realfile =~ /Kconfig/ &&
> - $line =~ /.\s*depends on\s+.*\bEXPERIMENTAL\b/) {
> - WARN("CONFIG_EXPERIMENTAL",
> - "Use of CONFIG_EXPERIMENTAL is deprecated. For alternatives, see https://lkml.org/lkml/2012/10/23/580\n");
> - }
> -
> # discourage the use of boolean for type definition attributes of Kconfig options
> if ($realfile =~ /Kconfig/ &&
> $line =~ /^\+\s*\bboolean\b/) {
> @@ -3146,12 +3139,6 @@ sub process {
> }
> }
>
> -# discourage the addition of CONFIG_EXPERIMENTAL in #if(def).
> - if ($line =~ /^\+\s*\#\s*if.*\bCONFIG_EXPERIMENTAL\b/) {
> - WARN("CONFIG_EXPERIMENTAL",
> - "Use of CONFIG_EXPERIMENTAL is deprecated. For alternatives, see https://lkml.org/lkml/2012/10/23/580\n");
> - }
> -
> # check for RCS/CVS revision markers
> if ($rawline =~ /^\+.*\$(Revision|Log|Id)(?:\$|)/) {
> WARN("CVS_KEYWORD",
> --
> 1.9.1
>
--
Kees Cook
Pixel Security
[toc] | [prev] | [next] | [standalone]
| From | Joe Perches <joe@perches.com> |
|---|---|
| Date | 2017-02-28 00:50 +0100 |
| Subject | Re: [PATCH RESEND] checkpatch: remove obsolete CONFIG_EXPERIMENTAL checks |
| Message-ID | <tfDdg-4qa-5@gated-at.bofh.it> |
| In reply to | #1588998 |
On Tue, 2017-02-28 at 00:21 +0200, Ruslan Bilovol wrote:
> Config EXPERIMENTAL has been removed from kernel in 2013
> (see 3d374d0: "final removal of CONFIG_EXPERIMENTAL"),
> there is no any reason to do these checks now.
> Signed-off-by: Ruslan Bilovol <ruslan.bilovol@gmail.com>
While I think all the defconfigs that have CONFIG_EXPERIMENTAL
should have those lines removed, this seems sensible enough.
$ git grep -w CONFIG_EXPERIMENTAL -- "*defconfig*" | wc -l
216
Acked-by: Joe Perches <joe@perches.com>
Here's a little script to remove the CONFIG_EXPERIMENTAL
lines from all the defconfigs too:
$ git grep -w --name-only CONFIG_EXPERIMENTAL -- "*defconfig*" | \
xargs sed -i -e '/CONFIG_EXPERIMENTAL=[yn]/d'
> ---
> scripts/checkpatch.pl | 13 -------------
> 1 file changed, 13 deletions(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 982c52c..e0a34e6 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2746,13 +2746,6 @@ sub process {
> #print "is_start<$is_start> is_end<$is_end> length<$length>\n";
> }
>
> -# discourage the addition of CONFIG_EXPERIMENTAL in Kconfig.
> - if ($realfile =~ /Kconfig/ &&
> - $line =~ /.\s*depends on\s+.*\bEXPERIMENTAL\b/) {
> - WARN("CONFIG_EXPERIMENTAL",
> - "Use of CONFIG_EXPERIMENTAL is deprecated. For alternatives, see https://lkml.org/lkml/2012/10/23/580\n");
> - }
> -
> # discourage the use of boolean for type definition attributes of Kconfig options
> if ($realfile =~ /Kconfig/ &&
> $line =~ /^\+\s*\bboolean\b/) {
> @@ -3146,12 +3139,6 @@ sub process {
> }
> }
>
> -# discourage the addition of CONFIG_EXPERIMENTAL in #if(def).
> - if ($line =~ /^\+\s*\#\s*if.*\bCONFIG_EXPERIMENTAL\b/) {
> - WARN("CONFIG_EXPERIMENTAL",
> - "Use of CONFIG_EXPERIMENTAL is deprecated. For alternatives, see https://lkml.org/lkml/2012/10/23/580\n");
> - }
> -
> # check for RCS/CVS revision markers
> if ($rawline =~ /^\+.*\$(Revision|Log|Id)(?:\$|)/) {
> WARN("CVS_KEYWORD",
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web